diff mbox series

lib/fib: remove warning about implicit 64-bit conversion

Message ID 1733281010-23780-1-git-send-email-andremue@linux.microsoft.com (mailing list archive)
State Superseded
Delegated to: David Marchand
Headers
Series lib/fib: remove warning about implicit 64-bit conversion |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-amd64-testing warning Testing issues
ci/iol-sample-apps-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-marvell-Functional success Functional Testing PASS

Commit Message

Andre Muezerie Dec. 4, 2024, 2:56 a.m. UTC 
MSVC issues the warning below:

../lib/fib/trie.c(341): warning C4334: '<<':
result of 32-bit shift implicitly converted to 64 bits
(was 64-bit shift intended?)

The fix is to cast the result explicitly to ptrdiff_t since it is used
in pointer arithmetic.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
 lib/fib/trie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Hemminger Dec. 4, 2024, 10:59 p.m. UTC | #1 
On Tue,  3 Dec 2024 18:56:50 -0800
Andre Muezerie <andremue@linux.microsoft.com> wrote:

> MSVC issues the warning below:
> 
> ../lib/fib/trie.c(341): warning C4334: '<<':
> result of 32-bit shift implicitly converted to 64 bits
> (was 64-bit shift intended?)
> 
> The fix is to cast the result explicitly to ptrdiff_t since it is used
> in pointer arithmetic.
> 
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> ---
>  lib/fib/trie.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/fib/trie.c b/lib/fib/trie.c
> index 4893f6c636..997b7cc338 100644
> --- a/lib/fib/trie.c
> +++ b/lib/fib/trie.c
> @@ -338,7 +338,7 @@ write_edge(struct rte_trie_tbl *dp, const uint8_t *ip_part, uint64_t next_hop,
>  		if (ret < 0)
>  			return ret;
>  		if (edge == LEDGE) {
> -			write_to_dp((uint8_t *)p + (1 << dp->nh_sz),
> +			write_to_dp((uint8_t *)p + (ptrdiff_t)(1 << dp->nh_sz),
>  				next_hop << 1, dp->nh_sz, UINT8_MAX - *ip_part);

You would be better to use a 64 bit shift or RTE_BIT64 for this.

			write_to_dp((uint8_t *)p + ((uintptr_t)1 << dp->nh_sz),
Andre Muezerie Dec. 5, 2024, 3:34 p.m. UTC | #2 
On Wed, Dec 04, 2024 at 02:59:40PM -0800, Stephen Hemminger wrote:
> On Tue,  3 Dec 2024 18:56:50 -0800
> Andre Muezerie <andremue@linux.microsoft.com> wrote:
> 
> > MSVC issues the warning below:
> > 
> > ../lib/fib/trie.c(341): warning C4334: '<<':
> > result of 32-bit shift implicitly converted to 64 bits
> > (was 64-bit shift intended?)
> > 
> > The fix is to cast the result explicitly to ptrdiff_t since it is used
> > in pointer arithmetic.
> > 
> > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> > ---
> >  lib/fib/trie.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/fib/trie.c b/lib/fib/trie.c
> > index 4893f6c636..997b7cc338 100644
> > --- a/lib/fib/trie.c
> > +++ b/lib/fib/trie.c
> > @@ -338,7 +338,7 @@ write_edge(struct rte_trie_tbl *dp, const uint8_t *ip_part, uint64_t next_hop,
> >  		if (ret < 0)
> >  			return ret;
> >  		if (edge == LEDGE) {
> > -			write_to_dp((uint8_t *)p + (1 << dp->nh_sz),
> > +			write_to_dp((uint8_t *)p + (ptrdiff_t)(1 << dp->nh_sz),
> >  				next_hop << 1, dp->nh_sz, UINT8_MAX - *ip_part);
> 
> You would be better to use a 64 bit shift or RTE_BIT64 for this.
> 
> 			write_to_dp((uint8_t *)p + ((uintptr_t)1 << dp->nh_sz),

Thanks for the suggestion. I'll update the patch.
diff mbox series

Patch

diff --git a/lib/fib/trie.c b/lib/fib/trie.c
index 4893f6c636..997b7cc338 100644
--- a/lib/fib/trie.c
+++ b/lib/fib/trie.c
@@ -338,7 +338,7 @@  write_edge(struct rte_trie_tbl *dp, const uint8_t *ip_part, uint64_t next_hop,
 		if (ret < 0)
 			return ret;
 		if (edge == LEDGE) {
-			write_to_dp((uint8_t *)p + (1 << dp->nh_sz),
+			write_to_dp((uint8_t *)p + (ptrdiff_t)(1 << dp->nh_sz),
 				next_hop << 1, dp->nh_sz, UINT8_MAX - *ip_part);
 		} else {
 			write_to_dp(get_tbl_p_by_idx(dp->tbl8, tbl8_idx *