diff mbox series

[v12,05/21] hash: remove use of VLAs for Windows built code

Message ID	1732225298-10322-6-git-send-email-andremue@linux.microsoft.com (mailing list archive)
State	Superseded
Delegated to:	David Marchand
Headers	From: Andre Muezerie <andremue@linux.microsoft.com> To: dev@dpdk.org Cc: Konstantin Ananyev <konstantin.ananyev@huawei.com> Subject: [PATCH v12 05/21] hash: remove use of VLAs for Windows built code Date: Thu, 21 Nov 2024 13:41:22 -0800 Message-Id: <1732225298-10322-6-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1732225298-10322-1-git-send-email-andremue@linux.microsoft.com> References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1732225298-10322-1-git-send-email-andremue@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	remove use of VLAs for Windows \| [v12,00/21] remove use of VLAs for Windows [v12,01/21] eal: include header required for alloca [v12,02/21] eal/linux: remove use of VLAs [v12,03/21] eal/common: remove use of VLAs [v12,04/21] ethdev: remove use of VLAs for Windows built code [v12,05/21] hash: remove use of VLAs for Windows built code [v12,06/21] hash/thash: remove use of VLAs for Windows built [v12,07/21] rcu: remove use of VLAs for Windows built code [v12,08/21] gro: fix overwrite unprocessed packets [v12,09/21] gro: remove use of VLAs [v12,10/21] net/ixgbe: remove use of VLAs [v12,11/21] net/ice: remove use of VLAs [v12,12/21] app/testpmd: remove use of VLAs for Windows built [v12,13/21] test: remove use of VLAs for Windows built code [v12,14/21] common/idpf: remove use of VLAs for Windows built code [v12,15/21] net/i40e: remove use of VLAs for Windows built code [v12,16/21] common/mlx5: remove use of VLAs for Windows built code [v12,17/21] net/mlx5: remove use of VLAs for Windows built code [v12,18/21] build: enable vla warnings on Windows built code [v12,19/21] test: remove use of VLAs for Windows built code in bitset tests [v12,20/21] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd [v12,21/21] hash: remove use of VLAs by using standard arrays

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Andre Muezerie Nov. 21, 2024, 9:41 p.m. UTC

From: Konstantin Ananyev <konstantin.ananyev@huawei.com>

1) ./lib/hash/rte_cuckoo_hash.c:2362:9
    : warning: ISO C90 forbids variable length array ‘positions’
2) ../lib/hash/rte_cuckoo_hash.c:2478:9
    : warning: ISO C90 forbids variable length array ‘positions’

Both rte_hash_lookup_bulk_data() and
rte_hash_lookup_with_hash_bulk_data() expect
@num_keys <= RTE_HASH_LOOKUP_BULK_MAX.
So, for both cases it should be safe to replace VLA with fixed size
array.

Signed-off-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
 lib/hash/rte_cuckoo_hash.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

fengchengwen Nov. 22, 2024, 1:35 a.m. UTC | #1

Acked-by: Chengwen Feng <fengchengwen@huawei.com>

On 2024/11/22 5:41, Andre Muezerie wrote:
> From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> 
> 1) ./lib/hash/rte_cuckoo_hash.c:2362:9
>     : warning: ISO C90 forbids variable length array ‘positions’
> 2) ../lib/hash/rte_cuckoo_hash.c:2478:9
>     : warning: ISO C90 forbids variable length array ‘positions’
> 
> Both rte_hash_lookup_bulk_data() and
> rte_hash_lookup_with_hash_bulk_data() expect
> @num_keys <= RTE_HASH_LOOKUP_BULK_MAX.
> So, for both cases it should be safe to replace VLA with fixed size
> array.
> 
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> ---
>  lib/hash/rte_cuckoo_hash.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
> index 9575e8aa0c..fc93182efe 100644
> --- a/lib/hash/rte_cuckoo_hash.c
> +++ b/lib/hash/rte_cuckoo_hash.c
> @@ -2418,7 +2418,7 @@ rte_hash_lookup_bulk_data(const struct rte_hash *h, const void **keys,
>  			(num_keys > RTE_HASH_LOOKUP_BULK_MAX) ||
>  			(hit_mask == NULL)), -EINVAL);
>  
> -	int32_t positions[num_keys];
> +	int32_t positions[RTE_HASH_LOOKUP_BULK_MAX];
>  
>  	__rte_hash_lookup_bulk(h, keys, num_keys, positions, hit_mask, data);
>  
> @@ -2534,7 +2534,7 @@ rte_hash_lookup_with_hash_bulk_data(const struct rte_hash *h,
>  			(num_keys > RTE_HASH_LOOKUP_BULK_MAX) ||
>  			(hit_mask == NULL)), -EINVAL);
>  
> -	int32_t positions[num_keys];
> +	int32_t positions[RTE_HASH_LOOKUP_BULK_MAX];
>  
>  	__rte_hash_lookup_with_hash_bulk(h, keys, sig, num_keys,
>  			positions, hit_mask, data);

diff mbox series

Patch

diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
index 9575e8aa0c..fc93182efe 100644
--- a/lib/hash/rte_cuckoo_hash.c
+++ b/lib/hash/rte_cuckoo_hash.c
@@ -2418,7 +2418,7 @@  rte_hash_lookup_bulk_data(const struct rte_hash *h, const void **keys,
 			(num_keys > RTE_HASH_LOOKUP_BULK_MAX) ||
 			(hit_mask == NULL)), -EINVAL);
 
-	int32_t positions[num_keys];
+	int32_t positions[RTE_HASH_LOOKUP_BULK_MAX];
 
 	__rte_hash_lookup_bulk(h, keys, num_keys, positions, hit_mask, data);
 
@@ -2534,7 +2534,7 @@  rte_hash_lookup_with_hash_bulk_data(const struct rte_hash *h,
 			(num_keys > RTE_HASH_LOOKUP_BULK_MAX) ||
 			(hit_mask == NULL)), -EINVAL);
 
-	int32_t positions[num_keys];
+	int32_t positions[RTE_HASH_LOOKUP_BULK_MAX];
 
 	__rte_hash_lookup_with_hash_bulk(h, keys, sig, num_keys,
 			positions, hit_mask, data);