diff mbox series

[v12,20/21] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd

Message ID 1732225298-10322-21-git-send-email-andremue@linux.microsoft.com (mailing list archive)
State Superseded
Delegated to: David Marchand
Headers
Series remove use of VLAs for Windows |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Andre Muezerie Nov. 21, 2024, 9:41 p.m. UTC 
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
 app/test-pmd/shared_rxq_fwd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

fengchengwen Nov. 22, 2024, 12:47 a.m. UTC | #1 
Acked-by: Chengwen Feng <fengchengwen@huawei.com>

On 2024/11/22 5:41, Andre Muezerie wrote:
> MSVC does not support VLAs, replace VLAs with standard C arrays
> or alloca(). alloca() is available for all toolchain/platform
> combinations officially supported by DPDK.
> 
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> ---
>  app/test-pmd/shared_rxq_fwd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/shared_rxq_fwd.c b/app/test-pmd/shared_rxq_fwd.c
> index 623d62da88..b85830b90e 100644
> --- a/app/test-pmd/shared_rxq_fwd.c
> +++ b/app/test-pmd/shared_rxq_fwd.c
> @@ -92,7 +92,7 @@ forward_shared_rxq(struct fwd_stream *fs, uint16_t nb_rx,
>  static bool
>  shared_rxq_fwd(struct fwd_stream *fs)
>  {
> -	struct rte_mbuf *pkts_burst[nb_pkt_per_burst];
> +	struct rte_mbuf *pkts_burst[MAX_PKT_BURST];
>  	uint16_t nb_rx;
>  
>  	nb_rx = common_fwd_stream_receive(fs, pkts_burst, nb_pkt_per_burst);
diff mbox series

Patch

diff --git a/app/test-pmd/shared_rxq_fwd.c b/app/test-pmd/shared_rxq_fwd.c
index 623d62da88..b85830b90e 100644
--- a/app/test-pmd/shared_rxq_fwd.c
+++ b/app/test-pmd/shared_rxq_fwd.c
@@ -92,7 +92,7 @@  forward_shared_rxq(struct fwd_stream *fs, uint16_t nb_rx,
 static bool
 shared_rxq_fwd(struct fwd_stream *fs)
 {
-	struct rte_mbuf *pkts_burst[nb_pkt_per_burst];
+	struct rte_mbuf *pkts_burst[MAX_PKT_BURST];
 	uint16_t nb_rx;
 
 	nb_rx = common_fwd_stream_receive(fs, pkts_burst, nb_pkt_per_burst);