From patchwork Mon Apr 15 20:04:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 139373 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A673643E7E; Mon, 15 Apr 2024 22:13:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1EC642E67; Mon, 15 Apr 2024 22:06:42 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 9FEA440EA5 for ; Mon, 15 Apr 2024 22:05:08 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 5AA2420FDABA; Mon, 15 Apr 2024 13:04:47 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5AA2420FDABA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1713211492; bh=ejHIoSudzFF0Ehx0XztziZhekqvm5AppSQlI3pLI8rE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QFN4Bu/pJhGV5ZbjidXSAKyrjcoWlh6wGYLLidU2AFXWEHM+wJuscBrXk4NbQASF7 kYAEYUODPi8emkCqFr5pn9UUvAEMu4wG3UCaReqU/Xm3+n4Ktbyx1Rk4eFgMUWWrrX DqWb5IIutpEeZfRnfmAH3K8GGo9NgrhtR1v5zoOg= From: Tyler Retzlaff To: dev@dpdk.org Cc: =?utf-8?q?Mattias_R=C3=B6nnblom?= , "Min Hu (Connor)" , =?utf-8?q?Morten_Br=C3=B8rup?= , Abdullah Sevincer , Ajit Khaparde , Akhil Goyal , Alok Prasad , Amit Bernstein , Anatoly Burakov , Andrew Boyer , Andrew Rybchenko , Ankur Dwivedi , Anoob Joseph , Ashish Gupta , Ashwin Sekhar T K , Bruce Richardson , Byron Marohn , Chaoyong He , Chas Williams , Chenbo Xia , Chengwen Feng , Conor Walsh , Cristian Dumitrescu , Dariusz Sosnowski , David Hunt , Devendra Singh Rawat , Ed Czeck , Evgeny Schemeilin , Fan Zhang , Gagandeep Singh , Guoyang Zhou , Harman Kalra , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Hyong Youb Kim , Jakub Grajciar , Jerin Jacob , Jian Wang , Jiawen Wu , Jie Hai , Jingjing Wu , John Daley , John Miller , Joyce Kong , Kai Ji , Kevin Laatz , Kiran Kumar K , Konstantin Ananyev , Lee Daly , Liang Ma , Liron Himi , Long Li , Maciej Czekaj , Matan Azrad , Matt Peters , Maxime Coquelin , Michael Shamis , Nagadheeraj Rottela , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pablo de Lara , Pavan Nikhilesh , Peter Mccarthy , Radu Nicolau , Rahul Lakkireddy , Rakesh Kudurumalla , Raveendra Padasalagi , Reshma Pattan , Ron Beider , Ruifeng Wang , Sachin Saxena , Selwin Sebastian , Shai Brandes , Shepard Siegel , Shijith Thotton , Sivaprasad Tummala , Somnath Kotur , Srikanth Yalavarthi , Stephen Hemminger , Steven Webster , Suanming Mou , Sunil Kumar Kori , Sunil Uttarwar , Sunila Sahu , Tejasree Kondoj , Viacheslav Ovsiienko , Vikas Gupta , Volodymyr Fialko , Wajeeh Atrash , Wisam Jaddo , Xiaoyun Wang , Yipeng Wang , Yisen Zhuang , Yuying Zhang , Zhangfei Gao , Zhirun Yan , Ziyang Xuan , Tyler Retzlaff Subject: [PATCH v2 64/83] compress/zlib: move alignment attribute on types Date: Mon, 15 Apr 2024 13:04:26 -0700 Message-Id: <1713211485-9021-65-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1713211485-9021-1-git-send-email-roretzla@linux.microsoft.com> References: <1710949096-5786-1-git-send-email-roretzla@linux.microsoft.com> <1713211485-9021-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Move location of __rte_aligned(a) to new conventional location. The new placement between {struct,union} and the tag allows the desired alignment to be imparted on the type regardless of the toolchain being used for both C and C++. Additionally, it avoids confusion by Doxygen when generating documentation. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- drivers/compress/zlib/zlib_pmd_private.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/compress/zlib/zlib_pmd_private.h b/drivers/compress/zlib/zlib_pmd_private.h index e36c5dc..46a33d4 100644 --- a/drivers/compress/zlib/zlib_pmd_private.h +++ b/drivers/compress/zlib/zlib_pmd_private.h @@ -30,7 +30,7 @@ struct zlib_private { struct rte_mempool *mp; }; -struct zlib_qp { +struct __rte_cache_aligned zlib_qp { struct rte_ring *processed_pkts; /**< Ring for placing process packets */ struct rte_compressdev_stats qp_stats; @@ -39,7 +39,7 @@ struct zlib_qp { /**< Queue Pair Identifier */ char name[RTE_COMPRESSDEV_NAME_MAX_LEN]; /**< Unique Queue Pair Name */ -} __rte_cache_aligned; +}; /* Algorithm handler function prototype */ typedef void (*comp_func_t)(struct rte_comp_op *op, z_stream *strm); @@ -47,19 +47,19 @@ struct zlib_qp { typedef int (*comp_free_t)(z_stream *strm); /** ZLIB Stream structure */ -struct zlib_stream { +struct __rte_cache_aligned zlib_stream { z_stream strm; /**< zlib stream structure */ comp_func_t comp; /**< Operation (compression/decompression) */ comp_free_t free; /**< Free Operation (compression/decompression) */ -} __rte_cache_aligned; +}; /** ZLIB private xform structure */ -struct zlib_priv_xform { +struct __rte_cache_aligned zlib_priv_xform { struct zlib_stream stream; -} __rte_cache_aligned; +}; int zlib_set_stream_parameters(const struct rte_comp_xform *xform,