[1/3] doc: announce cleanup of rte_{bsf, fls} inline functions type use
Checks
Commit Message
From: Tyler Retzlaff <roretzla@microsoft.com>
The cleanup resulted from request to review [1] the following
functions where there appeared to be inconsistency in return type
or parameter type selections for the following inline functions.
rte_bsf32()
rte_bsf32_safe()
rte_bsf64()
rte_bsf64_safe()
rte_fls_u32()
rte_fls_u64()
rte_log2_u32()
rte_log2_u64()
[1] http://mails.dpdk.org/archives/dev/2021-March/201590.html
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
doc/guides/rel_notes/deprecation.rst | 6 ++++++
1 file changed, 6 insertions(+)
Comments
08/08/2022 23:21, Tyler Retzlaff:
> From: Tyler Retzlaff <roretzla@microsoft.com>
>
> The cleanup resulted from request to review [1] the following
> functions where there appeared to be inconsistency in return type
> or parameter type selections for the following inline functions.
>
> rte_bsf32()
> rte_bsf32_safe()
> rte_bsf64()
> rte_bsf64_safe()
Why _safe functions are not changed?
> rte_fls_u32()
> rte_fls_u64()
> rte_log2_u32()
> rte_log2_u64()
>
> [1] http://mails.dpdk.org/archives/dev/2021-March/201590.html
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index e7583ca..58f4c24 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> +* eal: Fix inline function return and parameter types for rte_{bsf,fls}
> + inline functions to be consistent in DPDK 22.11.
> + Change ``rte_bsf64`` return type to ``uint32_t`` instead of ``int``.
> + Change ``rte_fls_u32`` return type to ``uint32_t`` instead of ``int``.
> + Change ``rte_fls_u64`` return type to ``uint32_t`` instead of ``int``.
It is too late for the announce,
but the release notes requires to be updated.
@@ -17,6 +17,12 @@ Deprecation Notices
* eal: The function ``rte_eal_remote_launch`` will return new error codes
after read or write error on the pipe, instead of calling ``rte_panic``.
+* eal: Fix inline function return and parameter types for rte_{bsf,fls}
+ inline functions to be consistent in DPDK 22.11.
+ Change ``rte_bsf64`` return type to ``uint32_t`` instead of ``int``.
+ Change ``rte_fls_u32`` return type to ``uint32_t`` instead of ``int``.
+ Change ``rte_fls_u64`` return type to ``uint32_t`` instead of ``int``.
+
* rte_atomicNN_xxx: These APIs do not take memory order parameter. This does
not allow for writing optimized code for all the CPU architectures supported
in DPDK. DPDK has adopted the atomic operations from