[v1] maintainers: add explicit maintainer for some bbdev PMDs

Message ID 1646333498-18883-2-git-send-email-nicolas.chautru@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [v1] maintainers: add explicit maintainer for some bbdev PMDs |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Chautru, Nicolas March 3, 2022, 6:51 p.m. UTC
  These were implicit from DPDK script but adding
separate reference to make it explicit

Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)
  

Comments

Bruce Richardson March 4, 2022, 8:57 a.m. UTC | #1
On Thu, Mar 03, 2022 at 10:51:38AM -0800, Nicolas Chautru wrote:
> These were implicit from DPDK script but adding
> separate reference to make it explicit
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
>  MAINTAINERS | 4 ++++
>  1 file changed, 4 insertions(+)
>
Thanks for this. It just means that someone looking for the driver name in
the MAINTAINERS file will get a hit, rather than having to know that it's
implicit in the top-level baseband directory.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
  
Thomas Monjalon March 8, 2022, 11:23 p.m. UTC | #2
03/03/2022 19:51, Nicolas Chautru:
> These were implicit from DPDK script but adding
> separate reference to make it explicit
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
>  MAINTAINERS | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7577834..004ec91 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -421,6 +421,10 @@ T: git://dpdk.org/next/dpdk-next-crypto
>  F: lib/bbdev/
>  F: doc/guides/prog_guide/bbdev.rst
>  F: drivers/baseband/

I think you can remove the above catch-all.

> +F: drivers/baseband/turbo_sw/
> +F: drivers/baseband/fpga_lte_fec/
> +F: drivers/baseband/fpga_5gnr_fec/
> +F: drivers/baseband/acc100/

I would prefer a separate section for Intel baseband drivers.

>  F: doc/guides/bbdevs/
>  F: app/test-bbdev/
>  F: doc/guides/tools/testbbdev.rst
  
David Marchand March 9, 2022, 8:44 a.m. UTC | #3
On Wed, Mar 9, 2022 at 12:23 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 03/03/2022 19:51, Nicolas Chautru:
> > These were implicit from DPDK script but adding
> > separate reference to make it explicit
> >
> > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> > ---
> >  MAINTAINERS | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 7577834..004ec91 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -421,6 +421,10 @@ T: git://dpdk.org/next/dpdk-next-crypto
> >  F: lib/bbdev/
> >  F: doc/guides/prog_guide/bbdev.rst
> >  F: drivers/baseband/
>
> I think you can remove the above catch-all.
>
> > +F: drivers/baseband/turbo_sw/
> > +F: drivers/baseband/fpga_lte_fec/
> > +F: drivers/baseband/fpga_5gnr_fec/
> > +F: drivers/baseband/acc100/
>
> I would prefer a separate section for Intel baseband drivers.

We now have a baseband drivers section with a NXP driver.
It is more clear to have Intel drivers in this section like we do for
other classes of devices: one section for API, one section for
drivers.

Btw, the baseband drivers section is missing a global T: entry too.
It means that updates on nxp (atm) and any (in the future) bbdev
driver ends up in the main repo scope instead of next-crypto.


>
> >  F: doc/guides/bbdevs/

This too is a catch all.
For the API section, I'd rather see:
-F: drivers/baseband/
-F: doc/guides/bbdevs/
+F: doc/guides/bbdevs/features/default.ini

> >  F: app/test-bbdev/
> >  F: doc/guides/tools/testbbdev.rst
  

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 7577834..004ec91 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -421,6 +421,10 @@  T: git://dpdk.org/next/dpdk-next-crypto
 F: lib/bbdev/
 F: doc/guides/prog_guide/bbdev.rst
 F: drivers/baseband/
+F: drivers/baseband/turbo_sw/
+F: drivers/baseband/fpga_lte_fec/
+F: drivers/baseband/fpga_5gnr_fec/
+F: drivers/baseband/acc100/
 F: doc/guides/bbdevs/
 F: app/test-bbdev/
 F: doc/guides/tools/testbbdev.rst