net/cxgbe: avoid sending link params change from VF
Checks
Commit Message
From: Nikhil Vasoya <nikhil.vasoya@chelsio.com>
VFs are not allowed to change physical link params when a port
module change is detected. The firmware already returns appropriate
permission error when VF tries to change physical link params. But,
make sure to avoid sending the command to firmware from VF in the
first place and prevent flooding firmware debug logs with permission
errors.
Fixes: a83041b1e998 ("net/cxgbe: rework and simplify link handling")
Cc: stable@dpdk.org
Signed-off-by: Nikhil Vasoya <nikhil.vasoya@chelsio.com>
Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
---
drivers/net/cxgbe/base/t4_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 9/27/2021 6:56 PM, Rahul Lakkireddy wrote:
> From: Nikhil Vasoya <nikhil.vasoya@chelsio.com>
>
> VFs are not allowed to change physical link params when a port
> module change is detected. The firmware already returns appropriate
> permission error when VF tries to change physical link params. But,
> make sure to avoid sending the command to firmware from VF in the
> first place and prevent flooding firmware debug logs with permission
> errors.
>
> Fixes: a83041b1e998 ("net/cxgbe: rework and simplify link handling")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nikhil Vasoya <nikhil.vasoya@chelsio.com>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Applied to dpdk-next-net/main, thanks.
@@ -4597,7 +4597,7 @@ static void t4_handle_get_port_info(struct port_info *pi, const __be64 *rpl)
t4_os_link_changed(adapter, pi->pidx);
}
- if (mod_changed) {
+ if (mod_changed != 0 && is_pf4(adapter) != 0) {
u32 mod_caps = lc->admin_caps;
int ret;