diff mbox series

[v3,1/3] examples/flow_classify: fix check of port and core

Message ID 1619657448-57567-2-git-send-email-humin29@huawei.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series fix check of port and core | expand

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Min Hu (Connor) April 29, 2021, 12:50 a.m. UTC
According to the comments and logging, the author just hope user to use
the core and device which are in the same numa node for optimal
performance. If not, A warning gives out.

For example in flow_classify:
./build/flow_classify -a 0000:7d:00.1  -l 93
Here:
0000:7d:00.1 is on numa node 0.
core 93  is on numa node 3.

The two are not in same numa node, but no warning gives out in old codes.

This patch can fix it.

Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application")
Cc: stable@dpdk.org

Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 examples/flow_classify/flow_classify.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bernard Iremonger April 29, 2021, 9:07 a.m. UTC | #1
> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Thursday, April 29, 2021 1:51 AM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>; thomas@monjalon.net
> Subject: [PATCH v3 1/3] examples/flow_classify: fix check of port and core
> 
> According to the comments and logging, the author just hope user to use the
> core and device which are in the same numa node for optimal performance.
> If not, A warning gives out.
> 
> For example in flow_classify:
> ./build/flow_classify -a 0000:7d:00.1  -l 93
> Here:
> 0000:7d:00.1 is on numa node 0.
> core 93  is on numa node 3.
> 
> The two are not in same numa node, but no warning gives out in old codes.
> 
> This patch can fix it.
> 
> Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>

Tested-by: Bernard Iremonger <bernard.iremonger@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Min Hu (Connor) April 29, 2021, 9:37 a.m. UTC | #2
Thanks Bernard .

Hi, Thomas, Ferruh, any other comments?

在 2021/4/29 17:07, Iremonger, Bernard 写道:
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Thursday, April 29, 2021 1:51 AM
>> To: dev@dpdk.org
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Iremonger, Bernard
>> <bernard.iremonger@intel.com>; thomas@monjalon.net
>> Subject: [PATCH v3 1/3] examples/flow_classify: fix check of port and core
>>
>> According to the comments and logging, the author just hope user to use the
>> core and device which are in the same numa node for optimal performance.
>> If not, A warning gives out.
>>
>> For example in flow_classify:
>> ./build/flow_classify -a 0000:7d:00.1  -l 93
>> Here:
>> 0000:7d:00.1 is on numa node 0.
>> core 93  is on numa node 3.
>>
>> The two are not in same numa node, but no warning gives out in old codes.
>>
>> This patch can fix it.
>>
>> Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> 
> Tested-by: Bernard Iremonger <bernard.iremonger@intel.com>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
> 
> .
>
Thomas Monjalon April 29, 2021, 11:44 a.m. UTC | #3
Hi,

29/04/2021 11:37, Min Hu (Connor):
> Thanks Bernard .
> 
> Hi, Thomas, Ferruh, any other comments?

No need to ask for more comments after each ack.
We are very busy and we'll come to this patch on time.
You are sending a lot of fixes. That's very good
but we need time to digest them :)
Thanks
Min Hu (Connor) April 29, 2021, 12:15 p.m. UTC | #4
在 2021/4/29 19:44, Thomas Monjalon 写道:
> Hi,
> 
> 29/04/2021 11:37, Min Hu (Connor):
>> Thanks Bernard .
>>
>> Hi, Thomas, Ferruh, any other comments?
> 
> No need to ask for more comments after each ack.
> We are very busy and we'll come to this patch on time.
> You are sending a lot of fixes. That's very good
> but we need time to digest them :)
> Thanks
> 
Hi, Thomas,
	Sorry for that. I will be waiting more patiently in future.
	Thanks.
> 
> .
>
diff mbox series

Patch

diff --git a/examples/flow_classify/flow_classify.c b/examples/flow_classify/flow_classify.c
index 335d7d2..277a2f5 100644
--- a/examples/flow_classify/flow_classify.c
+++ b/examples/flow_classify/flow_classify.c
@@ -284,7 +284,7 @@  lcore_main(struct flow_classifier *cls_app)
 	 * for best performance.
 	 */
 	RTE_ETH_FOREACH_DEV(port)
-		if (rte_eth_dev_socket_id(port) > 0 &&
+		if (rte_eth_dev_socket_id(port) >= 0 &&
 			rte_eth_dev_socket_id(port) != (int)rte_socket_id()) {
 			printf("\n\n");
 			printf("WARNING: port %u is on remote NUMA node\n",