diff mbox series

[v2] app/testpmd: fix Tx/Rx descriptor query error log

Message ID 1617000403-13647-1-git-send-email-humin29@huawei.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [v2] app/testpmd: fix Tx/Rx descriptor query error log |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/travis-robot success travis build: passed
ci/github-robot success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS

Commit Message

humin (Q) March 29, 2021, 6:46 a.m. UTC 
  From: Hongbo Zheng <zhenghongbo3@huawei.com>

This patch adds more err info for Tx/Rx descriptor query command.

Fixes: fae9aa717d6c ("app/testpmd: support checking descriptor status")
Cc: stable@dpdk.org

Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
v2:
* Fixed error log info and simply the commit info.
---
 app/test-pmd/cmdline.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Li, Xiaoyun March 29, 2021, 7:07 a.m. UTC | #1 
Hi

> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Monday, March 29, 2021 14:47
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
> Subject: [PATCH v2] app/testpmd: fix Tx/Rx descriptor query error log
> 
> From: Hongbo Zheng <zhenghongbo3@huawei.com>
> 
> This patch adds more err info for Tx/Rx descriptor query command.
> 
> Fixes: fae9aa717d6c ("app/testpmd: support checking descriptor status")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> v2:
> * Fixed error log info and simply the commit info.
> ---
>  app/test-pmd/cmdline.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> 14110eb..f44116b 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -16629,7 +16629,8 @@ cmd_show_rx_tx_desc_status_parsed(void
> *parsed_result,
>  		rc = rte_eth_rx_descriptor_status(res->cmd_pid, res-
> >cmd_qid,
>  					     res->cmd_did);
>  		if (rc < 0) {
> -			printf("Invalid queueid = %d\n", res->cmd_qid);
> +			printf("Invalid input: queue id = %d, desc id = %d\n",
> +			       res->cmd_qid, res->cmd_did);
>  			return;
>  		}
>  		if (rc == RTE_ETH_RX_DESC_AVAIL)
> @@ -16642,7 +16643,8 @@ cmd_show_rx_tx_desc_status_parsed(void
> *parsed_result,
>  		rc = rte_eth_tx_descriptor_status(res->cmd_pid, res-
> >cmd_qid,
>  					     res->cmd_did);
>  		if (rc < 0) {
> -			printf("Invalid queueid = %d\n", res->cmd_qid);
> +			printf("Invalid input: queue id = %d, desc id = %d\n",
> +			       res->cmd_qid, res->cmd_did);
>  			return;
>  		}
>  		if (rc == RTE_ETH_TX_DESC_FULL)
> --
> 2.7.4

Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
Ferruh Yigit March 30, 2021, 2:29 p.m. UTC | #2 
On 3/29/2021 7:46 AM, Min Hu (Connor) wrote:
> From: Hongbo Zheng <zhenghongbo3@huawei.com>
> 
> This patch adds more err info for Tx/Rx descriptor query command.
> 
> Fixes: fae9aa717d6c ("app/testpmd: support checking descriptor status")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>

Off the topic.

This is the patch 90000 in patchwork!
Thanks to everyone who contributed!

https://patches.dpdk.org/api/1.2/patches/90000/

The historical numbers from DPDK patchwork:
90000 - March 29, 2021 (172 days) [ 5 months and 21 days / 24 weeks and 4 days ]
80000 - Oct.   8, 2020 (153 days)
70000 - May    8, 2020 (224 days)
60000 - Sept. 27, 2019 (248 days)
50000 - Jan.  22, 2019 (253 days)
40000 - May   14, 2018 (217 days)
30000 - Oct.   9, 2017 (258 days)
20000 - Jan.  25, 2017 (372 days)
10000 - Jan.  20, 2016 (645 days)
00001 - April 16, 2014


Another 10K of patches faster than rough average ~250 days, assuming v20.11 LTS 
workload contributed to this stat but not investigated deeply.

Thanks again to all contributors.
Ferruh Yigit March 30, 2021, 2:35 p.m. UTC | #3 
On 3/29/2021 8:07 AM, Li, Xiaoyun wrote:
> Hi
> 
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Monday, March 29, 2021 14:47
>> To: dev@dpdk.org
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
>> Subject: [PATCH v2] app/testpmd: fix Tx/Rx descriptor query error log
>>
>> From: Hongbo Zheng <zhenghongbo3@huawei.com>
>>
>> This patch adds more err info for Tx/Rx descriptor query command.
>>
>> Fixes: fae9aa717d6c ("app/testpmd: support checking descriptor status")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com> >
> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
> 

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 14110eb..f44116b 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -16629,7 +16629,8 @@  cmd_show_rx_tx_desc_status_parsed(void *parsed_result,
 		rc = rte_eth_rx_descriptor_status(res->cmd_pid, res->cmd_qid,
 					     res->cmd_did);
 		if (rc < 0) {
-			printf("Invalid queueid = %d\n", res->cmd_qid);
+			printf("Invalid input: queue id = %d, desc id = %d\n",
+			       res->cmd_qid, res->cmd_did);
 			return;
 		}
 		if (rc == RTE_ETH_RX_DESC_AVAIL)
@@ -16642,7 +16643,8 @@  cmd_show_rx_tx_desc_status_parsed(void *parsed_result,
 		rc = rte_eth_tx_descriptor_status(res->cmd_pid, res->cmd_qid,
 					     res->cmd_did);
 		if (rc < 0) {
-			printf("Invalid queueid = %d\n", res->cmd_qid);
+			printf("Invalid input: queue id = %d, desc id = %d\n",
+			       res->cmd_qid, res->cmd_did);
 			return;
 		}
 		if (rc == RTE_ETH_TX_DESC_FULL)