Message ID | 1602182927-18254-4-git-send-email-hkalra@marvell.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Jerin Jacob |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28DC8A04BC; Thu, 8 Oct 2020 20:50:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C50D71B9CE; Thu, 8 Oct 2020 20:49:32 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 60E891B9CE for <dev@dpdk.org>; Thu, 8 Oct 2020 20:49:31 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 098IULRn004200 for <dev@dpdk.org>; Thu, 8 Oct 2020 11:49:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : mime-version; s=pfpt0220; bh=zqwg3rp2XgRxgaLM7dVhhflEDvBRvZXw0yGrV9tkoUA=; b=DfoPBW0mOkGvqfGO7R2qPq5cYQRxGSaENn6iXFj0utifrvlb03R7NNABf1WMOm4Ma23Q 1yGve9uWL7j0SPRFc9VMLHWpJ7XOc7OEKFNHJLjF/sTrKQjVYQ4c/3v6kq7t/Wq5aKy6 QAfKu1c69bjzsEBmV70VODO3H/TQaULACrKvIyImDrKSTjxirf6VwQs3mng1GkFZjNoG CENrzxKtOaIg/iu3QrcyD0ghUxFzxmyuVwGbg8NO8wV9YO41Ej4Xjetpo5sNgZM6YHAc QRF4RHdsuS8CiDXtL8ezI1bChvIIe1et0qCkJ4FwBeaYZcey1qjkms5t0DrpBUzWog1m CQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 33xpnq23u4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for <dev@dpdk.org>; Thu, 08 Oct 2020 11:49:29 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 8 Oct 2020 11:49:28 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.56) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 8 Oct 2020 11:49:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y2dQrYBP4ncDrxZTJjL+V/0WeVcPl36HPiPT7hY1lxODHhrM3k8Vt3tKDo6oVdyqiuxzyqp2EnOpqjt5I+JS8ogQdtL+CDpudX/yDHXezdCOcFxXAQpb/CBqqwxp16zGVvs7d4vRq8ByCFADj9PXoviTbnMmuHmnQ/H27evNAr7+fGfQjVxcWvEYHX/RT0k92rg+OoA6kBuHZ7TYxcvVV4ziJZVaEqoszkxlVWFHxPOZ4EbEXLBt5aJ3LKGAbeY+duiaWKCkGksFb3M3JsWUJoXfwQZp9tbRTtTkml++lddNgCuCTK1mbGkKhHMagAR/t7RdnJOTMbzQZ7XrVvQaow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zqwg3rp2XgRxgaLM7dVhhflEDvBRvZXw0yGrV9tkoUA=; b=e1RQHjFjqq3X7hD5PqSsGkqZR0XskOj0nbplkc/iqAa8goonSS+Idmfd9pVfVcv4O/MhTLwQ41qz83eppp0mZ/dJRpmul/9l1CnprPRLq0rdeXsjX8TTZ14gk67gjBrRLNzbo8UZfW8dc5XOH50mV34LJ+ox/vzkiUADhDi+iAa1HE2WMj9x1qDCxmbFcrCcP1RyW2x1sOCIQZga123lfAHPX9dp+w/3HFwn4EKuxGH53AIYBc3Y/UJXEwpu8+2TbOheDKbKon+iqAoCqdntoQJVZKhljP5EMCLoK4N5wGrf2+Pqfo55QXDs8QtDUgIcBVEXRh7jgVQqA2Yc/qSKCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zqwg3rp2XgRxgaLM7dVhhflEDvBRvZXw0yGrV9tkoUA=; b=pGvt1fXDE9bXcxCI+tFC4oewkze5x9DX3Ij+NjTr+rzKSvgB7wxuWRIct6Ywmdrd1VzvUicUZL5KT8LCGIPw8+CMAiM+o2Eo8g8PEfQgGJsS+H7NyflNWyRIX2rtSZ7WNwkQ+Kz6Fsdh6N6oM4nYw2qamRlYLk2uDEGN7j4x+gQ= Received: from CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) by MW2PR18MB2169.namprd18.prod.outlook.com (2603:10b6:907:5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.32; Thu, 8 Oct 2020 18:49:27 +0000 Received: from CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::b960:6770:a1:2a19]) by CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::b960:6770:a1:2a19%7]) with mapi id 15.20.3455.023; Thu, 8 Oct 2020 18:49:27 +0000 From: Harman Kalra <hkalra@marvell.com> To: Jerin Jacob <jerinj@marvell.com> CC: <dev@dpdk.org>, Harman Kalra <hkalra@marvell.com> Date: Fri, 9 Oct 2020 00:18:46 +0530 Message-ID: <1602182927-18254-4-git-send-email-hkalra@marvell.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1602182927-18254-1-git-send-email-hkalra@marvell.com> References: <CALBAE1OcrUKLzqS5T8Jd27w_rdFRXtmLacprrpYte_hN_iGxCQ@mail.gmail.com> <1602182927-18254-1-git-send-email-hkalra@marvell.com> Content-Type: text/plain X-Originating-IP: [1.6.215.26] X-ClientProxiedBy: BMXPR01CA0093.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:54::33) To CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from hkarlara-OptiPlex-3046.marvell.com (1.6.215.26) by BMXPR01CA0093.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:54::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3455.21 via Frontend Transport; Thu, 8 Oct 2020 18:49:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d4eb0f0c-6330-45c6-f369-08d86bbae194 X-MS-TrafficTypeDiagnostic: MW2PR18MB2169: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: <MW2PR18MB2169ED3BA008A0F8C3229DD0C50B0@MW2PR18MB2169.namprd18.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Uh6L2NMBYrpfOI1N7++v43C6YstbLW1EXmZRRUfwpDu4BwNS4iRD9bMZuXr0y28wqp+YRZEXQdMszT7Y5VMZBzHqgbkCZeA5IyYpvYc9eQCFprzjGPAVHCMUXBtpicfNFicFDw8nHW6zv2eS8qSomkhbJF6NkWjFbSigBckenwyK9hy4JZ2dCGN5TUBMMgy+1+mrOD54DhfSpsdHpPYSQJEc77rfjbiSQ7yS5+Knhk2e8WB9r3VOsmbTAYLlwJQVGIsszFkCtVficZPnladWCAy+ru9/yEy0UxcDEvfPTXa6OiwgkDhFuc4e1pY++JoEAeNokwyzzUmHusBK8O+bkq3nfMi1et8mB0SAcNabnqqkUGNonr/+JrQnXYguOfG1cn6jG6B/DZP5qbj74A14qg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3842.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(346002)(376002)(396003)(4744005)(956004)(6636002)(8936002)(86362001)(6486002)(6862004)(107886003)(2616005)(478600001)(8676002)(4326008)(7696005)(2906002)(316002)(37006003)(6666004)(52116002)(1006002)(66946007)(26005)(186003)(36756003)(66476007)(66556008)(16526019)(5660300002)(36456003)(42976004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: ar4LQDwHkxzlxja0wGKTK47aUgr0Vva38lpFEOxmfOLHdKy2Lt/eYUGVu4jSj2/wYxffYjk4d3FY6mot1CpaOT+FKSihvTSVTaZjP+8+88uxLAIh411tQ+fVGlL/JEqtiDxjJctA5rsBQvGaDf3T497GJxaREfiCHHpu+dtlk+Ih7qInZyUj/6ktM5skMpSbg4PAao0BN7OjpLAXCvwV3ZehexToriWBqVEXobZ+Gb7G8lPkCz/IlMSYSgrIm4N3PG3h+3PMTVVkr9KuHvOLhZj/FZv7GbQK7wO/LrHqAD+WOPlcLK/zN7ykd76lBuB9ICjfS491nH53QzMX4nrQ5CrsPIz+UysqmZJt2TJ4yMkRDyabAAAQxfrzSrwnNEk+Jy6FLUHa2t4oifLgAxXJZ1cQKM98rNlTov+ZSMgN6a+FAS2sc3Gjxyk7VdAhpSN/4DQDU0VNGODvAJXIMPWFBHa3oDyplUCQbqfpCZ7kdrNTE4p93UFHHbJgc6MLPndX2EDafnSmKyh+5+8ABEYzdd+BBV3or5vozranqjbNiOLqomqlVN4klU1N9ztQD1ELHMBbg0wf1TSBA50DYohncKUGYNsf/lV/k7wyDDe7+wRS8LuPBrnhnzl3P/zCFQTRB27bSY1USPtyIiC0cFHW6Q== X-MS-Exchange-CrossTenant-Network-Message-Id: d4eb0f0c-6330-45c6-f369-08d86bbae194 X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3842.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2020 18:49:26.9662 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vXH5Cmjd1J6wrOA8Gc8VGh1Es6S2OlAvevJukcDr0ZLN88sJfWfY9qQWMPnaLS/gvdCZDJ26frHXYLvgFtgCSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR18MB2169 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-08_12:2020-10-08, 2020-10-08 signatures=0 Subject: [dpdk-dev] [PATCH v2 4/4] app/eventdev: enable fast free offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
[v2,1/4] event/octeontx2: add switch tag flush op
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/iol-broadcom-Performance | success | Performance Testing PASS |
ci/iol-broadcom-Functional | success | Functional Testing PASS |
ci/iol-testing | success | Testing PASS |
ci/iol-intel-Performance | success | Performance Testing PASS |
ci/travis-robot | success | Travis build: passed |
ci/iol-mellanox-Performance | success | Performance Testing PASS |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Harman Kalra
Oct. 8, 2020, 6:48 p.m. UTC
Since we are not holding the mbufs or creating any references
in the app, hence mbuf fast free offload can be enabled.
Signed-off-by: Harman Kalra <hkalra@marvell.com>
---
app/test-eventdev/test_pipeline_common.c | 5 +++++
1 file changed, 5 insertions(+)
Comments
On Fri, Oct 9, 2020 at 12:20 AM Harman Kalra <hkalra@marvell.com> wrote: > > Since we are not holding the mbufs or creating any references > in the app, hence mbuf fast free offload can be enabled. > > Signed-off-by: Harman Kalra <hkalra@marvell.com> > --- > app/test-eventdev/test_pipeline_common.c | 5 +++++ ++ eventdev maintainers Since testeventdev is not creating more than one pool and not using any mbuf reference feature. This change looks to me. Let me know if you have any different opinion if nay. Acked-by: Jerin Jacob <jerinj@marvell.com> > 1 file changed, 5 insertions(+) > > diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c > index 17088b1b4..f0c0ffea7 100644 > --- a/app/test-eventdev/test_pipeline_common.c > +++ b/app/test-eventdev/test_pipeline_common.c > @@ -219,6 +219,11 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt) > return ret; > } > > + /* Enable mbuf fast free if PMD has the capability. */ > + if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) > + local_port_conf.txmode.offloads |= > + DEV_TX_OFFLOAD_MBUF_FAST_FREE; > + > rx_conf = dev_info.default_rxconf; > rx_conf.offloads = port_conf.rxmode.offloads; > > -- > 2.18.0 >
On Sun, Oct 11, 2020 at 4:03 PM Jerin Jacob <jerinjacobk@gmail.com> wrote: > > On Fri, Oct 9, 2020 at 12:20 AM Harman Kalra <hkalra@marvell.com> wrote: > > > > Since we are not holding the mbufs or creating any references > > in the app, hence mbuf fast free offload can be enabled. > > > > Signed-off-by: Harman Kalra <hkalra@marvell.com> > > --- > > app/test-eventdev/test_pipeline_common.c | 5 +++++ > > ++ eventdev maintainers > > Since testeventdev is not creating more than one pool and not using > any mbuf reference feature. > This change looks to me. Let me know if you have any different opinion if nay. > > Acked-by: Jerin Jacob <jerinj@marvell.com> Applied to dpdk-next-eventdev/for-main. Thanks. > > > > 1 file changed, 5 insertions(+) > > > > diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c > > index 17088b1b4..f0c0ffea7 100644 > > --- a/app/test-eventdev/test_pipeline_common.c > > +++ b/app/test-eventdev/test_pipeline_common.c > > @@ -219,6 +219,11 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt) > > return ret; > > } > > > > + /* Enable mbuf fast free if PMD has the capability. */ > > + if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) > > + local_port_conf.txmode.offloads |= > > + DEV_TX_OFFLOAD_MBUF_FAST_FREE; > > + > > rx_conf = dev_info.default_rxconf; > > rx_conf.offloads = port_conf.rxmode.offloads; > > > > -- > > 2.18.0 > >
diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c index 17088b1b4..f0c0ffea7 100644 --- a/app/test-eventdev/test_pipeline_common.c +++ b/app/test-eventdev/test_pipeline_common.c @@ -219,6 +219,11 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt) return ret; } + /* Enable mbuf fast free if PMD has the capability. */ + if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) + local_port_conf.txmode.offloads |= + DEV_TX_OFFLOAD_MBUF_FAST_FREE; + rx_conf = dev_info.default_rxconf; rx_conf.offloads = port_conf.rxmode.offloads;