diff mbox series

[24/25] net/mlx5: make VLAN network interface thread safe

Message ID	1601984948-313027-25-git-send-email-suanmingm@nvidia.com (mailing list archive)
State	Superseded, archived
Delegated to:	Raslan Darawsheh
Headers	From: Suanming Mou <suanmingm@nvidia.com> To: viacheslavo@nvidia.com, matan@nvidia.com Cc: rasland@nvidia.com, dev@dpdk.org Date: Tue, 6 Oct 2020 19:49:07 +0800 Message-Id: <1601984948-313027-25-git-send-email-suanmingm@nvidia.com> In-Reply-To: <1601984948-313027-1-git-send-email-suanmingm@nvidia.com> References: <1601984948-313027-1-git-send-email-suanmingm@nvidia.com> Subject: [dpdk-dev] [PATCH 24/25] net/mlx5: make VLAN network interface thread safe Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	net/mlx5: support multiple-thread flow operations \| [00/25] net/mlx5: support multiple-thread flow operations [01/25] net/mlx5: use thread safe index pool for flow objects [02/25] net/mlx5: use thread specific flow context [03/25] net/mlx5: reuse flow Id as hairpin Id [04/25] net/mlx5: indexed pool supports zero size entry [05/25] net/mlx5: use indexed pool for RSS flow ID [06/25] net/mlx5: make rte flow list thread safe [07/25] net/mlx5: support concurrent access for hash list [08/25] net/mlx5: make flow table cache thread safe [09/25] net/mlx5: fix redundant Direct Verbs resources allocate [10/25] net/mlx5: make flow tag list thread safe [11/25] net/mlx5: make flow modify action list thread safe [12/25] net/mlx5: make metadata copy flow list thread safe [13/25] net/mlx5: make header reformat action thread safe [14/25] net/mlx5: remove unused hash list operations [15/25] net/mlx5: introduce thread safe linked list cache [16/25] net/mlx5: make Rx queue thread safe [17/25] net/mlx5: make matcher list thread safe [18/25] net/mlx5: make port ID action cache thread safe [19/25] net/mlx5: make push VLAN action cache thread safe [20/25] net/mlx5: create global jump action [21/25] net/mlx5: create global default miss action [22/25] net/mlx5: create global drop action [23/25] net/mlx5: make meter action thread safe [24/25] net/mlx5: make VLAN network interface thread safe [25/25] net/mlx5: remove shared context lock

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Suanming Mou Oct. 6, 2020, 11:49 a.m. UTC

  This commit takes advantage of the atomic operation with the VLAN VM
workaround object reference count to make sure the object to be thread
safe and not to be created or destroyed in parallel.

Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
---
 drivers/net/mlx5/linux/mlx5_vlan_os.c | 24 +++++++++++++++---------
 1 file changed, 15 insertions(+), 9 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/mlx5/linux/mlx5_vlan_os.c b/drivers/net/mlx5/linux/mlx5_vlan_os.c
index 92fc17d..00e160f 100644
--- a/drivers/net/mlx5/linux/mlx5_vlan_os.c
+++ b/drivers/net/mlx5/linux/mlx5_vlan_os.c
@@ -45,10 +45,11 @@ 
 		return;
 	vlan->created = 0;
 	MLX5_ASSERT(vlan_dev[vlan->tag].refcnt);
-	if (--vlan_dev[vlan->tag].refcnt == 0 &&
-	    vlan_dev[vlan->tag].ifindex) {
+	if (!__atomic_sub_fetch(&vlan_dev[vlan->tag].refcnt,
+	    1, __ATOMIC_RELAXED)) {
 		mlx5_nl_vlan_vmwa_delete(vmwa, vlan_dev[vlan->tag].ifindex);
-		vlan_dev[vlan->tag].ifindex = 0;
+		__atomic_store_n(&vlan_dev[vlan->tag].ifindex,
+				 0, __ATOMIC_RELAXED);
 	}
 }
 
@@ -72,16 +73,21 @@ 
 	MLX5_ASSERT(priv->vmwa_context);
 	if (vlan->created || !vmwa)
 		return;
-	if (vlan_dev[vlan->tag].refcnt == 0) {
-		MLX5_ASSERT(!vlan_dev[vlan->tag].ifindex);
+	if (__atomic_add_fetch
+	    (&vlan_dev[vlan->tag].refcnt, 1, __ATOMIC_RELAXED) == 1) {
+		/* Make sure ifindex is destroyed. */
+		rte_wait_until_equal_32(&vlan_dev[vlan->tag].ifindex,
+					0, __ATOMIC_RELAXED);
 		vlan_dev[vlan->tag].ifindex =
 			mlx5_nl_vlan_vmwa_create(vmwa, vmwa->vf_ifindex,
 						 vlan->tag);
+		if (!vlan_dev[vlan->tag].ifindex) {
+			__atomic_store_n(&vlan_dev[vlan->tag].refcnt,
+					 0, __ATOMIC_RELAXED);
+			return;
+		}
 	}
-	if (vlan_dev[vlan->tag].ifindex) {
-		vlan_dev[vlan->tag].refcnt++;
-		vlan->created = 1;
-	}
+	vlan->created = 1;
 }
 
 /*