From patchwork Wed Sep 23 09:40:11 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Patchwork-Submitter: Phil Yang <phil.yang@arm.com>
X-Patchwork-Id: 78514
X-Patchwork-Delegate: david.marchand@redhat.com
Return-Path: <dev-bounces@dpdk.org>
X-Original-To: patchwork@inbox.dpdk.org
Delivered-To: patchwork@inbox.dpdk.org
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EEDA9A04B1;
	Wed, 23 Sep 2020 11:40:48 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id D34821DAD5;
	Wed, 23 Sep 2020 11:40:48 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by dpdk.org (Postfix) with ESMTP id 4E8131D380;
 Wed, 23 Sep 2020 11:40:47 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C3A34D6E;
 Wed, 23 Sep 2020 02:40:46 -0700 (PDT)
Received: from phil-VirtualBox.shanghai.arm.com (A010647.Arm.com
 [10.169.182.48])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 10CF43F718;
 Wed, 23 Sep 2020 02:40:43 -0700 (PDT)
From: Phil Yang <phil.yang@arm.com>
To: dev@dpdk.org,
	david.marchand@redhat.com
Cc: juraj.linkes@pantheon.tech, Ruifeng.Wang@arm.com, nd@arm.com,
 stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 Luca Boccassi <bluca@debian.org>
Date: Wed, 23 Sep 2020 17:40:11 +0800
Message-Id: <1600854012-10226-1-git-send-email-phil.yang@arm.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1594277585-15281-1-git-send-email-phil.yang@arm.com>
References: <1594277585-15281-1-git-send-email-phil.yang@arm.com>
Subject: [dpdk-dev] [PATCH v2 1/2] devtools: fix ninja install breakage
	under relative path
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

As the DESTDIR variable use as ninja's destination directory when invoking
ninja install. If the DESTDIR is not an absolute path, ninja complains.

Fixes: 777014e56d07 ("devtools: add ABI checks")
Cc: stable@dpdk.org

Signed-off-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
v2:
Use readlink to ensure consistent coding style. (Juraj)

v1:
Initial version.

 devtools/test-meson-builds.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
index a87de63..5236b9c 100755
--- a/devtools/test-meson-builds.sh
+++ b/devtools/test-meson-builds.sh
@@ -143,7 +143,8 @@ build () # <directory> <target compiler | cross file> <meson options>
 	config $srcdir $builds_dir/$targetdir $cross --werror $*
 	compile $builds_dir/$targetdir
 	if [ -n "$DPDK_ABI_REF_VERSION" ]; then
-		abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION
+		abirefdir=$(readlink -f \
+			${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION)
 		if [ ! -d $abirefdir/$targetdir ]; then
 			# clone current sources
 			if [ ! -d $abirefdir/src ]; then