[05/22] doc: remove embedded buffer from Windows UIO ioctl

Message ID	1597360905-74106-6-git-send-email-navasile@linux.microsoft.com (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	show Return-Path: <dev-bounces@dpdk.org> From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com> To: dev@dpdk.org, thomas@monjalon.net, haramakr@linux.microsoft.com, ocardona@microsoft.com, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com Cc: ranjit.menon@intel.com, dmitrym@microsoft.com, Harini Ramakrishnan <haramakr@microsoft.com> Date: Thu, 13 Aug 2020 16:21:28 -0700 Message-Id: <1597360905-74106-6-git-send-email-navasile@linux.microsoft.com> In-Reply-To: <1597360905-74106-1-git-send-email-navasile@linux.microsoft.com> References: <1597360905-74106-1-git-send-email-navasile@linux.microsoft.com> Subject: [dpdk-dev] [PATCH 05/22] doc: remove embedded buffer from Windows UIO ioctl Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	windows/netuio: add netuio driver for Windows \| expand [00/22] windows/netuio: add netuio driver for Windows [01/22] init DPDK repository [02/22] Initial commit of UIO driver for Windows [03/22] Added new core libraries for Windows [04/22] Windows DPDK libraries and applications have now been updated to the latest public release … [05/22] doc: remove embedded buffer from Windows UIO ioctl [06/22] Windows DPDK libraries and applications have now been updated to the latest public release … [07/22] doc: change the Windows UIO driver's default security descriptor to admin only [08/22] doc: remove lower bound on mapped address from Windows UIO driver [09/22] doc: remove embedded buffer from Windows UIO ioctl [10/22] uio: move SDDL string to INF on Windows [11/22] Updated Source and Project files to use Clang toolset [12/22] uio: Fix 64 bit BARs mapping [13/22] Update .gitignore and create .gitattributes [14/22] uio: Use local time when verifying INF DriverVer [15/22] uio: Remove co-installers section from inf [16/22] uio: Wrap call into try/except block [17/22] uio: Use request handler that guarantees execution in correct context [18/22] uio: Change the device setup class to a custom one [19/22] Enable DMA remapping through INF directive [20/22] license: update headers with BSD 3-clause license: [21/22] doc: updating REAME for NetUIO driver [22/22] Move all files under windows folder

Message ID

1597360905-74106-6-git-send-email-navasile@linux.microsoft.com (mailing list archive)

State

Superseded, archived

Delegated to:

Thomas Monjalon

Headers

From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: dev@dpdk.org, thomas@monjalon.net, haramakr@linux.microsoft.com,
 ocardona@microsoft.com, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com
Cc: ranjit.menon@intel.com, dmitrym@microsoft.com,
 Harini Ramakrishnan <haramakr@microsoft.com>
Date: Thu, 13 Aug 2020 16:21:28 -0700
Message-Id: <1597360905-74106-6-git-send-email-navasile@linux.microsoft.com>
In-Reply-To: <1597360905-74106-1-git-send-email-navasile@linux.microsoft.com>
References: <1597360905-74106-1-git-send-email-navasile@linux.microsoft.com>
Subject: [dpdk-dev] [PATCH 05/22] doc: remove embedded buffer from Windows
	UIO ioctl
Precedence: list
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Series

windows/netuio: add netuio driver for Windows | expand

Context	Check	Description
ci/checkpatch	warning	coding style issues

Context

Check

Description

ci/checkpatch

warning

coding style issues

Comments

Dmitry Kozlyuk Aug. 14, 2020, 8:02 p.m. UTC | #1

On Thu, 13 Aug 2020 16:21:28 -0700, Narcisa Ana Maria Vasile wrote:
> From: Harini Ramakrishnan <haramakr@microsoft.com>
> 
> ---
>  mk/exec-env/windows/netuio/netuio.vcxproj | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/mk/exec-env/windows/netuio/netuio.vcxproj b/mk/exec-env/windows/netuio/netuio.vcxproj
> index b6564e4e7..b6b11e49a 100644
> --- a/mk/exec-env/windows/netuio/netuio.vcxproj
> +++ b/mk/exec-env/windows/netuio/netuio.vcxproj
> @@ -68,6 +68,9 @@
>      <Inf>
>        <TimeStamp>0.6.0.5</TimeStamp>
>      </Inf>
> +    <Link>
> +      <AdditionalDependencies>%(AdditionalDependencies);$(KernelBufferOverflowLib);$(DDK_LIB_PATH)ntoskrnl.lib;$(DDK_LIB_PATH)hal.lib;$(DDK_LIB_PATH)wmilib.lib;$(KMDF_LIB_PATH)$(KMDF_VER_PATH)\WdfLdr.lib;$(KMDF_LIB_PATH)$(KMDF_VER_PATH)\WdfDriverEntry.lib;$(DDK_LIB_PATH)\wdmsec.lib</AdditionalDependencies>
> +    </Link>
>    </ItemDefinitionGroup>
>    <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
>      <ClCompile>
> @@ -80,6 +83,9 @@
>      <Inf>
>        <TimeStamp>0.6.0.5</TimeStamp>
>      </Inf>
> +    <Link>
> +      <AdditionalDependencies>%(AdditionalDependencies);$(KernelBufferOverflowLib);$(DDK_LIB_PATH)ntoskrnl.lib;$(DDK_LIB_PATH)hal.lib;$(DDK_LIB_PATH)wmilib.lib;$(KMDF_LIB_PATH)$(KMDF_VER_PATH)\WdfLdr.lib;$(KMDF_LIB_PATH)$(KMDF_VER_PATH)\WdfDriverEntry.lib;$(DDK_LIB_PATH)\wdmsec.lib</AdditionalDependencies>
> +    </Link>
>    </ItemDefinitionGroup>
>    <ItemGroup>
>      <FilesToPackage Include="$(TargetPath)" />

Commit subject doesn't match content. It this commit needed as standalone?

diff --git a/mk/exec-env/windows/netuio/netuio.vcxproj b/mk/exec-env/windows/netuio/netuio.vcxproj
index b6564e4e7..b6b11e49a 100644
--- a/mk/exec-env/windows/netuio/netuio.vcxproj
+++ b/mk/exec-env/windows/netuio/netuio.vcxproj
@@ -68,6 +68,9 @@ 
     <Inf>
       <TimeStamp>0.6.0.5</TimeStamp>
     </Inf>
+    <Link>
+      <AdditionalDependencies>%(AdditionalDependencies);$(KernelBufferOverflowLib);$(DDK_LIB_PATH)ntoskrnl.lib;$(DDK_LIB_PATH)hal.lib;$(DDK_LIB_PATH)wmilib.lib;$(KMDF_LIB_PATH)$(KMDF_VER_PATH)\WdfLdr.lib;$(KMDF_LIB_PATH)$(KMDF_VER_PATH)\WdfDriverEntry.lib;$(DDK_LIB_PATH)\wdmsec.lib</AdditionalDependencies>
+    </Link>
   </ItemDefinitionGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
     <ClCompile>
@@ -80,6 +83,9 @@ 
     <Inf>
       <TimeStamp>0.6.0.5</TimeStamp>
     </Inf>
+    <Link>
+      <AdditionalDependencies>%(AdditionalDependencies);$(KernelBufferOverflowLib);$(DDK_LIB_PATH)ntoskrnl.lib;$(DDK_LIB_PATH)hal.lib;$(DDK_LIB_PATH)wmilib.lib;$(KMDF_LIB_PATH)$(KMDF_VER_PATH)\WdfLdr.lib;$(KMDF_LIB_PATH)$(KMDF_VER_PATH)\WdfDriverEntry.lib;$(DDK_LIB_PATH)\wdmsec.lib</AdditionalDependencies>
+    </Link>
   </ItemDefinitionGroup>
   <ItemGroup>
     <FilesToPackage Include="$(TargetPath)" />

[05/22] doc: remove embedded buffer from Windows UIO ioctl

Checks

Commit Message

Comments

Patch