From patchwork Tue Feb 18 11:52:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiri Kuzin X-Patchwork-Id: 65865 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7DC2A054F; Tue, 18 Feb 2020 12:55:00 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 80D9B1D513; Tue, 18 Feb 2020 12:54:59 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140074.outbound.protection.outlook.com [40.107.14.74]) by dpdk.org (Postfix) with ESMTP id 245641D508; Tue, 18 Feb 2020 12:54:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=igrK/5KLilCWGQhS6fZLWq2VyKg/+fIMLVuMRSNmpXXuqX3EeZqJDtiJszOPOBznPg3XFeDJSaNQfbkVUQF3prHOvAGE66k7SNS+qoFQ2ppKv0YkrAqE5O5RS5pa5LKLR8BHumqOQruEdKskbVPRppjNUNwo4Q3K5xGiwBB29qUcaM9CVhw/1UhVeeAECI31wlUBwu67YaT9JTmXdUnTymYTzxKvyxYR+g/XokIXuUuzzmJcBgNVE1FZuTnmMGSZpbbfCdYDtdtu5JizBN6cSlJt8C9U6sKoabuaA89KV3vgLjZmgdqkXZNtO/awQiVGi5OHfYgNRf2mW8ojb/70YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H7XpjaUtz79mXe4oSIULiyEZxOJpMF05OCpxJMXeHEQ=; b=ZJklFKSSIyuHWDdZqwWd89NMBmNDBqqlpxOsgETyp/EzMa3goX7IwN7wfu996HtAVMYMspybTlJaK5tfmjtyHXRWYo44bh0mPC7MhSC4szrN+0AHnaFmp/jRp/MZRvXLjc+uZHLvWq+0vuwRA2DEvduOl0ywNg7sGH8N/1JGGr3GkJ2KHL3VXXFete2hrycKmfFhODWpQmqYHzy9MYexXWwM6U7NiioB9JmC3gDztUo4rzDCQVV/6+xzWKOGDLMWctNlTF7v4X7l4O0gNtjovek468M1P/Gf15OAnJHZ2TJnBZopJGXlRVB7vktHPTUyr6jBVoG5wMF4/Rs3cfxdMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H7XpjaUtz79mXe4oSIULiyEZxOJpMF05OCpxJMXeHEQ=; b=EGdrPRb9MZ7leZnrgmWki6mKv4JP+Cs92jCML4WqFGjmKu4JTcNKSqs4HLm1PHZEYm7YihmnXsVo+WWgDZF0AdjqlYf0CZMirEVl0TAHkFgt98Zj7GTETNDudIvctyx8UT9KO6NevQoW0FKpyko6tyYKHmWfCQx37LiCmsh2VrI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shirik@mellanox.com; Received: from AM0PR0502MB3874.eurprd05.prod.outlook.com (52.133.45.29) by AM0PR0502MB3891.eurprd05.prod.outlook.com (52.133.45.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.25; Tue, 18 Feb 2020 11:54:57 +0000 Received: from AM0PR0502MB3874.eurprd05.prod.outlook.com ([fe80::500b:9d76:8f12:9cd7]) by AM0PR0502MB3874.eurprd05.prod.outlook.com ([fe80::500b:9d76:8f12:9cd7%7]) with mapi id 15.20.2729.032; Tue, 18 Feb 2020 11:54:56 +0000 From: Shiri Kuzin To: dev@dpdk.org Cc: matan@mellanox.com, rasland@mellanox.com, viacheslavo@mellanox.com, stable@dpdk.org Date: Tue, 18 Feb 2020 13:52:54 +0200 Message-Id: <1582026774-10127-1-git-send-email-shirik@mellanox.com> X-Mailer: git-send-email 1.8.3.1 X-ClientProxiedBy: PR0P264CA0163.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1b::31) To AM0PR0502MB3874.eurprd05.prod.outlook.com (2603:10a6:208:1a::29) MIME-Version: 1.0 Received: from mellanox.com (94.188.199.18) by PR0P264CA0163.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.23 via Frontend Transport; Tue, 18 Feb 2020 11:54:55 +0000 X-Mailer: git-send-email 1.8.3.1 X-Originating-IP: [94.188.199.18] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: c67e3ba1-53f2-4bc0-11e3-08d7b4695fa3 X-MS-TrafficTypeDiagnostic: AM0PR0502MB3891:|AM0PR0502MB3891: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:901; X-Forefront-PRVS: 031763BCAF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(39860400002)(136003)(376002)(396003)(366004)(199004)(189003)(66946007)(8936002)(450100002)(2616005)(956004)(66476007)(5660300002)(4326008)(81166006)(8676002)(66556008)(36756003)(81156014)(6916009)(316002)(2906002)(52116002)(7696005)(8886007)(26005)(186003)(478600001)(16526019)(55016002)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3891; H:AM0PR0502MB3874.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Rleoop6X3lsyZ4XxGjVD1UdtJlKzO/pi0ql8bTYt5mUKAZxKpEcU/q8Caofx71imzNS95/A0/NTanL4XXVqIJF+GCOmFNpZ6Pyrc8f2JG9s17gvbzW+i3zySk3YDzmJBSDnRRjpgs75fAL6ePvsYJhaJ78i47sJSEcoG/+FUC2xKmbiHjPz6WChcn+Vbbo66Hh3XGjKwe9axn/EEP7YDfONAOKrPNuhVNsPJSekwnOg7QCthNw6n74e7guqOfZ3DVfoLbOIpYgmSgHJal0EGlB8lEtXlRskenbxPXXsZTJv4J8OqQv237aJjj6wxtabZcpfVWlLDmw9+ELtZbAzSeOM822vCgkE2azRLlUZST2+7aRsJesPg+jHJKjjeJUmaZakMfiCPAHKrjdU4bJmdAhLZsk3ssl162MMI3nlh0ayDZBcLPkMMAR635DzfL4BN X-MS-Exchange-AntiSpam-MessageData: BrqiYHjl9jn4nCs7kahk33EdGddpIlVEqi053K8l/TlC77vlE8OSrTL8FTpHyOOZWYfO7NznFeZ0IoiW5cgbTYgceekXG9ST8HsvBSN1ZcDMv/W2t2W/4HpwmV/SpVASwHtLTm2oY/mfAqEfK2jT9Q== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c67e3ba1-53f2-4bc0-11e3-08d7b4695fa3 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2020 11:54:56.7421 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F4KIM4A+bm/7KW59VsVm7rN1Vh7Qs3hU4qAXTjTP7Nfnf6i/xJoPvWP+YKY0QHs/MM6RAWg+lQrg8pDy7ZuOzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3891 Subject: [dpdk-dev] [PATCH] net/mlx5: fix ipv6 type icmp6 header rewrite actions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ICMPv6 header contains the checksum field, that includes the IP addresses from IP header. The ConnectX-5 hardware does not support ICMPv6 checksum calculation and in case of IP header modification the checksum will contain the wrong value. The patch rejects the header modification actions related to IP addresses if ICMPv6 protocol is detected in pattern. This issue was also partly fixed in commit [1] which rejects flows with the pattern "ipv6 proto is 58". [1] commit b1632bd0c1e3 ("net/mlx5: fix ICMPv6 header rewrite actions") Fixes: 4bb14c83df95 ("net/mlx5: support modify header using Direct Verbs") Cc: stable@dpdk.org Signed-off-by: Shiri Kuzin Acked-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow_dv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index a9bb0b4..e5862bd 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -4621,6 +4621,7 @@ struct field_modify_info modify_tcp[] = { error); if (ret < 0) return ret; + item_ipv6_proto = IPPROTO_ICMPV6; last_item = MLX5_FLOW_LAYER_ICMP6; break; case RTE_FLOW_ITEM_TYPE_TAG: