From patchwork Fri Aug 30 14:13:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lavanya Govindarajan X-Patchwork-Id: 58305 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E03BA1E8F5; Fri, 30 Aug 2019 16:14:20 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2F7651E8CB for ; Fri, 30 Aug 2019 16:14:19 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Aug 2019 07:14:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,447,1559545200"; d="scan'208";a="186309970" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga006.jf.intel.com with ESMTP; 30 Aug 2019 07:14:16 -0700 Received: from wgcvswdev001.ir.intel.com (wgcvswdev001.ir.intel.com [10.102.246.100]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id x7UEEF4x029449; Fri, 30 Aug 2019 15:14:15 +0100 Received: from wgcvswdev001.ir.intel.com (localhost [127.0.0.1]) by wgcvswdev001.ir.intel.com with ESMTP id x7UEDdil027607; Fri, 30 Aug 2019 15:13:39 +0100 Received: (from lgovin3x@localhost) by wgcvswdev001.ir.intel.com with ? id x7UEDdGb027603; Fri, 30 Aug 2019 15:13:39 +0100 From: Lavanya Govindarajan To: dev@dpdk.org Cc: reshma.pattan@intel.com, olivier.matz@6wind.com, bruce.richardson@intel.com, jananeex.m.parthasarathy@intel.com, pallantlax.poornima@intel.com Date: Fri, 30 Aug 2019 15:13:15 +0100 Message-Id: <1567174395-27432-3-git-send-email-lavanyax.govindarajan@intel.com> X-Mailer: git-send-email 1.7.0.7 In-Reply-To: <1565271260-10295-2-git-send-email-lavanyax.govindarajan@intel.com> References: <1565271260-10295-2-git-send-email-lavanyax.govindarajan@intel.com> Subject: [dpdk-dev] [PATCH v5 2/2] app/test: add unit test for mbuf flag names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Pallantla Poornima Added UT for the below four functions in test_mbuf.c rte_get_rx_ol_flag_list rte_get_tx_ol_flag_list rte_get_rx_ol_flag_name rte_get_tx_ol_flag_name Signed-off-by: Pallantla Poornima --- app/test/test_mbuf.c | 257 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 257 insertions(+) diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index 346d9ede4..dd1bc25e6 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -50,6 +50,7 @@ #define MBUF_NO_HEADER 0 #define MBUF_HEADER 1 #define MBUF_NEG_TEST_READ 2 +#define VAL_NAME(flag) { flag, #flag } /* size of private data for mbuf in pktmbuf_pool2 */ #define MBUF2_PRIV_SIZE 128 @@ -1132,6 +1133,242 @@ test_tx_offload(void) return (v1 == v2) ? 0 : -EINVAL; } +static int +test_get_rx_ol_flag_list(void) +{ + int len = 6, ret = 0; + char buf[256] = ""; + int buflen = 0; + + /* Test case to check with null buffer */ + ret = rte_get_rx_ol_flag_list(0, NULL, 0); + if (ret != -1) + GOTO_FAIL("%s expected: -1, received = %d\n", __func__, ret); + + /* Test case to check with zero buffer len */ + ret = rte_get_rx_ol_flag_list(PKT_RX_L4_CKSUM_MASK, buf, 0); + if (ret != -1) + GOTO_FAIL("%s expected: -1, received = %d\n", __func__, ret); + + buflen = strlen(buf); + if (buflen != 0) + GOTO_FAIL("%s buffer should be empty, received = %d\n", + __func__, buflen); + + /* Test case to check with reduced buffer len */ + ret = rte_get_rx_ol_flag_list(0, buf, len); + if (ret != -1) + GOTO_FAIL("%s expected: -1, received = %d\n", __func__, ret); + + buflen = strlen(buf); + if (buflen != (len - 1)) + GOTO_FAIL("%s invalid buffer length retrieved, expected: %d," + "received = %d\n", __func__, + (len - 1), buflen); + + /* Test case to check with zero mask value */ + ret = rte_get_rx_ol_flag_list(0, buf, sizeof(buf)); + if (ret != 0) + GOTO_FAIL("%s expected: 0, received = %d\n", __func__, ret); + + buflen = strlen(buf); + if (buflen == 0) + GOTO_FAIL("%s expected: %s, received length = 0\n", __func__, + "non-zero, buffer should not be empty"); + + /* Test case to check with valid mask value */ + ret = rte_get_rx_ol_flag_list(PKT_RX_SEC_OFFLOAD, buf, sizeof(buf)); + if (ret != 0) + GOTO_FAIL("%s expected: 0, received = %d\n", __func__, ret); + + buflen = strlen(buf); + if (buflen == 0) + GOTO_FAIL("%s expected: %s, received length = 0\n", __func__, + "non-zero, buffer should not be empty"); + + + return 0; +fail: + return -1; +} + +static int +test_get_tx_ol_flag_list(void) +{ + int len = 6, ret = 0; + char buf[256] = ""; + int buflen = 0; + + /* Test case to check with null buffer */ + ret = rte_get_tx_ol_flag_list(0, NULL, 0); + if (ret != -1) + GOTO_FAIL("%s expected: -1, received = %d\n", __func__, ret); + + /* Test case to check with zero buffer len */ + ret = rte_get_tx_ol_flag_list(PKT_TX_IP_CKSUM, buf, 0); + if (ret != -1) + GOTO_FAIL("%s expected: -1, received = %d\n", __func__, ret); + + buflen = strlen(buf); + if (buflen != 0) { + GOTO_FAIL("%s buffer should be empty, received = %d\n", + __func__, buflen); + } + + /* Test case to check with reduced buffer len */ + ret = rte_get_tx_ol_flag_list(0, buf, len); + if (ret != -1) + GOTO_FAIL("%s expected: -1, received = %d\n", __func__, ret); + + buflen = strlen(buf); + if (buflen != (len - 1)) + GOTO_FAIL("%s invalid buffer length retrieved, expected: %d," + "received = %d\n", __func__, + (len - 1), buflen); + + /* Test case to check with zero mask value */ + ret = rte_get_tx_ol_flag_list(0, buf, sizeof(buf)); + if (ret != 0) + GOTO_FAIL("%s expected: 0, received = %d\n", __func__, ret); + + buflen = strlen(buf); + if (buflen == 0) + GOTO_FAIL("%s expected: %s, received length = 0\n", __func__, + "non-zero, buffer should not be empty"); + + /* Test case to check with valid mask value */ + ret = rte_get_tx_ol_flag_list(PKT_TX_UDP_CKSUM, buf, sizeof(buf)); + if (ret != 0) + GOTO_FAIL("%s expected: 0, received = %d\n", __func__, ret); + + buflen = strlen(buf); + if (buflen == 0) + GOTO_FAIL("%s expected: %s, received length = 0\n", __func__, + "non-zero, buffer should not be empty"); + + return 0; +fail: + return -1; + +} + +struct flag_name { + uint64_t flag; + const char *name; +}; + +static int +test_get_rx_ol_flag_name(void) +{ + uint16_t i; + const char *flag_str = NULL; + const struct flag_name rx_flags[] = { + + VAL_NAME(PKT_RX_VLAN), + VAL_NAME(PKT_RX_RSS_HASH), + VAL_NAME(PKT_RX_FDIR), + VAL_NAME(PKT_RX_L4_CKSUM_BAD), + VAL_NAME(PKT_RX_L4_CKSUM_GOOD), + VAL_NAME(PKT_RX_L4_CKSUM_NONE), + VAL_NAME(PKT_RX_IP_CKSUM_BAD), + VAL_NAME(PKT_RX_IP_CKSUM_GOOD), + VAL_NAME(PKT_RX_IP_CKSUM_NONE), + VAL_NAME(PKT_RX_EIP_CKSUM_BAD), + VAL_NAME(PKT_RX_VLAN_STRIPPED), + VAL_NAME(PKT_RX_IEEE1588_PTP), + VAL_NAME(PKT_RX_IEEE1588_TMST), + VAL_NAME(PKT_RX_FDIR_ID), + VAL_NAME(PKT_RX_FDIR_FLX), + VAL_NAME(PKT_RX_QINQ_STRIPPED), + VAL_NAME(PKT_RX_LRO), + VAL_NAME(PKT_RX_TIMESTAMP), + VAL_NAME(PKT_RX_SEC_OFFLOAD), + VAL_NAME(PKT_RX_SEC_OFFLOAD_FAILED), + VAL_NAME(PKT_RX_OUTER_L4_CKSUM_BAD), + VAL_NAME(PKT_RX_OUTER_L4_CKSUM_GOOD), + VAL_NAME(PKT_RX_OUTER_L4_CKSUM_INVALID), + }; + + /* Test case to check with valid flag */ + for (i = 0; i < RTE_DIM(rx_flags); i++) { + flag_str = rte_get_rx_ol_flag_name(rx_flags[i].flag); + if (flag_str == NULL) + GOTO_FAIL("%s: Expected flagname = %s; received null\n", + __func__, rx_flags[i].name); + if (strcmp(flag_str, rx_flags[i].name) != 0) + GOTO_FAIL("%s: Expected flagname = %s; received = %s\n", + __func__, rx_flags[i].name, flag_str); + } + /* Test case to check with invalid flag */ + flag_str = rte_get_rx_ol_flag_name(0); + if (flag_str != NULL) { + GOTO_FAIL("%s: Expected flag name = null; received = %s\n", + __func__, flag_str); + } + + return 0; +fail: + return -1; +} + +static int +test_get_tx_ol_flag_name(void) +{ + uint16_t i; + const char *flag_str = NULL; + const struct flag_name tx_flags[] = { + + VAL_NAME(PKT_TX_VLAN), + VAL_NAME(PKT_TX_IP_CKSUM), + VAL_NAME(PKT_TX_TCP_CKSUM), + VAL_NAME(PKT_TX_SCTP_CKSUM), + VAL_NAME(PKT_TX_UDP_CKSUM), + VAL_NAME(PKT_TX_IEEE1588_TMST), + VAL_NAME(PKT_TX_TCP_SEG), + VAL_NAME(PKT_TX_IPV4), + VAL_NAME(PKT_TX_IPV6), + VAL_NAME(PKT_TX_OUTER_IP_CKSUM), + VAL_NAME(PKT_TX_OUTER_IPV4), + VAL_NAME(PKT_TX_OUTER_IPV6), + VAL_NAME(PKT_TX_TUNNEL_VXLAN), + VAL_NAME(PKT_TX_TUNNEL_GRE), + VAL_NAME(PKT_TX_TUNNEL_IPIP), + VAL_NAME(PKT_TX_TUNNEL_GENEVE), + VAL_NAME(PKT_TX_TUNNEL_MPLSINUDP), + VAL_NAME(PKT_TX_TUNNEL_VXLAN_GPE), + VAL_NAME(PKT_TX_TUNNEL_IP), + VAL_NAME(PKT_TX_TUNNEL_UDP), + VAL_NAME(PKT_TX_QINQ), + VAL_NAME(PKT_TX_MACSEC), + VAL_NAME(PKT_TX_SEC_OFFLOAD), + VAL_NAME(PKT_TX_UDP_SEG), + VAL_NAME(PKT_TX_OUTER_UDP_CKSUM), + VAL_NAME(PKT_TX_METADATA), + }; + + /* Test case to check with valid flag */ + for (i = 0; i < RTE_DIM(tx_flags); i++) { + flag_str = rte_get_tx_ol_flag_name(tx_flags[i].flag); + if (flag_str == NULL) + GOTO_FAIL("%s: Expected flagname = %s; received null\n", + __func__, tx_flags[i].name); + if (strcmp(flag_str, tx_flags[i].name) != 0) + GOTO_FAIL("%s: Expected flagname = %s; received = %s\n", + __func__, tx_flags[i].name, flag_str); + } + /* Test case to check with invalid flag */ + flag_str = rte_get_tx_ol_flag_name(0); + if (flag_str != NULL) { + GOTO_FAIL("%s: Expected flag name = null; received = %s\n", + __func__, flag_str); + } + + return 0; +fail: + return -1; + +} + static int test_mbuf_validate_tx_offload(const char *test_name, struct rte_mempool *pktmbuf_pool, @@ -1950,6 +2187,26 @@ test_mbuf(void) goto err; } + if (test_get_rx_ol_flag_list() < 0) { + printf("test_rte_get_rx_ol_flag_list() failed\n"); + goto err; + } + + if (test_get_tx_ol_flag_list() < 0) { + printf("test_rte_get_tx_ol_flag_list() failed\n"); + goto err; + } + + if (test_get_rx_ol_flag_name() < 0) { + printf("test_rte_get_rx_ol_flag_name() failed\n"); + goto err; + } + + if (test_get_tx_ol_flag_name() < 0) { + printf("test_rte_get_tx_ol_flag_name() failed\n"); + goto err; + } + if (test_mbuf_validate_tx_offload_one(pktmbuf_pool) < 0) { printf("test_mbuf_validate_tx_offload_one() failed\n"); goto err;