diff mbox series

buildtools: filter out symbols for ICC

Message ID 1562069630-7929-1-git-send-email-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series buildtools: filter out symbols for ICC |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply issues
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

David Marchand July 2, 2019, 12:13 p.m. UTC 
  For some reason, ICC creates additional global symbols with a . which
triggers an error in the check that validates that symbols in the
experimental section are properly published in the map file of the
library. Filter them out.

Fixes: 3290ac14eb94 ("buildtools: detect discrepancies for experimental symbols")

Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 buildtools/check-experimental-syms.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Ferruh Yigit July 2, 2019, 12:59 p.m. UTC | #1 
On 7/2/2019 1:13 PM, David Marchand wrote:
> For some reason, ICC creates additional global symbols with a . which
> triggers an error in the check that validates that symbols in the
> experimental section are properly published in the map file of the
> library. Filter them out.
> 
> Fixes: 3290ac14eb94 ("buildtools: detect discrepancies for experimental symbols")
> 
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Thomas Monjalon July 2, 2019, 2:07 p.m. UTC | #2 
02/07/2019 14:59, Ferruh Yigit:
> On 7/2/2019 1:13 PM, David Marchand wrote:
> > For some reason, ICC creates additional global symbols with a . which
> > triggers an error in the check that validates that symbols in the
> > experimental section are properly published in the map file of the
> > library. Filter them out.
> > 
> > Fixes: 3290ac14eb94 ("buildtools: detect discrepancies for experimental symbols")
> > 
> > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> 
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-experimental-syms.sh
index 653756e..0f6c62d 100755
--- a/buildtools/check-experimental-syms.sh
+++ b/buildtools/check-experimental-syms.sh
@@ -36,8 +36,9 @@  do
 	fi
 done
 
+# Filter out symbols suffixed with a . for icc
 for SYM in `objdump -t $OBJFILE |awk '{
-	if ($2 != "l" && $4 == ".text.experimental") {
+	if ($2 != "l" && $4 == ".text.experimental" && !($NF ~ /\.$/)) {
 		print $NF
 	}
 }'`