From patchwork Sat Jun 29 11:58:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 55659 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C874C1B96B; Sat, 29 Jun 2019 13:59:27 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 5AAC8559A; Sat, 29 Jun 2019 13:59:19 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9B82230821FF; Sat, 29 Jun 2019 11:59:18 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-204-190.brq.redhat.com [10.40.204.190]) by smtp.corp.redhat.com (Postfix) with ESMTP id EC6BE600C4; Sat, 29 Jun 2019 11:59:16 +0000 (UTC) From: David Marchand To: dev@dpdk.org, thomas@monjalon.net Cc: nhorman@tuxdriver.com, adrien.mazarguil@6wind.com, stephen@networkplumber.org, stable@dpdk.org Date: Sat, 29 Jun 2019 13:58:49 +0200 Message-Id: <1561809533-6545-7-git-send-email-david.marchand@redhat.com> In-Reply-To: <1561809533-6545-1-git-send-email-david.marchand@redhat.com> References: <1561635235-22238-1-git-send-email-david.marchand@redhat.com> <1561809533-6545-1-git-send-email-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Sat, 29 Jun 2019 11:59:18 +0000 (UTC) Subject: [dpdk-dev] [PATCH v2 06/10] net/atlantic: add missing experimental api tags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Those symbols are declared in the library map but the prototypes are missing the experimental tag. Without it, existing users won't notice it is experimental. Fixes: ec0dec44ecb9 ("net/atlantic: enable MACsec configuration") Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Adrien Mazarguil Acked-by: Neil Horman --- drivers/net/atlantic/rte_pmd_atlantic.c | 12 ++++++------ drivers/net/atlantic/rte_pmd_atlantic.h | 24 ++++++++++++++++++++++++ 2 files changed, 30 insertions(+), 6 deletions(-) diff --git a/drivers/net/atlantic/rte_pmd_atlantic.c b/drivers/net/atlantic/rte_pmd_atlantic.c index 5bf4da2..2962f5c 100644 --- a/drivers/net/atlantic/rte_pmd_atlantic.c +++ b/drivers/net/atlantic/rte_pmd_atlantic.c @@ -8,7 +8,7 @@ #include "atl_ethdev.h" -__rte_experimental int +int rte_pmd_atl_macsec_enable(uint16_t port, uint8_t encr, uint8_t repl_prot) { @@ -24,7 +24,7 @@ return atl_macsec_enable(dev, encr, repl_prot); } -__rte_experimental int +int rte_pmd_atl_macsec_disable(uint16_t port) { struct rte_eth_dev *dev; @@ -39,7 +39,7 @@ return atl_macsec_disable(dev); } -__rte_experimental int +int rte_pmd_atl_macsec_config_txsc(uint16_t port, uint8_t *mac) { struct rte_eth_dev *dev; @@ -54,7 +54,7 @@ return atl_macsec_config_txsc(dev, mac); } -__rte_experimental int +int rte_pmd_atl_macsec_config_rxsc(uint16_t port, uint8_t *mac, uint16_t pi) { struct rte_eth_dev *dev; @@ -69,7 +69,7 @@ return atl_macsec_config_rxsc(dev, mac, pi); } -__rte_experimental int +int rte_pmd_atl_macsec_select_txsa(uint16_t port, uint8_t idx, uint8_t an, uint32_t pn, uint8_t *key) { @@ -85,7 +85,7 @@ return atl_macsec_select_txsa(dev, idx, an, pn, key); } -__rte_experimental int +int rte_pmd_atl_macsec_select_rxsa(uint16_t port, uint8_t idx, uint8_t an, uint32_t pn, uint8_t *key) { diff --git a/drivers/net/atlantic/rte_pmd_atlantic.h b/drivers/net/atlantic/rte_pmd_atlantic.h index e4db7c6..c020856 100644 --- a/drivers/net/atlantic/rte_pmd_atlantic.h +++ b/drivers/net/atlantic/rte_pmd_atlantic.h @@ -14,6 +14,9 @@ #include /** + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * * Enable MACsec offload. * * @param port @@ -29,9 +32,13 @@ * - (-ENODEV) if *port* invalid. * - (-ENOTSUP) if hardware doesn't support this feature. */ +__rte_experimental int rte_pmd_atl_macsec_enable(uint16_t port, uint8_t encr, uint8_t repl_prot); /** + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * * Disable MACsec offload. * * @param port @@ -41,9 +48,13 @@ * - (-ENODEV) if *port* invalid. * - (-ENOTSUP) if hardware doesn't support this feature. */ +__rte_experimental int rte_pmd_atl_macsec_disable(uint16_t port); /** + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * * Configure Tx SC (Secure Connection). * * @param port @@ -55,9 +66,13 @@ * - (-ENODEV) if *port* invalid. * - (-ENOTSUP) if hardware doesn't support this feature. */ +__rte_experimental int rte_pmd_atl_macsec_config_txsc(uint16_t port, uint8_t *mac); /** + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * * Configure Rx SC (Secure Connection). * * @param port @@ -71,9 +86,13 @@ * - (-ENODEV) if *port* invalid. * - (-ENOTSUP) if hardware doesn't support this feature. */ +__rte_experimental int rte_pmd_atl_macsec_config_rxsc(uint16_t port, uint8_t *mac, uint16_t pi); /** + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * * Enable Tx SA (Secure Association). * * @param port @@ -92,10 +111,14 @@ * - (-ENOTSUP) if hardware doesn't support this feature. * - (-EINVAL) if bad parameter. */ +__rte_experimental int rte_pmd_atl_macsec_select_txsa(uint16_t port, uint8_t idx, uint8_t an, uint32_t pn, uint8_t *key); /** + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * * Enable Rx SA (Secure Association). * * @param port @@ -114,6 +137,7 @@ int rte_pmd_atl_macsec_select_txsa(uint16_t port, uint8_t idx, uint8_t an, * - (-ENOTSUP) if hardware doesn't support this feature. * - (-EINVAL) if bad parameter. */ +__rte_experimental int rte_pmd_atl_macsec_select_rxsa(uint16_t port, uint8_t idx, uint8_t an, uint32_t pn, uint8_t *key);