From patchwork Fri Apr 12 07:04:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gagandeep Singh X-Patchwork-Id: 52678 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4D5525F34; Fri, 12 Apr 2019 09:04:59 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70081.outbound.protection.outlook.com [40.107.7.81]) by dpdk.org (Postfix) with ESMTP id 3B0095A6A for ; Fri, 12 Apr 2019 09:04:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w+tnVTuK68FdH5PRxRwOlYwgERH2sbADMbCTQJIkKr0=; b=e2yTiW6Zsdzo2kdTkDkyb2ENDJ4LWcW+lblzEiqccVJD/yJ771dKnRO/H1rom38wMDzOEwyHzEVbhAB6ZPQHQIAmQPCtMMlx5l8/Rst2nNxMh+2CDlrD2hC8fjfDL5DMFgUcUTdvb7Cu4msSOWmHmISBMBfwgiA4VHWgLGFrX6U= Received: from VE1PR04MB6365.eurprd04.prod.outlook.com (10.255.118.78) by VE1PR04MB6461.eurprd04.prod.outlook.com (20.179.233.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.17; Fri, 12 Apr 2019 07:04:26 +0000 Received: from VE1PR04MB6365.eurprd04.prod.outlook.com ([fe80::f5ad:f178:4c55:13e0]) by VE1PR04MB6365.eurprd04.prod.outlook.com ([fe80::f5ad:f178:4c55:13e0%3]) with mapi id 15.20.1792.016; Fri, 12 Apr 2019 07:04:26 +0000 From: Gagandeep Singh To: "dev@dpdk.org" , "ferruh.yigit@intel.com" CC: "thomas@monjalon.net" , Gagandeep Singh Thread-Topic: [PATCH v2 13/13] net/enetc: fix crash at high speed traffic Thread-Index: AQHU8P33b8d72F613kKQV/DCbMWl8w== Date: Fri, 12 Apr 2019 07:04:26 +0000 Message-ID: <1555075598-4988-14-git-send-email-g.singh@nxp.com> References: <1554745507-15089-1-git-send-email-g.singh@nxp.com> <1555075598-4988-1-git-send-email-g.singh@nxp.com> In-Reply-To: <1555075598-4988-1-git-send-email-g.singh@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BM1PR0101CA0038.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::24) To VE1PR04MB6365.eurprd04.prod.outlook.com (2603:10a6:803:12a::14) x-mailer: git-send-email 1.9.1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=G.Singh@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [92.120.1.67] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 59e45108-07a4-4076-6026-08d6bf15196f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6461; x-ms-traffictypediagnostic: VE1PR04MB6461: x-microsoft-antispam-prvs: x-forefront-prvs: 0005B05917 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(39860400002)(376002)(366004)(396003)(346002)(189003)(199004)(6512007)(102836004)(256004)(86362001)(36756003)(14444005)(486006)(25786009)(6486002)(2501003)(26005)(386003)(2906002)(66066001)(7736002)(71190400001)(14454004)(71200400001)(6506007)(53936002)(97736004)(186003)(76176011)(8676002)(52116002)(105586002)(106356001)(99286004)(446003)(81166006)(81156014)(72206003)(478600001)(50226002)(11346002)(476003)(2616005)(6116002)(54906003)(5660300002)(110136005)(4326008)(316002)(8936002)(6436002)(4744005)(68736007)(3846002)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6461; H:VE1PR04MB6365.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: UgxJ1K8kaOmzBi66WIasIU/KQVQm45SvkFlSl4VTck9vpPrC5iFx21XCzzpmKPPnkoneP9hE0j/ajJ82ZufbBzE2lGTgsPoQ+Dx1+la5JbwaYDE8ASGKwwzfFq/1Wy1RoYAjwH/YmBO2fF+EjwDbLyZUfF9f+srl//EureA7iw6gNj5Ej0lbBjfRS0R0QHW72IR57DjW8+qj5WYX2r9PVMhi+PTHeRNhq79PiVaK8duTzxyTJBgpEUfXnkNms9NyKqccgR+o6sQPVchO2NPIhzcGhLmhe/qiQICRtrMfBd8thO4UmdUlfeZYIr6tez5W1VNFhXD+hpYj8RPfxyB/5/ce56OJJ2pWdDYr5hm0tuyhFoVO6q1Ndi7oxLnx9565LsNH0gD6b/23PWISTv0xPRcecplq5nnMUGVJZGcvuFg= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59e45108-07a4-4076-6026-08d6bf15196f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2019 07:04:26.6595 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6461 Subject: [dpdk-dev] [PATCH v2 13/13] net/enetc: fix crash at high speed traffic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On xmit side, there should be a check whether BD ring has free BDs available before transmit a packet to avoid data corruption and buffer leak issue. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: g.singh@nxp.com Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_rxtx.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/enetc/enetc_rxtx.c b/drivers/net/enetc/enetc_rxtx.c index 0ce7dbe..81b0ef3 100644 --- a/drivers/net/enetc/enetc_rxtx.c +++ b/drivers/net/enetc/enetc_rxtx.c @@ -49,11 +49,16 @@ uint16_t nb_pkts) { struct enetc_swbd *tx_swbd; - int i, start; + int i, start, bds_to_use; struct enetc_tx_bd *txbd; struct enetc_bdr *tx_ring = (struct enetc_bdr *)tx_queue; i = tx_ring->next_to_use; + + bds_to_use = enetc_bd_unused(tx_ring); + if (bds_to_use < nb_pkts) + nb_pkts = bds_to_use; + start = 0; while (nb_pkts--) { enetc_clean_tx_ring(tx_ring);