[v2,1/2] test/distributor: flush with worker shutdown test fails
Checks
Commit Message
On restarting worker 0 after shutdown, packets handled by
worker 0 must be incremented only when a packet is received by
it.
Signed-off-by: Harman Kalra <hkalra@marvell.com>
---
test/test/test_distributor.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
18/02/2019 15:51, Harman Kalra:
> On restarting worker 0 after shutdown, packets handled by
> worker 0 must be incremented only when a packet is received by
> it.
>
> Signed-off-by: Harman Kalra <hkalra@marvell.com>
It looks to be a fix, so the tag Fixes: should be added
to help with backport, please.
The title may be improved by starting with "fix" verb
instead of mentioning "fails".
29/03/2019 23:54, Thomas Monjalon:
> 18/02/2019 15:51, Harman Kalra:
> > On restarting worker 0 after shutdown, packets handled by
> > worker 0 must be incremented only when a packet is received by
> > it.
> >
> > Signed-off-by: Harman Kalra <hkalra@marvell.com>
>
> It looks to be a fix, so the tag Fixes: should be added
> to help with backport, please.
> The title may be improved by starting with "fix" verb
> instead of mentioning "fails".
No review, no reply.
Status set to "Changes Requested" in patchwork.
@@ -373,7 +373,8 @@ handle_work_for_shutdown_test(void *arg)
id, buf, buf, num);
while (!quit) {
- worker_stats[id].handled_packets++, count++;
+ worker_stats[id].handled_packets += num;
+ count += num;
rte_pktmbuf_free(pkt);
num = rte_distributor_get_pkt(d, id, buf, buf, num);
}