From patchwork Tue Dec 18 15:19:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnon Warshavsky X-Patchwork-Id: 49083 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AE8291BB43; Tue, 18 Dec 2018 16:19:07 +0100 (CET) Received: from mta.qwilt.com (mta.qwilt.com [52.9.191.255]) by dpdk.org (Postfix) with ESMTP id 6562C1BB42 for ; Tue, 18 Dec 2018 16:19:06 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mta.qwilt.com (Postfix) with ESMTP id 87FA587859C; Tue, 18 Dec 2018 15:19:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at qwilt.com Received: from mta.qwilt.com ([127.0.0.1]) by localhost (mta.qwilt.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cEZwyQ6mHykN; Tue, 18 Dec 2018 15:19:05 +0000 (UTC) Received: from rd01.it.qwilt.com.qwilt.com (80.179.204.39.cable.012.net.il [80.179.204.39]) by mta.qwilt.com (Postfix) with ESMTPSA id E9BBA878575; Tue, 18 Dec 2018 15:19:03 +0000 (UTC) From: Arnon Warshavsky To: ferruh.yigit@intel.com, ajit.khaparde@broadcom.com, thomasm@mellanox.com Cc: dev@dpdk.org, arnon@qwilt.com Date: Tue, 18 Dec 2018 17:19:00 +0200 Message-Id: <1545146340-17973-1-git-send-email-arnon@qwilt.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1545141782-31841-1-git-send-email-arnon@qwilt.com> References: <1545141782-31841-1-git-send-email-arnon@qwilt.com> Subject: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Bugzilla ID: 165 Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides") Signed-off-by: Arnon Warshavsky Explicitly collect the error code of the multiple awk script calls --- devtools/checkpatches.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index ee8debe..3b03b7e 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -44,6 +44,8 @@ print_usage () { } check_forbidden_additions() { # + res=0 + # refrain from new additions of rte_panic() and rte_exit() # multiple folders and expressions are separated by spaces awk -v FOLDERS="lib drivers" \ @@ -51,7 +53,8 @@ check_forbidden_additions() { # -v RET_ON_FAIL=1 \ -v MESSAGE='Using rte_panic/rte_exit' \ -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \ - "$1" + "$1" || res=1 + # svg figures must be included with wildcard extension # because of png conversion for pdf docs awk -v FOLDERS='doc' \ @@ -59,7 +62,9 @@ check_forbidden_additions() { # -v RET_ON_FAIL=1 \ -v MESSAGE='Using explicit .svg extension instead of .*' \ -f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \ - "$1" + "$1" || res = 1 + + return $res } number=0