diff mbox series

eventdev: fix call to strerror in eth Rx adapter

Message ID 1543478417-30869-1-git-send-email-nikhil.rao@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series eventdev: fix call to strerror in eth Rx adapter |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Rao, Nikhil Nov. 29, 2018, 8 a.m. UTC 
  strerror() input parameter should be > 0.

Coverity issue: 302864

Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter")
CC: stable@dpdk.org
Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
 lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit Nov. 29, 2018, 8:53 a.m. UTC | #1 
On 11/29/2018 8:00 AM, Nikhil Rao wrote:
> strerror() input parameter should be > 0.
> 
> Coverity issue: 302864
> Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter")
> CC: stable@dpdk.org
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Jerin Jacob Dec. 1, 2018, 2:09 p.m. UTC | #2 
-----Original Message-----
> Date: Thu, 29 Nov 2018 08:53:30 +0000
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> To: Nikhil Rao <nikhil.rao@intel.com>, jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] eventdev: fix call to strerror in eth Rx
>  adapter
> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
>  Thunderbird/60.3.1
> 
> 
> On 11/29/2018 8:00 AM, Nikhil Rao wrote:
> > strerror() input parameter should be > 0.
> >
> > Coverity issue: 302864
> > Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter")
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-eventdev/master. Thanks.
diff mbox series

Patch

diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
index 8831bc35f..8d178be15 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
@@ -912,7 +912,7 @@  rxa_intr_ring_enqueue(struct rte_event_eth_rx_adapter *rx_adapter,
 		 */
 		if (err)
 			RTE_EDEV_LOG_ERR("Failed to enqueue interrupt"
-				" to ring: %s", strerror(err));
+				" to ring: %s", strerror(-err));
 		else
 			rte_eth_dev_rx_intr_disable(port_id, queue);
 	}