From patchwork Wed Nov 28 13:55:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tonghao Zhang X-Patchwork-Id: 48387 X-Patchwork-Delegate: cristian.dumitrescu@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2BBB91B469; Wed, 28 Nov 2018 14:56:07 +0100 (CET) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 49CA11B450 for ; Wed, 28 Nov 2018 14:56:05 +0100 (CET) Received: by mail-pl1-f195.google.com with SMTP id b5so17433701plr.4 for ; Wed, 28 Nov 2018 05:56:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=dgjqhOC6b+Fcr7IG70fqdKULAYAGnngFKGhk+28GZB4=; b=CYIhdvlgKnzWam5+vRsYRN1EWQ9WdtKDjr9gDM+zWRnu6f1Hl1/A/visKO4JxWzDz6 2Sfs3/MvLrJqMclKTasz4S4LDJzqWGxP6+sIGgRaL973j1fHpl1LzXJFp82j7Yqx/sFO 6blkGlOw/ZJnyiSsI8j4y21eGxGsj+2+wJm9lWaVe2/PP4rVK2uzEVe9IIeCnB1SHskt lC8qC5mUrVdukMuc5x1YML7fJaU6RsUcCYqnJ0Y3DNrBpCk5HLxAdplyIDVmZR0wZEfi 8phSkhqslsIX4tI/o+61aPeOfag2XJVDR3mKxbkRcuEpol6CaXTz/iCr5MMfVBoX/qxJ Q+Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dgjqhOC6b+Fcr7IG70fqdKULAYAGnngFKGhk+28GZB4=; b=fdUW0ROz0q/3XZPm7zZLEG3slpHrAdB/o0qplvLYnOKbwJWSa9p1KwiAxLRKsbNZ3G KtEMFe9b4htlwQYel+jdXehb4qVsIcB0a0L1MBucu0tHWxst/ZtcQixuNl9eC6VBD9af 7N2UvSQ5GWhdJW0T/Eh5ciGRa+NprePDgc1VkUrrjJw44/vZct8WhA+kdcBUTVvK7ZOe 9imCaygS+2/OiQecykWF7Fj6Bsyz2gSeUPnC9DB80FxGhj9ft2oDv661L8igycakFNvp 9nPZLnjpNEhDTy7JR8/2+XAd2WszkXNZ6FqOxK5qJ0ntNsqgemoAgPGjq2wn5xnu/x+d /+Kw== X-Gm-Message-State: AA+aEWYXYGSSBQu6h3XShUtkDBnKv7xjQb75+q8/P1TKdrhskjt2JAfR 4y3t4fRs4H2HSppy6xoqy3FlYkxU X-Google-Smtp-Source: AFSGD/W3T3SrdVdQy3AFcdiytU2ysjwSRzoqsPMYYMuSrUWzPOxEYaAUVX40vTvl8OsWaATJ3sXDDg== X-Received: by 2002:a17:902:a710:: with SMTP id w16mr36406449plq.95.1543413364256; Wed, 28 Nov 2018 05:56:04 -0800 (PST) Received: from local.opencloud.tech.localdomain ([203.100.54.194]) by smtp.gmail.com with ESMTPSA id e86sm9876872pfb.6.2018.11.28.05.56.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Nov 2018 05:56:03 -0800 (PST) From: Tonghao Zhang To: dev@dpdk.org Cc: Tonghao Zhang Date: Wed, 28 Nov 2018 05:55:54 -0800 Message-Id: <1543413355-2874-1-git-send-email-xiangxia.m.yue@gmail.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-dev] [PATCH 1/2] sched: refine get base helper function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" use switch instead of if, and it is more easy reading. Signed-off-by: Tonghao Zhang --- lib/librte_sched/rte_sched.c | 40 +++++++++++++++++++--------------------- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c index 587d5e6..17de6e6 100644 --- a/lib/librte_sched/rte_sched.c +++ b/lib/librte_sched/rte_sched.c @@ -385,7 +385,7 @@ enum rte_sched_port_array { uint32_t n_subports_per_port = params->n_subports_per_port; uint32_t n_pipes_per_subport = params->n_pipes_per_subport; uint32_t n_pipes_per_port = n_pipes_per_subport * n_subports_per_port; - uint32_t n_queues_per_port = RTE_SCHED_QUEUES_PER_PIPE * n_pipes_per_subport * n_subports_per_port; + uint32_t n_queues_per_port = RTE_SCHED_QUEUES_PER_PIPE * n_pipes_per_port; uint32_t size_subport = n_subports_per_port * sizeof(struct rte_sched_subport); uint32_t size_pipe = n_pipes_per_port * sizeof(struct rte_sched_pipe); @@ -407,35 +407,33 @@ enum rte_sched_port_array { size_queue_array = n_pipes_per_port * size_per_pipe_queue_array; base = 0; + switch (array) { + case e_RTE_SCHED_PORT_ARRAY_TOTAL: + base += RTE_CACHE_LINE_ROUNDUP(size_queue_array); - if (array == e_RTE_SCHED_PORT_ARRAY_SUBPORT) - return base; - base += RTE_CACHE_LINE_ROUNDUP(size_subport); + case e_RTE_SCHED_PORT_ARRAY_QUEUE_ARRAY: + base += RTE_CACHE_LINE_ROUNDUP(size_bmp_array); - if (array == e_RTE_SCHED_PORT_ARRAY_PIPE) - return base; - base += RTE_CACHE_LINE_ROUNDUP(size_pipe); + case e_RTE_SCHED_PORT_ARRAY_BMP_ARRAY: + base += RTE_CACHE_LINE_ROUNDUP(size_pipe_profiles); - if (array == e_RTE_SCHED_PORT_ARRAY_QUEUE) - return base; - base += RTE_CACHE_LINE_ROUNDUP(size_queue); + case e_RTE_SCHED_PORT_ARRAY_PIPE_PROFILES: + base += RTE_CACHE_LINE_ROUNDUP(size_queue_extra); - if (array == e_RTE_SCHED_PORT_ARRAY_QUEUE_EXTRA) - return base; - base += RTE_CACHE_LINE_ROUNDUP(size_queue_extra); + case e_RTE_SCHED_PORT_ARRAY_QUEUE_EXTRA: + base += RTE_CACHE_LINE_ROUNDUP(size_queue); - if (array == e_RTE_SCHED_PORT_ARRAY_PIPE_PROFILES) - return base; - base += RTE_CACHE_LINE_ROUNDUP(size_pipe_profiles); + case e_RTE_SCHED_PORT_ARRAY_QUEUE: + base += RTE_CACHE_LINE_ROUNDUP(size_pipe); - if (array == e_RTE_SCHED_PORT_ARRAY_BMP_ARRAY) - return base; - base += RTE_CACHE_LINE_ROUNDUP(size_bmp_array); + case e_RTE_SCHED_PORT_ARRAY_PIPE: + base += RTE_CACHE_LINE_ROUNDUP(size_subport); - if (array == e_RTE_SCHED_PORT_ARRAY_QUEUE_ARRAY) + case e_RTE_SCHED_PORT_ARRAY_SUBPORT: return base; - base += RTE_CACHE_LINE_ROUNDUP(size_queue_array); + } + RTE_LOG(DEBUG, SCHED, "Should not reach here. \n"); return base; }