From patchwork Sat Sep 29 08:14:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 45649 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EFFDF1B113; Sat, 29 Sep 2018 10:14:46 +0200 (CEST) Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690074.outbound.protection.outlook.com [40.107.69.74]) by dpdk.org (Postfix) with ESMTP id E51A85F35 for ; Sat, 29 Sep 2018 10:14:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S4+1vpl85n24QM73r7MQ1Z3L76ise6UPwpZWJQzy0i4=; b=QMQWbIUKegW/z9r6HVVL+qpdNCyfbupokWReD68GA0A5z4nMguG7hdNu9wyR14BMdn0Ac/QNytf6S6ArY+zMVM6seS27GK3KuozuwVW70NnOdGssjskNUW6XN4ThlPU8foTYTOjU6yUwSJPIagO2TsoRBoq83KyaBp3Hk9ufBto= Received: from BYAPR07MB5365.namprd07.prod.outlook.com (20.177.125.18) by BYAPR07MB5320.namprd07.prod.outlook.com (20.177.124.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Sat, 29 Sep 2018 08:14:29 +0000 Received: from BYAPR07MB5365.namprd07.prod.outlook.com ([fe80::2047:9647:f196:bde0]) by BYAPR07MB5365.namprd07.prod.outlook.com ([fe80::2047:9647:f196:bde0%6]) with mapi id 15.20.1143.022; Sat, 29 Sep 2018 08:14:29 +0000 From: "Mody, Rasesh" To: "dev@dpdk.org" CC: "Mody, Rasesh" , "ferruh.yigit@intel.com" , Dept-Eng DPDK Dev Thread-Topic: [PATCH 03/18] net/qede/base: add DPC sync after PF stop Thread-Index: AQHUV8xxgCPRjwaMl06D8x+eY32naQ== Date: Sat, 29 Sep 2018 08:14:28 +0000 Message-ID: <1538208822-9726-4-git-send-email-rasesh.mody@cavium.com> References: <1538208822-9726-1-git-send-email-rasesh.mody@cavium.com> In-Reply-To: <1538208822-9726-1-git-send-email-rasesh.mody@cavium.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR11CA0059.namprd11.prod.outlook.com (2603:10b6:a03:80::36) To BYAPR07MB5365.namprd07.prod.outlook.com (2603:10b6:a03:64::18) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [198.186.1.5] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR07MB5320; 6:9fh4kEi3Fg+2uTnDIlujdO5fOjH3Yh69tdvVKyfC6ccQVFnuilq01+32W5/h4uogXbmZ322RnVjAu/qeHoC2pRRdGXQutAX15KwBS+4f4NiLw7rntsVzyDGxk6uipVAzpSKGrmShXCjqPD1le/yQXYAZIbJwDnkxMWNbYweNRp44k6AybGXJySMjrI2yu4sg2Os8oFhjv2Ex1symLt7EFf83fLkF5GMB9ZW5Y1QFRi9ifQOeX9dyUNTExrXmyjR9dx5fxDN3/2p9xwoNco8H+mT9jRMVdRJJlJ7slI+HpsvHx710xbGlitvSDtqvASZFZdHn6LosiwDza19W326wFY6buKLFpTiIwzRby0I3n2CcT/+l+/FPWtsu1cFW2rgHU0PYlYzrM04Tnfvs8Ud97p2M9NGx+QmTttD2fXhyp/vF05ge1V8ymMyTyExxWgt7tF4kT0GVFr3H0UtbwLBR/Q==; 5:O56kRBhsHICWj/iLtoCyQ4pnuXpZ5KvPw5NU0XcBwqZGmzxjv43drvCamzGZAyqw97JCKO8vnQUUsJxtkxUedsVChdQzfNpa60Jp0DG0gsufaidtRXHXPElPzZ7b4Zo5ix9PS/EwuieM+pOJuXmNquPH+Hxr+6A0nUpmxjJHPOg=; 7:Mjo84JLVm0/GlTcKEhQm5ee2Hl+ZJaztpjp/s5xN6+ieHIUe+ly09sAUWd9ZcnkY0m/XVjuwA9RYRV4oPcCohSKf+UoYBb1/JQ7U0S7Ni9lmWTEwHllGJ5X9AYOxH6ZFtpR5lBqyIrvUT3zhSPejXQcS36AQygHcfK9Mvbj6T6oyDms1nCMfp9PyUplvYwTJeZab8Bg6dTkrRmmB+0M3b9Mmo/fMvubID86pT+ftnHxr9SF8cjhnkISRLjIuzMPV x-ms-office365-filtering-correlation-id: 0ccd112d-6f49-4c10-ed9c-08d625e39389 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB5320; x-ms-traffictypediagnostic: BYAPR07MB5320: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301075)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(149066)(150057)(6041310)(20161123564045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051); SRVR:BYAPR07MB5320; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5320; x-forefront-prvs: 0810818DA0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(396003)(136003)(346002)(39860400002)(199004)(189003)(97736004)(256004)(14454004)(4326008)(11346002)(2501003)(2900100001)(99286004)(54906003)(1730700003)(86362001)(68736007)(446003)(3846002)(25786009)(76176011)(5660300001)(2616005)(8676002)(305945005)(8936002)(486006)(107886003)(2351001)(26005)(2906002)(5250100002)(71190400001)(5640700003)(36756003)(6436002)(6486002)(53936002)(316002)(72206003)(386003)(105586002)(71200400001)(6916009)(102836004)(6512007)(6116002)(6506007)(7736002)(81156014)(81166006)(186003)(52116002)(476003)(478600001)(66066001)(34290500001)(106356001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5320; H:BYAPR07MB5365.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: IO2mQSok21PJlXT4QXOidFS7AbSu3/NE1pINqlozlJqeOuwu6RtAOwEZ0SE9Uok7JNNIbvJfIJaTPhrQLnBUkVlrfBRZvUHUf1hFqqCarxXSfkuh+n9RaL4uDhsN1CznMz5Xb39CyeDlDyWR8voaSd9zmlh27s2P471uhTp0pyxkSn8dJceM8mX0Q7kniI65rIB2jDtkiP5c6eoMqmmB4hrgfkL4LfkY6s5efOkOdUpuhvziDdGBPx7w7UexSo2l6cjibvggKz9JogH6v5+N7cXOfpj4n29SxQeeo8jkf90wiF3PCPAhOrhjBUujlAZ0MBCRRz9+xAUMNn0yOHpHubif+MIrocPI7wZVX6Y9S0w= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ccd112d-6f49-4c10-ed9c-08d625e39389 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2018 08:14:28.9742 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5320 Subject: [dpdk-dev] [PATCH 03/18] net/qede/base: add DPC sync after PF stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add DPC sync after stopping the physical funciton to allow clean up of asyncronous events. Post this the driver don't expect the FW to send async events. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 6 ++++++ drivers/net/qede/base/ecore_spq.c | 12 ++++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c index f09f771..4558306 100644 --- a/drivers/net/qede/base/ecore_dev.c +++ b/drivers/net/qede/base/ecore_dev.c @@ -2804,6 +2804,12 @@ enum _ecore_status_t ecore_hw_stop(struct ecore_dev *p_dev) rc2 = ECORE_UNKNOWN_ERROR; } + OSAL_DPC_SYNC(p_hwfn); + + /* After this point we don't expect the FW to send us async + * events + */ + /* perform debug action after PF stop was sent */ OSAL_AFTER_PF_STOP((void *)p_dev, p_hwfn->my_id); diff --git a/drivers/net/qede/base/ecore_spq.c b/drivers/net/qede/base/ecore_spq.c index 776c86f..1a02ba2 100644 --- a/drivers/net/qede/base/ecore_spq.c +++ b/drivers/net/qede/base/ecore_spq.c @@ -283,8 +283,10 @@ static enum _ecore_status_t ecore_spq_hw_post(struct ecore_hwfn *p_hwfn, { ecore_spq_async_comp_cb cb; - if (!p_hwfn->p_spq || (p_eqe->protocol_id >= MAX_PROTOCOL_TYPE)) + if (p_eqe->protocol_id >= MAX_PROTOCOL_TYPE) { + DP_ERR(p_hwfn, "Wrong protocol: %d\n", p_eqe->protocol_id); return ECORE_INVAL; + } cb = p_hwfn->p_spq->async_comp_cb[p_eqe->protocol_id]; if (cb) { @@ -339,10 +341,16 @@ enum _ecore_status_t ecore_eq_completion(struct ecore_hwfn *p_hwfn, { struct ecore_eq *p_eq = cookie; struct ecore_chain *p_chain = &p_eq->chain; + u16 fw_cons_idx = 0; enum _ecore_status_t rc = 0; + if (!p_hwfn->p_spq) { + DP_ERR(p_hwfn, "Unexpected NULL p_spq\n"); + return ECORE_INVAL; + } + /* take a snapshot of the FW consumer */ - u16 fw_cons_idx = OSAL_LE16_TO_CPU(*p_eq->p_fw_cons); + fw_cons_idx = OSAL_LE16_TO_CPU(*p_eq->p_fw_cons); DP_VERBOSE(p_hwfn, ECORE_MSG_SPQ, "fw_cons_idx %x\n", fw_cons_idx);