[v2] eventdev: fix port id argument in Rx adapter caps API
Checks
Commit Message
Make the ethernet port id passed into
rte_event_eth_rx_adapter_caps_get() 16 bit.
Also, update the event rx adapter test to use 16 bit
ethernet port ids.
Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit")
Cc: stable@dpdk.org
Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
v2:
* squash changes to autotest and library into a single patch (Jerin Jacob)
* add update to release notes (Jerin Jacob)
lib/librte_eventdev/rte_eventdev.h | 2 +-
lib/librte_eventdev/rte_eventdev.c | 2 +-
test/test/test_event_eth_rx_adapter.c | 6 +++---
doc/guides/rel_notes/release_18_11.rst | 4 +++-
lib/librte_eventdev/Makefile | 2 +-
5 files changed, 9 insertions(+), 7 deletions(-)
Comments
-----Original Message-----
> Date: Tue, 25 Sep 2018 14:19:12 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> Subject: [PATCH v2] eventdev: fix port id argument in Rx adapter caps API
> X-Mailer: git-send-email 1.8.3.1
>
>
> Make the ethernet port id passed into
> rte_event_eth_rx_adapter_caps_get() 16 bit.
>
> Also, update the event rx adapter test to use 16 bit
> ethernet port ids.
>
> Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
>
> v2:
> * squash changes to autotest and library into a single patch (Jerin Jacob)
> * add update to release notes (Jerin Jacob)
>
> lib/librte_eventdev/rte_eventdev.h | 2 +-
> lib/librte_eventdev/rte_eventdev.c | 2 +-
> test/test/test_event_eth_rx_adapter.c | 6 +++---
> doc/guides/rel_notes/release_18_11.rst | 4 +++-
> lib/librte_eventdev/Makefile | 2 +-
Missing version update in lib/librte_eventdev/meson.build. See version=
> 5 files changed, 9 insertions(+), 7 deletions(-)
>
> ABI Changes
> -----------
> @@ -162,7 +164,7 @@ The libraries prepended with a plus sign were incremented in this version.
> librte_distributor.so.1
> librte_eal.so.8
> librte_ethdev.so.10
> - librte_eventdev.so.4
> + + librte_eventdev.so.6
Can you send a separate standalone patch to fixup doc/guides/rel_notes/release_18_08.rst
release notes. The version(change to librte_eventdev.so.5) should have been
updated in change set in 3810ae4357.
+Thomas,
In case if he has difference in opinion on updating released release note file.
25/09/2018 11:15, Jerin Jacob:
> -----Original Message-----
> > Date: Tue, 25 Sep 2018 14:19:12 +0530
> > From: Nikhil Rao <nikhil.rao@intel.com>
> > To: jerin.jacob@caviumnetworks.com
> > CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> > Subject: [PATCH v2] eventdev: fix port id argument in Rx adapter caps API
> > X-Mailer: git-send-email 1.8.3.1
> >
> >
> > Make the ethernet port id passed into
> > rte_event_eth_rx_adapter_caps_get() 16 bit.
> >
> > Also, update the event rx adapter test to use 16 bit
> > ethernet port ids.
> >
> > Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> > Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> >
> > v2:
> > * squash changes to autotest and library into a single patch (Jerin Jacob)
> > * add update to release notes (Jerin Jacob)
> >
> > lib/librte_eventdev/rte_eventdev.h | 2 +-
> > lib/librte_eventdev/rte_eventdev.c | 2 +-
> > test/test/test_event_eth_rx_adapter.c | 6 +++---
> > doc/guides/rel_notes/release_18_11.rst | 4 +++-
> > lib/librte_eventdev/Makefile | 2 +-
>
> Missing version update in lib/librte_eventdev/meson.build. See version=
>
> > 5 files changed, 9 insertions(+), 7 deletions(-)
> >
> > ABI Changes
> > -----------
> > @@ -162,7 +164,7 @@ The libraries prepended with a plus sign were incremented in this version.
> > librte_distributor.so.1
> > librte_eal.so.8
> > librte_ethdev.so.10
> > - librte_eventdev.so.4
> > + + librte_eventdev.so.6
>
> Can you send a separate standalone patch to fixup doc/guides/rel_notes/release_18_08.rst
> release notes. The version(change to librte_eventdev.so.5) should have been
> updated in change set in 3810ae4357.
>
> +Thomas,
> In case if he has difference in opinion on updating released release note file.
I prefer such changes being atomic.
-----Original Message-----
> Date: Tue, 25 Sep 2018 11:50:06 +0200
> From: Thomas Monjalon <thomas@monjalon.net>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Cc: Nikhil Rao <nikhil.rao@intel.com>, dev@dpdk.org, stable@dpdk.org
> Subject: Re: [PATCH v2] eventdev: fix port id argument in Rx adapter caps
> API
>
>
> 25/09/2018 11:15, Jerin Jacob:
> > -----Original Message-----
> > > Date: Tue, 25 Sep 2018 14:19:12 +0530
> > > From: Nikhil Rao <nikhil.rao@intel.com>
> > > To: jerin.jacob@caviumnetworks.com
> > > CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> > > Subject: [PATCH v2] eventdev: fix port id argument in Rx adapter caps API
> > > X-Mailer: git-send-email 1.8.3.1
> > >
> > >
> > > Make the ethernet port id passed into
> > > rte_event_eth_rx_adapter_caps_get() 16 bit.
> > >
> > > Also, update the event rx adapter test to use 16 bit
> > > ethernet port ids.
> > >
> > > Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> > > Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > ---
> > >
> > > v2:
> > > * squash changes to autotest and library into a single patch (Jerin Jacob)
> > > * add update to release notes (Jerin Jacob)
> > >
> > > lib/librte_eventdev/rte_eventdev.h | 2 +-
> > > lib/librte_eventdev/rte_eventdev.c | 2 +-
> > > test/test/test_event_eth_rx_adapter.c | 6 +++---
> > > doc/guides/rel_notes/release_18_11.rst | 4 +++-
> > > lib/librte_eventdev/Makefile | 2 +-
> >
> > Missing version update in lib/librte_eventdev/meson.build. See version=
> >
> > > 5 files changed, 9 insertions(+), 7 deletions(-)
> > >
> > > ABI Changes
> > > -----------
> > > @@ -162,7 +164,7 @@ The libraries prepended with a plus sign were incremented in this version.
> > > librte_distributor.so.1
> > > librte_eal.so.8
> > > librte_ethdev.so.10
> > > - librte_eventdev.so.4
> > > + + librte_eventdev.so.6
> >
> > Can you send a separate standalone patch to fixup doc/guides/rel_notes/release_18_08.rst
> > release notes. The version(change to librte_eventdev.so.5) should have been
> > updated in change set in 3810ae4357.
> >
> > +Thomas,
> > In case if he has difference in opinion on updating released release note file.
>
> I prefer such changes being atomic.
Me too. But the offending change set(3810ae4357) is old
➜ [master][dpdk.org] $ git describe 3810ae4357
v18.05-389-g3810ae435
Do you prefer to have patch to update the release_18_08.rst file or ignore it?
>
>
25/09/2018 11:56, Jerin Jacob:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 25/09/2018 11:15, Jerin Jacob:
> > > From: Nikhil Rao <nikhil.rao@intel.com>
> > > > @@ -162,7 +164,7 @@ The libraries prepended with a plus sign were incremented in this version.
> > > > librte_distributor.so.1
> > > > librte_eal.so.8
> > > > librte_ethdev.so.10
> > > > - librte_eventdev.so.4
> > > > + + librte_eventdev.so.6
> > >
> > > Can you send a separate standalone patch to fixup doc/guides/rel_notes/release_18_08.rst
> > > release notes. The version(change to librte_eventdev.so.5) should have been
> > > updated in change set in 3810ae4357.
> > >
> > > +Thomas,
> > > In case if he has difference in opinion on updating released release note file.
> >
> > I prefer such changes being atomic.
>
> Me too. But the offending change set(3810ae4357) is old
> ➜ [master][dpdk.org] $ git describe 3810ae4357
> v18.05-389-g3810ae435
Oh, I had not understood :-)
> Do you prefer to have patch to update the release_18_08.rst file or ignore it?
Yes you can patch release_18_08.rst and release_18_11.rst with a fix
to version librte_eventdev.so.5, and Cc:stable for backport in 18.08.
Thanks
@@ -1112,7 +1112,7 @@ struct rte_event {
*
*/
int
-rte_event_eth_rx_adapter_caps_get(uint8_t dev_id, uint8_t eth_port_id,
+rte_event_eth_rx_adapter_caps_get(uint8_t dev_id, uint16_t eth_port_id,
uint32_t *caps);
#define RTE_EVENT_TIMER_ADAPTER_CAP_INTERNAL_PORT (1ULL << 0)
@@ -109,7 +109,7 @@
}
int
-rte_event_eth_rx_adapter_caps_get(uint8_t dev_id, uint8_t eth_port_id,
+rte_event_eth_rx_adapter_caps_get(uint8_t dev_id, uint16_t eth_port_id,
uint32_t *caps)
{
struct rte_eventdev *dev;
@@ -32,7 +32,7 @@ struct event_eth_rx_adapter_test_params {
static struct event_eth_rx_adapter_test_params default_params;
static inline int
-port_init_common(uint8_t port, const struct rte_eth_conf *port_conf,
+port_init_common(uint16_t port, const struct rte_eth_conf *port_conf,
struct rte_mempool *mp)
{
const uint16_t rx_ring_size = 512, tx_ring_size = 512;
@@ -94,7 +94,7 @@ struct event_eth_rx_adapter_test_params {
}
static inline int
-port_init_rx_intr(uint8_t port, struct rte_mempool *mp)
+port_init_rx_intr(uint16_t port, struct rte_mempool *mp)
{
static const struct rte_eth_conf port_conf_default = {
.rxmode = {
@@ -110,7 +110,7 @@ struct event_eth_rx_adapter_test_params {
}
static inline int
-port_init(uint8_t port, struct rte_mempool *mp)
+port_init(uint16_t port, struct rte_mempool *mp)
{
static const struct rte_eth_conf port_conf_default = {
.rxmode = {
@@ -99,6 +99,8 @@ API Changes
flag the MAC can be properly configured in any case. This is particularly
important for bonding.
+* eventdev: Type of 2nd parameter to ``rte_event_eth_rx_adapter_caps_get()``
+ has been changed from uint8_t to uint16_t.
ABI Changes
-----------
@@ -162,7 +164,7 @@ The libraries prepended with a plus sign were incremented in this version.
librte_distributor.so.1
librte_eal.so.8
librte_ethdev.so.10
- librte_eventdev.so.4
+ + librte_eventdev.so.6
librte_flow_classify.so.1
librte_gro.so.1
librte_gso.so.1
@@ -8,7 +8,7 @@ include $(RTE_SDK)/mk/rte.vars.mk
LIB = librte_eventdev.a
# library version
-LIBABIVER := 5
+LIBABIVER := 6
# build flags
CFLAGS += -DALLOW_EXPERIMENTAL_API