From patchwork Fri Sep 14 09:24:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 44713 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2679D5A6E; Fri, 14 Sep 2018 11:26:40 +0200 (CEST) Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-eopbgr730063.outbound.protection.outlook.com [40.107.73.63]) by dpdk.org (Postfix) with ESMTP id 66C0C58EC for ; Fri, 14 Sep 2018 11:26:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ic5vfZ81DrB/lgkwiQFUJNzAVosNl6mb0xcvzt5s8Ac=; b=FsRsf8HxgaiUQu5v5lZ47cDLFs2ja9BBmLob0uujlPWt+VZAckI6LfNvO1ueSCuMQQAyIyJBSoglGZQXsQQpF+efRfHnw79j/0O3K5tznVx2+OZiw58zNcSp/JEjeEuMHoyJrX901wHEw/1uQjWbJtgVsppljbcICeicmLGkfRU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from ajoseph83.caveonetworks.com.com (115.113.156.2) by BN7PR07MB4897.namprd07.prod.outlook.com (2603:10b6:406:ef::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.17; Fri, 14 Sep 2018 09:25:18 +0000 From: Anoob Joseph To: Akhil Goyal , Declan Doherty , Pablo de Lara Cc: Anoob Joseph , Jerin Jacob , Narayana Prasad , dev@dpdk.org, Akash Saxena Date: Fri, 14 Sep 2018 14:54:48 +0530 Message-Id: <1536917088-5529-4-git-send-email-anoob.joseph@caviumnetworks.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536917088-5529-1-git-send-email-anoob.joseph@caviumnetworks.com> References: <1536917088-5529-1-git-send-email-anoob.joseph@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: BM1PR0101CA0013.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::23) To BN7PR07MB4897.namprd07.prod.outlook.com (2603:10b6:406:ef::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d353c9f4-75ea-4a4a-ff2b-08d61a23fe6d X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4897; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4897; 3:9S15TohGLC3/6Wx1TnLjGQj3lVAQ/uim0ETzBscxGKH7f7xWEo5g1OIcqpVMLy2lEXUILKgfU6u7mOeO1gxHQ/zwS94wWF7uVV/PtGg2b3leD5je2FzWfAnn8fiF0LkI7sndSWlu5oaxLGVvNujHrcNE/amA/iVx+TAdlm11OW7kB6dJP+aAsmAxNBLWf9cxtxk7XmN9OFkdKolVpV78WT3kFg503L6JecYBr9mh3pQVPOqENoTGoYyi25nhBL9H; 25:hJLijzPwqw2TB5z/1bzIrik04LqMwkzpQWSyV5qoTjmAbdcY6eGwtI1Om/e2meapGlTaPmGE14pjtiNYcFevXmxaNG4/jjEz3sgHyqGivKoZ6x5bURKtyB9OEs5ryKRP4FNP/99kV6zbmPBU2fQSzV4UhtEqObn82wX7TbyT683LXIxe/2xNR+W27U65+bQy0bVJR3TypPznycxvBrFrWvDlacnG2KI4AcSks4Z+P2M6rWPdfeV5pZOf0pcf5XM2j4jmsm5VofENCUrUY7hS1qUDE/rdXJgMe1E3Gjgtp2nbTH9oq813bs5qQguKkwC+n5xFVTtacPst402xsbHLig==; 31:c+5xtUh2U4jrVvMvJ8riygsuyDZiZ6uO27zHuw73l0UOK/f8ezfSXMAQFL6vG9A2SnmadeUw0+NSSrWTfDUBkKvIj45TxmPtZFc4dFBlUbyzfP70WhX/5sGL73Opw8E373y1BXfv62LXL2kOIh39gRVH2FAdiv81nwI+fiH5kbZepC7XY7UdCdtkX/0E2rQihnNOHfou3B0jmM6BsMW/qXN53o8ukk/BfWTp6+g4pbI= X-MS-TrafficTypeDiagnostic: BN7PR07MB4897: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4897; 20:AtDtqX1m92lf9uC2f8hgCAM4Uk+BQ4Vm5H62DHwEfmX5SWWu8tN4YQAVnn56MYwJpkwmFgrz6+Ms38bF+zAoc1QcHCKly6TQgnraICo3QSlboM34Wq5IW5kVKXGYgN83rk57cKXKWOhlwLxUdbXNb10fq4N2HsqHwfpd+xxcRLlPbcC/g0nCqnvxe1UA86nHH8PsaVr7j7g1ASyCAlRK/T6VhmEDWXXH6e/7i+7OaJGGXIXwSrgbZxyLl70mmA7kwTY1BM1EZp2pBUjgEHifFTus4FHILY7cUwFdEqO9bLTZDAsA05tIBJItNVROJinrZUJYM8G0RXBKMnGN1qiLlzhp4Km7Wptw0rFk2HbulJZ5JSoUI8KFijoAuF/tbenPoGYvgYdB2HetsZXU5KSmo/Zm/LJBUhhQz2F6s3PGf9emxlZT12n1KzagkNFJw6Z06VlVgyg5fUjWDeW2B1Lj0KYmn6XegNlbwnNxK/XD4TzO/gLQq+mQsfp0Cb6oSO0kWM2vFz1GOt0RTtzg4G8uZSa5MCT5l9NRUoBnujtrb6jSkl6pVYWf6ZTCgr82Bhlnva9ZE/31+WaI0E21MIP7Ti0JickYI5K13VRtfYsRrWU=; 4:HPVy8SxO0UV5qLT5vlC9J717YNGm+qg7OdVxCIOB0MpR146lNHy7Ove4NTPES36+shvYdm5MMEg8Ocmx2ATgn0ddSflbwtr38XXJlLb+6Np4ySp2I258UInbwwNN8aJXex/urI0Z/Vcg/dwRGpBweDERVPJX0xRWX7VVmc4jUj6y439gJXAzLWnehcbwOLIrFq4cde9eoFgB6X6xVZbBwrl2/NQnlqSxo02AtjLiRVkoKHnXq12XvuytZEvHGHgJUgwqQRO8fA6pvZCiYkpGIg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(3231311)(944501410)(52105095)(149027)(150027)(6041310)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699050); SRVR:BN7PR07MB4897; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4897; X-Forefront-PRVS: 07954CC105 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39850400004)(366004)(376002)(346002)(136003)(189003)(199004)(97736004)(8936002)(53936002)(66066001)(476003)(6506007)(2906002)(11346002)(446003)(956004)(486006)(2616005)(386003)(186003)(6666003)(107886003)(3846002)(81156014)(16526019)(5660300001)(7736002)(305945005)(50226002)(8676002)(6116002)(81166006)(26005)(14444005)(72206003)(25786009)(4326008)(16586007)(42882007)(6512007)(316002)(478600001)(110136005)(68736007)(6486002)(50466002)(47776003)(36756003)(44832011)(76176011)(51416003)(52116002)(105586002)(48376002)(54906003)(106356001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4897; H:ajoseph83.caveonetworks.com.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN7PR07MB4897; 23:ykHk8lQfuQSH4gY15pxC5qCP7SKoVy7QfTloh+wJN?= bGwMm5o9FgJUoNQd7gChMQ0iXmv33mKmv414Dvb8UGusrLrFpwaLql2J7Mm7qKkTWpUz1GHI2q2U0mLG4mclePt2Ozi1uVdX5J16Cr1BNPpmJIyQo0xKJcHMAXjlwK+JZvwLTFq6M3izqtdtHlbwZILsXlMFWmsukD0BaqSlK3nvUnshyJ6P6Wn9k523C7kpL0ztktLRPXCeH+72ErAU6j5BtrVsPlT8wzZah5zeD9p6jc/sgML/AFZLyYntLFiBnlEdApD4wQ37djJJ1vicxxY0uXb417MI56IgdaqNPOUAHyElqJDxKeDudPKJ0tARFHtKJ213/EBaGNerkEGDEvOWjvJfe0f/fJqfxJtIa7+7RV91EdKmOgdWnoO0LxJAYGYVPFUbxDQrVshYqlEjx90I7B39FW1xlfM+tXGTuvJ0yykRyhV9W9EnZP2lNbRCjd+Ed2SJC4DZXEs1vqYUWLZo0qVehBcusp19XGQBJKF979aMtlzQ8Uqk/u0dsIDxIdT5je0TsoTNSNHFRfibtUU7sDnkRdeEI1UNw2p5YpabiJ7ea2t6o3S75aTZT0/G2oxm5Kt7LXPq9qs2Rchp6hV2nfBm3/btbN8t4UfUDu7W0vQtorw8Pv3AiqFtbJgeUIaO6DaT9sC3z9Ks6ZTzIUnGme147TWRrxoEWhwhGv9U6HrW8kSn4Ekfntirrhx4bSI1aZVn0rIbRgwCLkc5QqPbQC63sSJZRpp9US3b1n+t53tNf99U6Kp84/Fz5YJI4RBR/SWWAuSdhDE4YUU9WHCzXl9RKUlEq0kjt8mwBeh9bspI9rNriUyDiZ6Q+sveURbZDtFq5PqczP6FhpnA5mG9kiSoPm3+H78F4M4N1oPOrNaeglSPUTu3Oq9sfTLx9JkYdl2SP98X6gpp+pLgOc3vkYCOF5yp7Bx5ecWUw6+2GYPk/nkDRM8i/eYt0ikua/4Dd791z3v3ZJSZICcDEaelhKXqvaIi6sldAld982+3BKtI4U7TfdGwPRgDjyzAqK1HAQVt9LHnmfDQWhJJKQ4l+BVBvduUgVgOlFm91ZMXRju1b57zVdFmlE6PZbkPyNzSOuj0o0/w3jLRIATvIqpLSjX9SE4KSC1EikXWK2uiUG/AyaF1gZLBr6Gih3PtRt3OmHiqTYdRZu7Gry4hY6XvtpSePJ6XTJoOfUxEchHlWY2UhTdHm/YalKrdHaGDP4BAnh56CoXYihq5UqGQ3os X-Microsoft-Antispam-Message-Info: RQutdwA866SzfoGpI1yOqeFJaH61e8Ln3AMgNUFpETpI/4VwTQeAB+64oGHdU1RF20dHmv83DNrACOqWfzX61Ye3tnxW85OSGQF2ezQn0514/PLLZ3QsnBCpBNATFqheYRRvYC0yntv+mVnoscAzqTb2OgaIjDm1Q2hQ5s1ZbYpTqnFQ8VGiJgz9sLHxHqCTWBdWjYl9JrZO3ODyTuyUHiIQ4QnkER1GiT71CIfBBTfWFghdatD0ZbLBLwOQUYwO78FQw1wx7zlRpPm7tImargHfYremZ3J1tu82U2aDX/0YeL2VS/356Qvh7nW0KglRiCU8uXbho5SbGF0W/VbSCN+T7dakNKZdHjM1DQhBsQI= X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4897; 6:/BwMkWRQBBEEhQhlqbPuaK+GRweQOoS+ngNibN+k4DslWKpiVGqZKBVGK6MOzPQ/xNsJK2kYAg2SsRznyD9Cp5FEGL6MpHZgMuLLeGRXmnHftsrU6P+N4FsGDx3m9Gzdn+JrO8EOFVme7Pl2bozhhzx/SX0XGZ9mCA7gxt1q8tBlnAsumx4XTBJcYaNIkDfSCth52QetFpbUXkiGBmCtr6WZklIwbGGZ4aBX1+9EuYFluswxvEGiPF8RIalm3sFrlKKz3q6xY0Qh1G+iKTBnjdonRFCrfCjZv5ixkYw5MZ8qcPrYocqHiJOGuvwSr0j/7qGoEe/Lp1kO3RQ33rlLZD0dSB+TZuExakhus5v3ZgNPq9p5eHlSIq3q3+q35RpuncYCMyobqUNFfxmivbw5SiAXe+kO9wWHKDsrDBy/jiGcwjILgKZ5KLdZSTzzVXpcKfmhL5lmEYbq3pHUS7mOZA==; 5:2tglMeYb2Yzds9qiIxI3GUBfMgY/zgCEhG4Ci3YuDgr5hJx4kMo4xYHUSKxDFonX0BGkW4Xd4VT5SUCQdAsSGE5ijA8CSnICJ8VRODmqlRU66Psp0ocToLxJZSwE7Yy20kgYK8eiSgHybN55W47/+GqgbqaYfBPyf77PTAO5+f8=; 7:ZeV2CCwnaWu2wJzncHtyjS6o7+33kEeZMXu8C5n6V8HsbkX7ky5v8KasNBoifvds27eJcMAw2D+W9ZL2nL1XZrmZ4gBU/v4Ey6hMGgIEXU3wLA0F2NGMMrOEbYLQaBI+LmwuGoaKRBvFAMHHO03vXVLcoGWsfXJcolSj4gnUONTfj7H0Bsu8pM64odyC3V0x4rBC9/Hj9UkFvBtXE2gXQ0r+Eih2VOALyQSNm6O4yCXaTU43UmLp91IuDZEAa774 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2018 09:25:18.9335 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d353c9f4-75ea-4a4a-ff2b-08d61a23fe6d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4897 Subject: [dpdk-dev] [PATCH 3/3] app/test-crypto-perf: fix check for cipher IV X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" IV is not required for all ciphers. Making sure the null check is done only when 'cipher_iv_sz' is non-zero. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Akash Saxena Signed-off-by: Anoob Joseph --- app/test-crypto-perf/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c index 55d97c2..953e058 100644 --- a/app/test-crypto-perf/main.c +++ b/app/test-crypto-perf/main.c @@ -342,7 +342,9 @@ cperf_check_test_vector(struct cperf_options *opts, return -1; if (test_vec->ciphertext.length < opts->max_buffer_size) return -1; - if (test_vec->cipher_iv.data == NULL) + /* Cipher IV is only required for some algorithms */ + if (opts->cipher_iv_sz && + test_vec->cipher_iv.data == NULL) return -1; if (test_vec->cipher_iv.length != opts->cipher_iv_sz) return -1;