From patchwork Fri Sep 14 09:24:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anoob Joseph X-Patchwork-Id: 44712 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C6155B26; Fri, 14 Sep 2018 11:25:22 +0200 (CEST) Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-eopbgr730067.outbound.protection.outlook.com [40.107.73.67]) by dpdk.org (Postfix) with ESMTP id D5E0C34F3 for ; Fri, 14 Sep 2018 11:25:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AYm8dB9Cm1lYpqUjBvI1nclTLVUnpiVPEvyr6qC4zTo=; b=Bkix6G3mWl/A/Y7U2hrYW23FqTRkO1TdmdOhJcfrUQH023JEUDUI0Ikok93/LFQ50zE/IGGO92kX+K2Q3II8VadwCm+qVUxta7yWNveQyeOQ85B8NEla7wPi6m0OSCAs02AhII5P9r7ucbdME/SSn19qUhey4VPbydYOevEalRM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from ajoseph83.caveonetworks.com.com (115.113.156.2) by BN7PR07MB4897.namprd07.prod.outlook.com (2603:10b6:406:ef::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.17; Fri, 14 Sep 2018 09:25:15 +0000 From: Anoob Joseph To: Akhil Goyal , Declan Doherty , Pablo de Lara Cc: Anoob Joseph , Jerin Jacob , Narayana Prasad , dev@dpdk.org, Ayuj Verma Date: Fri, 14 Sep 2018 14:54:47 +0530 Message-Id: <1536917088-5529-3-git-send-email-anoob.joseph@caviumnetworks.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536917088-5529-1-git-send-email-anoob.joseph@caviumnetworks.com> References: <1536917088-5529-1-git-send-email-anoob.joseph@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: BM1PR0101CA0013.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::23) To BN7PR07MB4897.namprd07.prod.outlook.com (2603:10b6:406:ef::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f6e1805b-d15b-47f3-18ab-08d61a23fc81 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4897; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4897; 3:oyhp8JAy9rdRO/75vMeObx5Cua695Bl0OCeB8zImxhET7BVqYQSFHabNe/1YusnY5ue2V0o72Qxd4Fi1J6E0weLTWrBuQbX+jo+OHOnp+PZdm9MlkpEXVzsve+dLKbz9Ysh9i8ucKyUT2HBC8WU9uKImfrSeaZh6PWf/RH0bmWvHGJO25x2yJ9aK8Uz65sClYuRE7z0kSdYqowbTxB4FhxoclwcZpiHLrrCQlkn8RjABne6iq9TqKDJncDUCzLxW; 25:FvOMH0SDv9vgz/lnDTnr5TA1TDU6CslIQtGZq9Q6Wqi1bS2H5nkiBOrNud6DQF95uFZOYzkcuc55EXnpqVgub2rzy3gpu+17ebzK+t64mNGgqmh1RPsMs8b6aG3lTcjtCzE45uxqJqfZUKmQalsoQZEtWutEGtghTOoDorD8jKl467AvX1NxqgTkDqXjRL2sMYD3iK8JrqXyRHD+/AZOtvg3cwNyhezp8zGznnSavAieOcmQ7e/UWjKG1hdokD6rLwPNMPvmcKZUALhS4BBIQg2HHVP+pAXqu//HBXIcpZkvQQoV5ayHQT7ZA2g4KdpKRPhjPn98hgs76uz6Csy7NA==; 31:e1tGGcOsQelNroRj20S1pADLfM2OKvJYYlbtdeHEaISGzW5PsTmJjZWKhIHYuecN+we02fxprJ9dOnFboR1GqJfTRDqTIEFurd6afuKWritatwW+euqlX5WtfakNx398UtaTJOtPemDeUSqGMeMQ/WD3joX0VdvsMG439jSEwCEfTwkMXfMPXVHAyMtnCmPZ5Ck+H/Q5X7DgBpBnUZR9CTBu9iZG8aojSQ2Hiq7ijLI= X-MS-TrafficTypeDiagnostic: BN7PR07MB4897: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4897; 20:Z143BObwpJW9H9eiQ0cJKQLCbd+ceDJ4f6zDPT/ANLeAAtyRcS1m92ywO5uOarYZdpP4wG0PeFYOOzxrTK1UUGrBP7u3XzzTpV+evMMmIYThOlWm0f/4mHjmDJYIssqLNag11uY033aks2kUMY3RlksPfFrTaXd5nyNfgwFnbj4zWODWmrWWpkwgGMzRGNqL6tdDOV5bxekwbFQ3ZvG862qNHT/G/q9d5h9VG3n25NtNuIWmhjFXKPfTBof24E2/Vaz5Et65vcNxOavz0WsCIof39gYV3JlGUbQv7VEQPYYVFKElU6uVG7eu1k3C7phTuhEuwkYAWyzY/0G50eGy6vA14eK+QqVgd8kAHyONwe97LOm8Iobt6wM3+4ybZGpbTtjBfo3Q9XimfQsul9uKlUnOdz3DhmfvwV3ujUxMoZ5W+jQoIIK2XJJjA3tZFwrR4EoKbNsN/LdCYbjRaYOSKZEVxmsySUlUN4UihqoE9IcCJOv+jfqtcmOPiePVENFkU/DuCqVE+8fi5e0VxrmziTU1swaPv/ONpRfCxHfMGkGTjKVtjZ6kB/jiUf/0KbEiAyEnZePq3Lw0A7P/NQ/Qf5h6Stt+p+eWxLMk5YvSXb0=; 4:DZXs45zHvQ7baPu88mQnmRCqCQfBcmSvo+GLs9rmuBCqSbcI5w3CMxyH++jwKEewjHJVk4ILFGFGhlaV7dWzvG8Q46crjTXen1v3AL99wuUrlMIRTTWp8zkQnH1bC1m1H97yjgED93uAJ/tej1684fQMhMHvPndXE5tjrpem3ElWDGg3J2C4Ljnb84klzE5zSnuia2f9DC3VVqnT0EdB03snvA6AJM7d1Dniy1qdaWvr88q5qEu/3jZHJwSxijspbHhDSj0cpIisTEjFAq+gBg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(3231311)(944501410)(52105095)(149027)(150027)(6041310)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699050); SRVR:BN7PR07MB4897; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4897; X-Forefront-PRVS: 07954CC105 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39850400004)(366004)(376002)(346002)(136003)(189003)(199004)(97736004)(8936002)(53936002)(66066001)(476003)(6506007)(2906002)(11346002)(446003)(956004)(486006)(2616005)(386003)(186003)(6666003)(107886003)(3846002)(81156014)(16526019)(5660300001)(7736002)(305945005)(50226002)(8676002)(6116002)(81166006)(26005)(14444005)(72206003)(25786009)(4326008)(16586007)(42882007)(6512007)(316002)(478600001)(110136005)(68736007)(6486002)(50466002)(47776003)(36756003)(44832011)(76176011)(51416003)(52116002)(105586002)(48376002)(54906003)(106356001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4897; H:ajoseph83.caveonetworks.com.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN7PR07MB4897; 23:UY11t/+c1Bv9iCfvrDRNoVejsJlY4IlRqFK8i8u0x?= FQ8WkmYdntbRuRgdmzrHgzvwOgoXRRkVS1ymxd0dZyM6olY7ALOSlaAU5gowoSGka4Xx931ptLq5BK+sCaVsE1fKo8gMeEjSb038C0Yc/si1+rxA0WPlLXjMYXUGyj5BaKvJ/x700BVAGWy/D0WS3+pKMPU0pBnc1QSLjBMx2qjnvwN33jiWJw5GvSE8aazdV3tmGVWruoX8ZEeL++tX/LYL4fP9s29G29t3CQI4TgNWgDS7yo5fzTWabUgjSDZpU6hntP8JU7657hxMe3rUkgOTt4CNOPIBXKsxK2jhhSBJKbTktevLL4dCir7FKYGVbKKjgMk/lkjRAgWF0dFNjQMeKkcQ+oxiJ5bnk/m7lRxpc5grNZCOgDsBOCNQ12DvskJUMl4iGef4IR5RiR4zJlZcuhmYEPAbLq5P2ZURpVTR1I8bVEE1s/Y2TvSbnYtndplEM8DnjQAMLtF2/vtH2DaAgsD3oD/p7j0mDeDs0VYnWUZ5kX2eVbvn6/Sp8xdlCqeMGP7KhWfOZkDfWdjzqb66rGNP/nTV93biwLxzsXVK5aAdOGZ3xgvpP9RN5aqJUlFNqKn+dIsfbR6IbSvxV1KAh1dC+xY3+30C3b34OpC22x1PQ73C+QjqzXAZxma1A1rqTCi9onMQKITp9606geLCiAVGt9YD+vdPmfT1ma1qRPCjrqIUJfGd8aeumBfUcfMbgBt9fnuWVAZCI4W9CpxrDx4NVwAo/mZkkC8coZiMMza2G5zRIWO11ACAtyYg5dhy8Y3A5XIn1Qr8RajYFRT2wWpoEkkeSqhBVICd0mF6Ch8EmMM1m+TykGRzr+d8xGDCxhCFgFX8ivc28sPZjMlrhZHfZHR8tvxt8KnQot5N7GVcYdQCyEqpwCINK7FQs3oNenbShZs8LzNZMBAtKkJXxiDDrQ7Q5Sm62YOt8xe+xIR6CMClFvwKJCaSeD1LV68E+qstL1m9rYxxbT78S/O3vIYoSB8jvgUKF/LDEHINsFe0zKA0PoIsvbXRHK4ebcUAjGi8azooNqeP1Ub4aJJC2DTiADuYNDH8vLis7Os3kipLtzwl3K27yvJPL9v7V4lugITiop8CED8enYYN4LZ4ydBIzRu0wmNvwJHYyyqRRATY/buZf3bhNN7qFZBbQWXGeKrOVlQl/GaZaF4K3rQVYK/l1AiqQ7k/TLU7B0rugdwFJlJssAtnSCG37wJz5L/o4D6QgA/pYsd3Ne2AXJN X-Microsoft-Antispam-Message-Info: iJGZXG7Y6eBWGR5RakcyUf+bWWbMKdAwapKEn14jnkyAwO89orXs364g1x9p3wvTi24bEgBxFXXNtnEB0r1iMReoTv1mcFkd1icPhJW6UmW7XIxrVX/g7fkOVbGD4lRRrZajUbjhWlR79t5IzSkNT53KPUfF2mrB2VSSOomfX0D742s3Tct74w+fBgTUV2kQZaH52rP5y9qIPzMYawvqFSUtsSMIAwVsHyTejW9gdNNrHVf8TJD54MKG907JugTkXFAoEtvguCelJlHIC9n8EySDFg34L6ieLLN0hkK1LIVjj5PSffwPpQVt01Z3nIttCdOVL6TrciMhhDVPxjH9knnZBd73vTdRtU+PeqTShEc= X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4897; 6:mkPchT9q0dQReKxCvfugN6QRtuFzKPiFpjrq5TSszOKjN/+F7D8GF2Q3eLrqgrIYxqs/k5GQO38tITY6IIqZfK5DxvHOPBpR7xYqe8RGGfpBnEjvAnQhwBZ1Q0D4WkAfI3vvloeRBESaM94ScdBnjNTK1SxM0d2eArqLpJuhWA9GVBj0nVn8mucs7GukMpCV7Sy6kEh8yM538kfSiWXHAQCgz80UCBOaZ1CaHMijoTSg7ZnIHMoL4zw2Z0erMCoj3f8ttLvIBVn6ZQVr+cLYhWPLOC5n7mW04b6hah8QJlh1mnXf6duK4bGEb1gQLPPGJob5rYaYLT3nfYwOLUWOOm+oDUo2Oa0JzL1x8Sg5+HLVbRAzNFYZW1PFBr8ZS7Uf0iZMgIedTx2c27kCufkd7Q9aINu5VaHkzDi8rjMUk/b4Tgxu8dgAU0/LcX8JJxyaFt3YtTpoElTkKl25xZhIQg==; 5:rav/rXxHF6k5Le3iBSrmSkjTQx2V619gUSv4IWIXu5+k3W5q4zJuUdI3B7KrxkrfYT0/mY5vvDHVxyjowmgaCxspUwAIzmQhnpKlfUHT61I4u+9wnn9KvQtOgwrQ6nidfg2hLX931rSZkVshZBp9Vou/e6AothjW+i5F6pLRp8Q=; 7:/b/t/fwYykRLCBKitOxlw3vctLb6J3+EVchqOx8sJpw/gLy78K85vd+K0HjCq9yENPYs9PIFTvvkcRPAd5+QJRe7ob4gx4CJDt7HBGPTwkYBluIVnC1kFcHwAZuubCtbra7SJ2iM/4ZenH4sBrDdnu/LPbRHJB4I72GqBKTm3N1PYq+Dmvqy09Vc8/tjKOt84f8gIdvfENqRfpd4TwC9vOR4rS0ISx3LcyCzBEK7jvNAHN5rzmRp+/ckClPj8ZRw SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2018 09:25:15.8183 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f6e1805b-d15b-47f3-18ab-08d61a23fc81 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4897 Subject: [dpdk-dev] [PATCH 2/3] app/test-crypto-perf: fix check for auth key X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Authentication key is not required for all algorithms. Making sure the null check is done only when 'auth_key_sz' is non-zero. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Anoob Joseph Signed-off-by: Ayuj Verma --- app/test-crypto-perf/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c index c9f99a7..55d97c2 100644 --- a/app/test-crypto-perf/main.c +++ b/app/test-crypto-perf/main.c @@ -357,7 +357,9 @@ cperf_check_test_vector(struct cperf_options *opts, return -1; if (test_vec->plaintext.length < opts->max_buffer_size) return -1; - if (test_vec->auth_key.data == NULL) + /* Auth key is only required for some algorithms */ + if (opts->auth_key_sz && + test_vec->auth_key.data == NULL) return -1; if (test_vec->auth_key.length != opts->auth_key_sz) return -1;