diff mbox series

[1/2] eventdev: fix port id argument in Rx adapter caps API

Message ID 1536150078-89772-1-git-send-email-nikhil.rao@intel.com (mailing list archive)
State Changes Requested, archived
Delegated to: Jerin Jacob
Headers
Series [1/2] eventdev: fix port id argument in Rx adapter caps API |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Rao, Nikhil Sept. 5, 2018, 12:21 p.m. UTC 
  Make the ethernet port id passed into
rte_event_eth_rx_adapter_caps_get() 16 bit.

Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit")
Cc: stable@dpdk.org
Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
 lib/librte_eventdev/Makefile       | 2 +-
 lib/librte_eventdev/rte_eventdev.c | 2 +-
 lib/librte_eventdev/rte_eventdev.h | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Jerin Jacob Sept. 17, 2018, 2:14 p.m. UTC | #1 
-----Original Message-----
> Date: Wed, 5 Sep 2018 17:51:17 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> Subject: [PATCH 1/2] eventdev: fix port id argument in Rx adapter caps API
> X-Mailer: git-send-email 1.8.3.1
> 
> 
> Make the ethernet port id passed into
> rte_event_eth_rx_adapter_caps_get() 16 bit.
> 
> Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit")
> Cc: stable@dpdk.org
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
>  lib/librte_eventdev/Makefile       | 2 +-
>  lib/librte_eventdev/rte_eventdev.c | 2 +-
>  lib/librte_eventdev/rte_eventdev.h | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/librte_eventdev/Makefile b/lib/librte_eventdev/Makefile
> index 47f599a..ce800ea 100644
> --- a/lib/librte_eventdev/Makefile
> +++ b/lib/librte_eventdev/Makefile
> @@ -8,7 +8,7 @@ include $(RTE_SDK)/mk/rte.vars.mk
>  LIB = librte_eventdev.a
> 
>  # library version
> -LIBABIVER := 5
> +LIBABIVER := 6

Please update the 

# API Changes
# Shared Library Versions

in the doc/guides/rel_notes/release_18_11.rst file.

Since Rx adapter is still experimental, IMO, We don't need deprecation
notice.

Please squash 2/2 changes in this patch as it can create warning on type
mismatch.

With above change:
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
diff mbox series

Patch

diff --git a/lib/librte_eventdev/Makefile b/lib/librte_eventdev/Makefile
index 47f599a..ce800ea 100644
--- a/lib/librte_eventdev/Makefile
+++ b/lib/librte_eventdev/Makefile
@@ -8,7 +8,7 @@  include $(RTE_SDK)/mk/rte.vars.mk
 LIB = librte_eventdev.a
 
 # library version
-LIBABIVER := 5
+LIBABIVER := 6
 
 # build flags
 CFLAGS += -DALLOW_EXPERIMENTAL_API
diff --git a/lib/librte_eventdev/rte_eventdev.c b/lib/librte_eventdev/rte_eventdev.c
index 801810e..9040b11 100644
--- a/lib/librte_eventdev/rte_eventdev.c
+++ b/lib/librte_eventdev/rte_eventdev.c
@@ -109,7 +109,7 @@ 
 }
 
 int
-rte_event_eth_rx_adapter_caps_get(uint8_t dev_id, uint8_t eth_port_id,
+rte_event_eth_rx_adapter_caps_get(uint8_t dev_id, uint16_t eth_port_id,
 				uint32_t *caps)
 {
 	struct rte_eventdev *dev;
diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
index b6fd6ee..2966928 100644
--- a/lib/librte_eventdev/rte_eventdev.h
+++ b/lib/librte_eventdev/rte_eventdev.h
@@ -1112,7 +1112,7 @@  struct rte_event {
  *
  */
 int
-rte_event_eth_rx_adapter_caps_get(uint8_t dev_id, uint8_t eth_port_id,
+rte_event_eth_rx_adapter_caps_get(uint8_t dev_id, uint16_t eth_port_id,
 				uint32_t *caps);
 
 #define RTE_EVENT_TIMER_ADAPTER_CAP_INTERNAL_PORT (1ULL << 0)