From patchwork Thu Aug 30 05:50:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 43987 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 826F04CBD; Thu, 30 Aug 2018 07:53:20 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10072.outbound.protection.outlook.com [40.107.1.72]) by dpdk.org (Postfix) with ESMTP id 127192BF7 for ; Thu, 30 Aug 2018 07:53:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X6Pfj0nzT1AZnB+IfUCWXMZdcmrNcftM7ofdH30Jn1c=; b=HdJGYBCCy3rCIb8Ereq2SG/cZM+uDqMaNVysh5+3nSkoUruhBMNKp3yF5a4u+OpOgsHGGyGEghA5/2duIVIR/UHfihEMRXEy/FCyOTOUkcbgWD8h1hQA0Kfp0K4Omtjd0X/3azhbMJrP4kZAanqbUUFKYkI3o0HyUTL27RdZ7+s= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.143.30.134) by VI1PR0401MB2541.eurprd04.prod.outlook.com (2603:10a6:800:56::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.17; Thu, 30 Aug 2018 05:53:11 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: akhil.goyal@nxp.com Date: Thu, 30 Aug 2018 11:20:58 +0530 Message-Id: <1535608265-13323-4-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1535608265-13323-1-git-send-email-hemant.agrawal@nxp.com> References: <1535608265-13323-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.143.30.134] X-ClientProxiedBy: PN1PR0101CA0049.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:d::11) To VI1PR0401MB2541.eurprd04.prod.outlook.com (2603:10a6:800:56::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dd18cca5-0145-4a6b-b153-08d60e3cdebe X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0401MB2541; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0401MB2541; 3:C+5ndvGZb+lYjFIUKL8BZn7Wv66XZp3G4ANiZiUN55q6ecUcAjCdbArrY1CkXqxU5W1WfC4USfielq8cSflksOs6TdHkvXrHA678ok5eLBoCe5nrxE42rYyNVuSuaeYxtrQ73FuqTP79MjL+9MsOWNNCxEY+y6JtIEB/g/gQ6exLiGIZI4Fl5I7r6M9xTN3aJMxgDMHLq0MEy6wmwywJM1ZcxgvlNemR/XIx96NmWSBfVJWgMe1yzds5xJIip26t; 25:PDBfS/F2fKwzdvsG9/N/3auxpFNCXFj0OknIDuO/sB+g43QZKb8rZsnfpPCQPApdZqA16eVd1jncK5PXeBxNGBvqtpW27qup6hkrc5ULX4KsrEtoYryzkFQhHRL0ULp+bNWnlzFjBa1AKZ4QolRrMukIw/8yrS+9WuN6M0ZfvyoX9AVhfXvwa8AxYXl82zXXwyA53M+J+Jj+dcdtYzsifpQfJXm+D/tMeP/K9La/Q4XJXRRmhmVF1HANMJETuI+Kk0Nex+g5u7tozlYeaAC1ATHKjvYKz8xYd8BqFAlo+f1uDv8cB9SY4K63ISk5dPJ4BkFAE8RV0NI9pnqO8zm/+w==; 31:RHGuGFa6Gi3bqP1yheyUCGnJjVnY/n+bTPBCGzYD7XVBxe1y4SBLrdhLBVl6EIvCqVYHKS4DIHYFbHlTQ1U4NqUXjW8XRKpXnXSbGEH70Ek167RZabDrWu0ZebriUSlz8B4m3pxfBFh7REGPgJdiGqIGjG6UqV/n3BSSxAIKtMgRUoSJYFVl/CUyQAGyylQ+NYtwd0x7NJjgQu5sIoiYUCPg6C+6O2ZzIvQRvR7j/1s= X-MS-TrafficTypeDiagnostic: VI1PR0401MB2541: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0401MB2541; 20:MOnzTXpQNJ9xquJB3Yn5SqtWVYzPjXNNF9uEuwHjN12CZuX7mJfbHfGA91+3l7RW9W0aCzZs3/0t30PplTr4NtE5xJMUKPfP2gcedyTX9ia7rgnHQvSoNOtXe6aYBeaZ0CDY4ETun48/Bf9qeGry71zyzrvdpYe2OVz+3Of6XLNMIVZVvbjZ+0eFe22CXWe+2CLAv9DyYoHz031TvQTc/S2yI2EUvz44Oy4NClnrSsUmQ+dN1bYL1+o74tIoGNiuOEKBYWbzK+UZk+kAQovdBdTHesydICtsnpG4aI2tb14eimLUHWudabGjtF5q7Fe8ghmmE9+KEhEssx8htYyeye7IXBxC0BM5+4zcp3iRo43ve/gLvPL89k+FogSx/85SzxcDrTbqD3k7lwzEv7fJl8xc5BXoAkhdsFVj/UOu3BJJY3IhUMVx0a49vBOmhGVfNG/jniuy2Mr1wGSy/ZdGlAk/l0oALTvWf0bIidLgAxF8AvT2Lfxga1jNeGsZKl+f; 4:BGhioKNK5d6ZuaqPfUKMYHHcDhfpxz5uaeo6fLB0pIBOVWAQwDkLR7AuhviHwF7OeS02qOB/6xpraDXWg4hUomG0LRZnx0VjVlVrpRYlZUtGOzm010DRj+4U+4+lliD/fiXDKZTNYEuGqyb6SK4QueDV1sbfPDM5HfMnN900ak1zyqV/nczS522nFEO4vqeZMn0ppz0mCQ2fLZ9m6YloNbr3lYwP64Puaa3F8GdOMj+Fm0VAomyX0kPtXCIbOC2C7tVyC62QcUN5/uerfNTlA+UaDs7/VdqHB3SMdeW/igumqLQLoDSLwewAQ9rnym7O9VaUNwdEyNyrQMhsTz2fICLqOlTOUs8qO00g5suQzGM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192374486261705)(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301075)(3231311)(944501410)(52105095)(10201501046)(3002001)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699016); SRVR:VI1PR0401MB2541; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0401MB2541; X-Forefront-PRVS: 07807C55DC X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(396003)(346002)(39860400002)(136003)(366004)(189003)(199004)(316002)(486006)(106356001)(47776003)(16526019)(53936002)(6916009)(6666003)(186003)(26005)(386003)(5009440100003)(6506007)(52116002)(2351001)(956004)(76176011)(66066001)(446003)(51416003)(6512007)(11346002)(6486002)(16586007)(97736004)(86362001)(4326008)(44832011)(25786009)(68736007)(105586002)(2616005)(305945005)(2906002)(5024004)(14444005)(3846002)(6116002)(5660300001)(476003)(81166006)(478600001)(48376002)(8936002)(81156014)(7736002)(8676002)(50466002)(50226002)(2361001)(36756003)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0401MB2541; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0401MB2541; 23:Mdh+qwWwm1NVdc894u+D24iOIFYqToFiy+WYAH2?= NByf7Oq76QLzUkZJ9WZIkloURVYcfwvaDUFOQKh7mWeq8CKv8apQDVhMi6BGQVF+SF0T2tJ8OrRAvTS0YY2XiBABuWrdHq8uEBVNn3dBYrRIBZ1X/JlKtzLtLOkn1cLwEdWSXsTj1kgv8p8yDk6cU+RWF7b+wiYgrCvPOSE2E4ijQiLpD0O+gSyzaVot/HeKVWJNKljFpIKvmnVmYGUas5OEs/UjgzXD1t0jbENr1aM+okLry6wpk8Qm3sunL6/vHNUICMyXYYuO4q+eRiq2IEFC/PFqJeQFxsCH2xN/WP7WSEdrZy8MxhPijC4A1rQ/+GMw65TQmz9mdKcQpjkFH9/27ox9aiVK75LXx8wugsGr8N1SWAIMG831Iloww2rXWciBWmKcK383WeVkzL+DKgNDCL+3QKDSYpE9oZPdY9gLwvzaXqAqIRVZ+gau4WovzfVRPTb5qbKxIiW2x5FPASPeu3IOra0O4G5GY4MQDm/yHWKrIBl5BQ0Lmob5v/Whk94fVur4tu4FsVQE4/MF9HQL3TxSb4R1NfGSiO/CYGuVq6t6Y93TCkty82U+ySHadXwvunxwg+CzkAfpCfK8XBnAakjT0IYVFIuIhTb+xkCFoWwvDx2rWN9KlkSYs65GszM3JVINqwk13qdvSI9OHP4ctb5NLljvkqfz5jx8mIbUJbAU7EJi+6pt7ElIVLyxp7hZLjM35KHl1EVlSSgMw/2E0iSlT7KVRI/xH0pYuXYEaaTpPlvQiTt6nlh3T3xaVPVAUBiV0P2W9sCyYgC6PwGBONQrDhKBpdx2T1jKDHhiSPfJ000F9tsJ20q1lPs3I8+o6zvUB/SHYtuaB8gbzFpQFaGBnz3iXxmyv1PbH2AhLK7caFORdAELI6vSppOtgeHh9+EVpZNtv9MnSjDQrQrkAGg7RvxCypkD3iKIfd4H0h3ooRN75kOP0XjzueMrwWh4Du8bq2tOH+6ULNvU7jgDE0KBjYvJ3bOD0jYP4d98TcR1jRuU17vloVSC2gkt8nra/H2zPtOQDuVGs1g5Npy2PNvq2KbJKLmGdIL72Wxr5rUA6eWqTH5L4Tec5CgHfbQmrlKcAlRI6xl0Ut0MunC+al4jkVNNRNDICPQU2Ii4d1zGBp8yFEXoNfD2SeD7jsptzQhqqVVBmPcp0+sHAFD84Js52ctEvpS+1IcLldkeT7XnDcmHe8mJXtw+Ksy1V2KP1p4OKqtJJwv1UjHmVNwWk/gzJp2EszBlxjdB7vosVgH1OA/QQsWCZ9P+5gDcbO7c= X-Microsoft-Antispam-Message-Info: K9PzwCLn6r0pjuW6mm7y7PV/lD7f/wzANxhTvR6yiXksE9a9Za06XD6F3QbEhbDsiUat1QnOyo25jpUdPuWA1HgnZBkAizBN2/pTM2IwZEgOEjS8viFJTE/nQ+3VQaRpxtdjh5CCm3cZfF8/G55PJZVJptguFYiat6wBuD5QHROFP9O5uAvGvOx5nCc7epii0+jutPjCycXtUpYFDj4VE1eCH+VdQ1k1Wa6YoSB1o82VQkc9EamEIDn6PRoTpu0P6THyKCmvhqOF6eAm3q1VfqJTqLYlwEVd8pTv3xtxWk0mIG+U1UGqTz4myMip8xm5zSiNbVyGZs1F9Hn/kr4W03249zMfruI/IwVUY5irrgk= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0401MB2541; 6:rjS3YM6DAbM49v+VnV2cUg45l6+yN9i4XGGsrwUSMRKPvBlwAQJYVk+5TaNRqrgeNZpdOAvW4sZoHE/EEkGPRaXFQjGPhzogZSLlaZ1p5hKrLzFrS62Q2JQrqK66FcxwCW9i+fVE0Od8qICVTputWgft+FWxEC8VLM8JNud8NKRNMQBTHIEZ8rgp7JWxZA38a+xT9yUNoFvbE0K1PuncJhcibQ1RTSHlAiE40rCHquv1bNnwekq4e0To37DzY0HL6Y+sdWbXHFL2zINNsBXXaR88v2fA09FoMZN20dM5Mu+1FSfuCN6CnwOioQwWBDvopR4/aiYvjkimZlAOHPo7gkzQididb8TnVeXW4dpXVwvWG6ZLnRl4EZCBtp0FgkVIPQFCKAfa5EQ5L7dbKcGhiHQu/0LEAjjfbe4OwNho8ToQeoZlliw/iPErprEv39oMUTPlBhyM1qzNyuQ/h5PY3w==; 5:sgItxd0Q84AgAQ1AIqu+CS3mNdm++c3UJ+OSOHIEPxXEoVZcznQt3s4ojUe4w6+8qWgT3varW8gfXVucJ+v86s0h+AOlZD8sbbEjsFSK/SsrH1MmdNy8BqVcy0mKxMn1wVkBbyjrc6vSiv38yutkESttFnQUzTII6p4qn3tgjEA=; 7:d9Kh/IpV7Xgfh6ihKOndJXxwoUgR6H1bVrlyfBn89LRq+wpLEeN7r7PjbeyHiN/BOfwyemRzeG9QrcXQpkO+vjxGuKjfPxZNm5q4hkM8lpUGt2azrd2KpgLjisueOSmd3tR7Z0VA90bzprRQPKb4LXKvwKZ+QqECFVC3lxJuZ7hw5eX8bh/49nyA0iK0gEJNtYXl11CK430lFgv2DoKywI+2D3AkGUwpTJA91ZVon0iqzYTOzzkgX5KdZU1Sfp3L SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2018 05:53:11.1114 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dd18cca5-0145-4a6b-b153-08d60e3cdebe X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2541 Subject: [dpdk-dev] [PATCH 03/10] crypto/dpaa_sec: add LOCK before Rx HW queue attach X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Akhil Goyal This is to safegaurd as the session config can be done from multi-threads. Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 6 ++++++ drivers/crypto/dpaa_sec/dpaa_sec.h | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index 95f317d..35e4e3e 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.c +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include @@ -1810,7 +1811,9 @@ dpaa_sec_set_session_parameters(struct rte_cryptodev *dev, return -EINVAL; } session->ctx_pool = internals->ctx_pool; + rte_spinlock_lock(&internals->lock); session->inq = dpaa_sec_attach_rxq(internals); + rte_spinlock_unlock(&internals->lock); if (session->inq == NULL) { DPAA_SEC_ERR("unable to attach sec queue"); goto err1; @@ -2037,7 +2040,9 @@ dpaa_sec_set_ipsec_session(__rte_unused struct rte_cryptodev *dev, } else goto out; session->ctx_pool = internals->ctx_pool; + rte_spinlock_lock(&internals->lock); session->inq = dpaa_sec_attach_rxq(internals); + rte_spinlock_unlock(&internals->lock); if (session->inq == NULL) { DPAA_SEC_ERR("unable to attach sec queue"); goto out; @@ -2288,6 +2293,7 @@ dpaa_sec_dev_init(struct rte_cryptodev *cryptodev) security_instance->sess_cnt = 0; cryptodev->security_ctx = security_instance; + rte_spinlock_init(&internals->lock); for (i = 0; i < internals->max_nb_queue_pairs; i++) { /* init qman fq for queue pair */ qp = &internals->qps[i]; diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h b/drivers/crypto/dpaa_sec/dpaa_sec.h index ac6c00a..e923942 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.h +++ b/drivers/crypto/dpaa_sec/dpaa_sec.h @@ -150,6 +150,7 @@ struct dpaa_sec_dev_private { unsigned char inq_attach[RTE_DPAA_MAX_RX_QUEUE]; unsigned int max_nb_queue_pairs; unsigned int max_nb_sessions; + rte_spinlock_t lock; }; #define MAX_SG_ENTRIES 16