From patchwork Thu Jun 7 05:36:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 40705 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D39FC1B2A9; Thu, 7 Jun 2018 07:36:16 +0200 (CEST) Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 94BDA1B1D8 for ; Thu, 7 Jun 2018 07:36:15 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id d2-v6so8540638wrm.10 for ; Wed, 06 Jun 2018 22:36:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=5tpIOX6Cs/pLr25Wr46eCoH/zfli/8qT4H5DbcxvHJE=; b=k6IzGQWlz7/rhvkJy8QbY7laynShAGOdOwfxSSZmZvuKvKON+e0IO0mPLrkK3RkpkA AjXmvsIQ17WQAujn1WBApBlTuRCr8a5HwsKgjX3xVhB8xKj6bSyEgDUcSVCN2KvVYIBG +ioIMYaWAc30ZvdccqQYW5OQC3Y6rPLSduMmeqQpF0CF1mQvs10H7goA+IIrJnr6frst bzB680g3Qo7p8Z5Y/8oIzruu4txjz7hFWsiRiLwBHH0rev+AObc+u0MTrRfzLxKfOGsF hjP29mUQC1zW2CB81X+kfkATozdkvM6WsLQkZXs0hi/JoEQRaiBFNvIshd1Rg9bgZnOy kmPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5tpIOX6Cs/pLr25Wr46eCoH/zfli/8qT4H5DbcxvHJE=; b=tfWFWDzer+0mal0xhn5i4UeWxI1nzlrEsfI5Z1fPshbgIXE0I6w49EbGpaulbBEMb4 1mo4swfESTJfK2jTNvJnAV8mEf7TThXHaT6t1JHHUreiysm9ngWTmrDrKXANlLoszuqv U2n4fc0cmqE55GNZNur+ELZceTXQGXxLO+FiBGnHdUqFoirrensbQ9i2B/8BykDkfR+r 98nC/FPHsXrYYmHQMFQkgoqRBubg6/fTGhHvtfC1ASFKup7Dpp9HDpZsf96nyDgeDthD NaLgKDlx80XYA2YE+47sQzfad2B8Kz0GfD9+vxhn0vv10dAfaHviIXj28sByTTYE1Zei TOlw== X-Gm-Message-State: APt69E2O+9l6qc8DE3TdsiHcTb396tkQanFTxqV0jDV42fSMEwPg1VAH SHDIsZn7AEJ/2V+lhWr8LSasNCug4tY= X-Google-Smtp-Source: ADUXVKJVy1jtpyZ2VzSm1cXs8kMzRxt8zMXJxQDyGftUNPJBqw85l0Se5GIZsHbx5V/4c6rXTHSnDQ== X-Received: by 2002:a5d:48cd:: with SMTP id p13-v6mr383446wrs.0.1528349774978; Wed, 06 Jun 2018 22:36:14 -0700 (PDT) Received: from 6wind.com ([2a01:cb19:142:1800:b9d8:f16f:434d:6cba]) by smtp.gmail.com with ESMTPSA id t10-v6sm11427071wrq.74.2018.06.06.22.36.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Jun 2018 22:36:14 -0700 (PDT) From: David Marchand To: dev@dpdk.org Cc: ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, stable@dpdk.org Date: Thu, 7 Jun 2018 07:36:05 +0200 Message-Id: <1528349765-31471-1-git-send-email-david.marchand@6wind.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH] net/bnxt: add missing ids in xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The xstats api expects that the driver fills both values and ids for each filled entries. Fixes: bfb9c2260be2 ("net/bnxt: support xstats get/reset") Signed-off-by: David Marchand Acked-by: --- drivers/net/bnxt/bnxt_stats.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c index bbd4e78..a5d3c86 100644 --- a/drivers/net/bnxt/bnxt_stats.c +++ b/drivers/net/bnxt/bnxt_stats.c @@ -278,6 +278,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev, count = 0; for (i = 0; i < RTE_DIM(bnxt_rx_stats_strings); i++) { uint64_t *rx_stats = (uint64_t *)bp->hw_rx_port_stats; + xstats[count].id = count; xstats[count].value = rte_le_to_cpu_64( *(uint64_t *)((char *)rx_stats + bnxt_rx_stats_strings[i].offset)); @@ -286,6 +287,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev, for (i = 0; i < RTE_DIM(bnxt_tx_stats_strings); i++) { uint64_t *tx_stats = (uint64_t *)bp->hw_tx_port_stats; + xstats[count].id = count; xstats[count].value = rte_le_to_cpu_64( *(uint64_t *)((char *)tx_stats + bnxt_tx_stats_strings[i].offset)); @@ -293,6 +295,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev, } /* The Tx drop pkts aka the Anti spoof coounter */ + xstats[count].id = count; xstats[count].value = rte_le_to_cpu_64(tx_drop_pkts); count++;