From patchwork Thu May 3 10:31:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matan Azrad X-Patchwork-Id: 39299 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D12E3325F; Thu, 3 May 2018 12:32:20 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0067.outbound.protection.outlook.com [104.47.2.67]) by dpdk.org (Postfix) with ESMTP id 0C3B02BCD; Thu, 3 May 2018 12:32:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=u2tL+rcdaJJrlQpKKrdABtVg0mrcq/C0/MVoTjcl4qc=; b=novOv1+B177bwl3miTynWz1GI9N+TnPNGEcJuqpAOIe6y91jJB+iNIy3lzipGiuGxIrVKW8NsVwIEPQHXJ2fLKGktmBhGlC4qUPsDl/8iledDJlTu7lHiTDmdOvV+wcaM4BXDy8VsIK3khTqA1G2JheykrPEnVut6L+IQxNAIZI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR0501MB2665.eurprd05.prod.outlook.com (2603:10a6:3:cb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.715.22; Thu, 3 May 2018 10:32:13 +0000 From: Matan Azrad To: Wenzhuo Lu , Jingjing Wu Cc: dev@dpdk.org, stable@dpdk.org Date: Thu, 3 May 2018 10:31:45 +0000 Message-Id: <1525343508-29487-4-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.9.5 In-Reply-To: <1525343508-29487-1-git-send-email-matan@mellanox.com> References: <1525343508-29487-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: HE1PR08CA0058.eurprd08.prod.outlook.com (2603:10a6:7:2a::29) To HE1PR0501MB2665.eurprd05.prod.outlook.com (2603:10a6:3:cb::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2665; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2665; 3:nGyivA5i447iH1acNOYlpKoAQ13vIhGy5Q9oibb+ira9oQaYpM/8znepJwkTbx4V9g6pzIxVPORFJEeHlkFHix+Vn43q3odWbGhJ63uPh9r7L/2Jn/gHatYq6Ku/+N6y86TT8sup/BuX1rvmApnTNIIfRoj+fK3CJ16YkRqfIcLELXw3+D6ePYaiDAN5S0IgxuzgpWLD8VqAMcEBjxDSzxzzJiY9e7QiQMkY70Hb7qH3vPQMm7spUD4AL8lVBA0y; 25:Fp4wJu+D7RO/+yyZb5fVfANUlqUbv9E5e8tFj5/JBvRWmvOaBwZCs3NtakSZgPvTPC6KlThVgs8+0jHN6WUbfSWDsZRgE4EsjIG9Z/CvhDPpG3+lu6hYi7vAg+qHEkFurHIwrMFIo9Utggx3R7fT78fQ0CqgIjauZrTha/vhGc230WI3Gz2l2I1qZqs5DL4Q7RjElOlnAXUG/DJ9cKvlEKcSeVWt0D5UR4k0LmQCAjFoRKoS39tYZxI4Zdo+SwP93/ffoyBjqeN0jQ4DRJYox4YDz58oJdGBe7AO25QAf9iRu8B7EnqD30dr2aqouJKuBZLisf7hzsIzR5gNUx2GhQ==; 31:HuzlTzUQexma5/3uIyHNBUZ52A/q7nqzEQ3rihNNT+v7YbFfu7WON3XTVxB2h502Xb9qyK2UBUh3FwFRKVp/fCw9QwH+iD0TGvb5kEO4V4uouwdduls+XIYNOrdFBd3+CGGT/J9kBc76d2BOegqIX5LSoC7wvNiqwEcWx0JekDh5DvIxJnDt/ip4m5LNc7YITYkAvZtX2QhBYnq0+reL8hyR28Evr82VLARfprcy104= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2665: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2665; 20:vzK5TsSI4WtzEdLKlAgAXVgNpjEytXOVpMtZ18AKPgZBT+jd1rJCLO1j0iKgixJ3Rkkn1gNo2GMZYYMPEdykXkRKiQyhak6RgXyLnJkdomTei54OOdANI82E/3ESloWQZ/55RlZHCHTfwMcklwS9oOI2y1EMf+vE6ykjx4OQ7UcdE/e4VrDqtce3awT1ExE8e88rggXgczQOsGyIzT6cvTx0QOIIeB3uHIaUHRl1f56Iu7BFiu1V0EAyP79K+sF73/3fRyy6Yni7zMJwoVQYm2A+iyBH+IUrIW+3vNXAY5miRt0/DUfc8t5OnpDD03UPXzUx6X62RpyjnyIUOTYDwBpC6c+JVX6XtDF+hj416iASjca2tsp+OBNCB9hLZaHyEtjk5Dr1TprB1LW92Cz6siD3Dl1KqubJY89ta924pVreRUerle0F8eIQUtuw22uFd2HQDuI/9Ob3zpJU6tySrdhJRLyruRblexoF5IAh6xzSH/j+2mJAElusm3V9Tzvo; 4:6hgVzE1t8FSKo7pxPIruonWvvNLZY0rRgaF9ojmWC+otsPGOeCJBi3rsV+R7n/fFduUWN3AznL/0uIOSzEjJVLyr03L11XJMCOKUFmird/QjQBf+Hf/Jgs4rW/Xxr5D1C+D9nDsSTeVX4pMQ32Fa4t8uza+8ZP9rxchLszJV2IHHmfSce4IFcPLeVa+SzZ/VjrRN8Gf5u7ReJYRBUWv/t728v2KC7j6wNGffYTDafm3HSqUfkodSKXTuLErP1m89J9MCf0taBhaXGI2L4buR9A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:HE1PR0501MB2665; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2665; X-Forefront-PRVS: 066153096A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(346002)(376002)(39380400002)(39860400002)(396003)(189003)(199004)(97736004)(47776003)(316002)(52116002)(51416003)(36756003)(7696005)(86362001)(25786009)(16586007)(110136005)(68736007)(5660300001)(2906002)(8676002)(81166006)(81156014)(8936002)(66066001)(53936002)(3846002)(6666003)(26005)(305945005)(33026002)(11346002)(69596002)(186003)(106356001)(386003)(50226002)(486006)(55016002)(105586002)(4326008)(6116002)(7736002)(76176011)(446003)(478600001)(476003)(21086003)(59450400001)(48376002)(50466002)(2616005)(956004)(16526019); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2665; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2665; 23:j5BZ+VcMjVOzIFEfdhjvF7S6yxU41piVpCL/+Ez?= VLbKvPj+VRU/ETar5ZI3uwwV2daO0f/fScMfaBTujZKDM1R23ldbhyW+fxti6IMFOyoKOwQ4/NAPIle1nx9Q7etFlcoaL4xKA/uVPCrbE+dWuUJ9sBRRrs8mSpavwQDtzBG40dn662MO9tHtkHmFn1G6F9a9FxwyVj3vLKoqSX31aPYVn91e8K0PPOyfJxt2seNzbtXosd5GQjo+OrGdndnv9zHcxQaxESJZtQ5eoww2Q9Sb3GPiOsIv6QVp509Obf8c1l3rPF9R8sYk1repeZDByNPqRprKnzYQ0+orCPVGR4PmltVlr3EtQ1BJZGxcP7zDChobuFNjL8lGDOh0nhI5GlQG+FrLNcJ20rWUp0AWqXufNoJTijPb/1Aj8CWXrm9ndGg+8xN0/djNfWZj5UZVkHerKQTGSROhBNxzJIu/FlnCdleDO4JyCq/GSXFajmxjoYSopo5SS6sfNDXv3Ne+OlV3ATrf/7MKNxJfDnViidxFYH6JsgRIqejaj5m4Ip4pIoLYJXSiYr7LGqHo4j/S/uumKznFmyGXQyG6wMS34CzZ4xjoBTel9/r5uom2zQmw1iA3bKtIb04lDW2YNpDpzT4nCQRE2M6f10WInwJ3qQDnH5EMNUQW082d0J+WxES5Z9XEBD8ba1E5VNFcODjdY2iCeO2YvjkdkvQAv8Kq86SSr0u9gtrg/rX50a3DO9jymKYD/7cqPrXpwwLuG361hnSsjiVz4w5ukGMCiankzy6DffFMYfLWor3rj2ldlbJt51cBCdTEnJwlC/5XknFdw8lzH73TY21QghzcTUaqZ/1GdjR6XS5jXw8i26/DfjTxbsmkDvL0nl1eoLL2DhMWcdPZDk7V3YCxgmNQ6n+FlUl5yjvD5nn9lC2VVor5aLGr6y+Bnxm9wtOfIWKHI7cJcHS0dsj4iN3yxmIPEx74YhfmZ0OLCKW5kpS8VBAMQ53LZOz/yESk6vCGRbnNdCJRiL8OynMW7Jxj5jWVoOlfaIgFZFxCtwJbgAPrZ1mMW7D1oxagsaGUIzcLsrGACEZstPlbVS7daVaTz4RZmlr9dlbkf6OJmYqSNQzsPGjyjlpLS/QfqzuxfxNkL2y+gh657H22EDgveQBHkf5RqUn30awRQ44FBtCwMyXKjjVqmS3Cij74pzQGsNsArqc+xx7CsI7wRr0pJMmJb5QNnEltuy7jHT2wQoTapxeWGRgRbyYg= X-Microsoft-Antispam-Message-Info: lgHZKoT5B3Wha0yFEwhU74tPKgl0zLxGiujiqG2L8EVb1iMxS/FEfdbevDUECtWfjC2QPz+4FRGZCyFgQt5lfXZyz6qcU91B9qg+6vZlm1V0lKhjamQE42tVfZnFRLhPLhnYpxPAuPyH3QErhoCvipbTQu46YRnh1QzN13gMXP0Fm+4brRJEc/wqsP9+Sf+O X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2665; 6:BEJJrml9gQdbtNYqU+OE1nEyOxH3v4FqTtfo4XRVcUB1afeYdE6GQBfrF1zRmBbtMzBhrlfqgpBZqkeQC9cKS1T/VJrEViXPDsbnm4XhsKSXDuLBpCxrUNEz9MfAX+stA+a41Ls2zIqo0hC18EorkOxN0qKqMbw/KiRGFqhD12BVtieZoHWu3I//qQPUSfDQYoStmsjoMvEvwbVJ7mKaadHdsof7UdsUqCVx+jH1JzDnC+rxXA47KDWg2PiiQ1tB49whU2t3O+AcO2gw5lDwo9/fmn3dD/X7H9myE7uPkPtcLe17HLTrU+tdkqzd/2a0LQYmjpKMsyFN57mnsW+TZCM4FPkfgYwjv1LrCPSE48mkz9JRrh1WVXiBiM/8xQb+B2SovKMqGvjfM+OX5X2zjAb5k2TxE3AjVDHRy1Y8/DUwgiJZfoC0542doiCXO2E4n6m+6DMIFiH8tFwPnOUkgg==; 5:M5zFopREFtObKZ3+EoFhPRaBwXhki9T48D+7ohF9Rb4jPHNAzz7kcF3sYr0BZu5HtH/sH1+g2VG1k9K44hxYX4ayroiu4+JTydtw4ENmniEdxX3TXCbvDjj3+o8sUHOmrA2WbLZLMyDtulSypwLyrWzij8WZMcV1yqLL2IdHvlc=; 24:iPzQzBOEQnwCFLv2QI0iDegjmHH1Tw51PqttyOd+qFDRsMPqUFzFNFIFIRXH20oU0Nl8WnJjCcE5jgN5YiF92nMEZlXcY3vP7AUA7+kWII0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2665; 7:K9i5tDcd71XGxwY6gBrJb5s0n6FX9R4XmEr7O64WGzI5XPjAczbTBzB7WBGDey9LFTQ3iCf0ygTVkpScro+ZezodgbOtEn7UgmDt8qq0HyvLsvX7ULdBlC45Vb5pZcS9NkpojkCgXRaSrQZCLG/L4oTZv+JCenL9+U9Gn28/0/Eyzd+cPpamnpivhVhsx90vWxf4HwodP65t8vwmWowEWu+10z4N21PzFfpKbX+prbTdbrUg54YOIl2fNjBXZjNj X-MS-Office365-Filtering-Correlation-Id: 06720c9d-a627-4251-2009-08d5b0e122a9 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2018 10:32:13.0776 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 06720c9d-a627-4251-2009-08d5b0e122a9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2665 Subject: [dpdk-dev] [PATCH 3/6] app/testpmd: fix forward ports Rx flush X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A port Rx queue flush is done when the packet forwarding starts in order to clean the port statistics for a new traffic session. The flush operation is wrongly called before the update of the new forward ports, and may fail due to flush operation for an invalid port configured by the old session. Move the new forward port setup to be done before the Rx queue flush. Fixes: 7741e4cf16c0 ("app/testpmd: VMDq and DCB updates") Cc: stable@dpdk.org Signed-off-by: Matan Azrad --- app/test-pmd/testpmd.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 8ac2070..1d3ede1 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1249,10 +1249,6 @@ static void eth_dev_event_callback(char *device_name, return; } - if (init_fwd_streams() < 0) { - printf("Fail from init_fwd_streams()\n"); - return; - } if(dcb_test) { for (i = 0; i < nb_fwd_ports; i++) { @@ -1272,10 +1268,11 @@ static void eth_dev_event_callback(char *device_name, } test_done = 0; + fwd_config_setup(); + if(!no_flush_rx) flush_fwd_rx_queues(); - fwd_config_setup(); pkt_fwd_config_display(&cur_fwd_config); rxtx_config_display();