From patchwork Tue Apr 24 10:17:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zijie Pan X-Patchwork-Id: 38786 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BBC831066; Tue, 24 Apr 2018 12:18:03 +0200 (CEST) Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id 6710C1DB9 for ; Tue, 24 Apr 2018 12:18:01 +0200 (CEST) Received: by mail-wr0-f180.google.com with SMTP id v60-v6so49160995wrc.7 for ; Tue, 24 Apr 2018 03:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dubzChabRrkxz6wyJyn4+q04uidhXqQreMQrazp7/Xk=; b=CWUoz/mqMk8qhemd2CjpcQ5HrGP/dp3SfWCJSPQqsH4vrWx5RIGwUuoFQhBonvDwHY FQZXqRRXvoLeq7SvwzMtEfoPPHKrstmQlyR8Pjs+VEhMKblcl0eHNAVq2M7+XfoPZRev AYeV/kVj25UODfdbm2WSn77v+WZsftlvqpDXyNeUDiVquBiQZ+V4ktIQ+EbyZTDsVbVN p8m1/z6gd6S90WUxWUxUN8u4C+b9puz46vibeRtuSwQ3YV89/EalpiHqdRio1wnXXnzv rT5cHG4nv4XLVEWVpXqKXaxTVURN+B+W7pLqDws94LmggfARiCvIEfPsGqw/Km0AmVIv 58Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dubzChabRrkxz6wyJyn4+q04uidhXqQreMQrazp7/Xk=; b=A6r6WLmjbs/tnfBUOGXsCo3VgAfERaeq8tErOmiqWeTghbDP4J8ke1kqIbRmlNHy1L I0/m0r1+2JXAo+mE8VmUJ1u/1syIH+jbgeYKHbOlEF14xR2vuoCLKIL4OteMJn5Bt7Ad 8Fu3YsrJDEb7pFgSjvoueDKXlgKy07JF6GDV1pQjRT9drFBsH0wZ1sghh88nfbhqwE6O jO1fATzhXOB8afBOkSZxDlGkNyM96bYUQrG01CmZoYxm++1wuhTm5VAo+m2MoXyczx7c e4n0bgOICROo0iCyRTGA0psnl012en4bGikUsl3fNox8eOVbPG9riZW47hIxkDegmRX8 ldrQ== X-Gm-Message-State: ALQs6tAIUwb6japVdmYp6HOGKeDF21DxWNie5XFadO0EZAWV14TABmdb ZGk87w87Hy1yxNa8+DQwg9n4xOIRjJA= X-Google-Smtp-Source: AIpwx48Af2xAMqqWRxfz0BPd6jzUd/ZZWrh94h5nCO1W0S5yaP0zSPaXNllLxMMYX5bG1IK7syjOvA== X-Received: by 2002:adf:a4da:: with SMTP id h26-v6mr18875930wrb.164.1524565080420; Tue, 24 Apr 2018 03:18:00 -0700 (PDT) Received: from cougar.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 60-v6sm12564155wrj.62.2018.04.24.03.17.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 03:17:59 -0700 (PDT) From: Zijie Pan To: dev@dpdk.org Cc: remy.horton@intel.com, ferruh.yigit@intel.com, thomas@monjalon.net, orika@mellanox.com, bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, tomasz.kantecki@intel.com, john.mcnamara@intel.com, marko.kovacevic@intel.com Date: Tue, 24 Apr 2018 12:17:21 +0200 Message-Id: <1524565044-8583-3-git-send-email-zijie.pan@6wind.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1524565044-8583-1-git-send-email-zijie.pan@6wind.com> References: <1521630379-9554-1-git-send-email-zijie.pan@6wind.com> <1524565044-8583-1-git-send-email-zijie.pan@6wind.com> Subject: [dpdk-dev] [PATCH v4 2/5] examples/ethtool: add a new command module-eeprom X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add a new command "module-eeprom" to get the data of plugin module EEPROM. Signed-off-by: Zijie Pan Acked-by: Remy Horton --- Cc: remy.horton@intel.com Cc: orika@mellanox.com Cc: bruce.richardson@intel.com Cc: pablo.de.lara.guarch@intel.com Cc: radu.nicolau@intel.com Cc: akhil.goyal@nxp.com Cc: tomasz.kantecki@intel.com Cc: john.mcnamara@intel.com Cc: marko.kovacevic@intel.com doc/guides/sample_app_ug/ethtool.rst | 3 ++ examples/ethtool/ethtool-app/ethapp.c | 64 +++++++++++++++++++++++++++++++++ examples/ethtool/lib/Makefile | 1 + examples/ethtool/lib/rte_ethtool.c | 30 ++++++++++++++++ examples/ethtool/lib/rte_ethtool.h | 34 ++++++++++++++++++ 5 files changed, 132 insertions(+) diff --git a/doc/guides/sample_app_ug/ethtool.rst b/doc/guides/sample_app_ug/ethtool.rst index 1b79aca..47e09f6 100644 --- a/doc/guides/sample_app_ug/ethtool.rst +++ b/doc/guides/sample_app_ug/ethtool.rst @@ -44,6 +44,7 @@ they do as as follows: * ``drvinfo``: Print driver info * ``eeprom``: Dump EEPROM to file +* ``module-eeprom``: Dump plugin module EEPROM to file * ``link``: Print port link states * ``macaddr``: Gets/sets MAC address * ``mtu``: Set NIC MTU @@ -97,6 +98,8 @@ the following functions: - ``rte_ethtool_get_eeprom_len()`` - ``rte_ethtool_get_eeprom()`` - ``rte_ethtool_set_eeprom()`` +- ``rte_ethtool_get_module_info()`` +- ``rte_ethtool_get_module_eeprom()`` - ``rte_ethtool_get_pauseparam()`` - ``rte_ethtool_set_pauseparam()`` - ``rte_ethtool_net_open()`` diff --git a/examples/ethtool/ethtool-app/ethapp.c b/examples/ethtool/ethtool-app/ethapp.c index 4d62f4c..a4e64b3 100644 --- a/examples/ethtool/ethtool-app/ethapp.c +++ b/examples/ethtool/ethtool-app/ethapp.c @@ -75,6 +75,9 @@ struct pcmd_intintint_params { /* Commands taking port id and string */ cmdline_parse_token_string_t pcmd_eeprom_token_cmd = TOKEN_STRING_INITIALIZER(struct pcmd_intstr_params, cmd, "eeprom"); +cmdline_parse_token_string_t pcmd_module_eeprom_token_cmd = + TOKEN_STRING_INITIALIZER(struct pcmd_intstr_params, cmd, + "module-eeprom"); cmdline_parse_token_string_t pcmd_mtu_token_cmd = TOKEN_STRING_INITIALIZER(struct pcmd_intstr_params, cmd, "mtu"); cmdline_parse_token_string_t pcmd_regs_token_cmd = @@ -298,6 +301,54 @@ struct pcmd_intintint_params { static void +pcmd_module_eeprom_callback(void *ptr_params, + __rte_unused struct cmdline *ctx, + __rte_unused void *ptr_data) +{ + struct pcmd_intstr_params *params = ptr_params; + struct ethtool_eeprom info_eeprom; + uint32_t module_info[2]; + int stat; + unsigned char bytes_eeprom[EEPROM_DUMP_CHUNKSIZE]; + FILE *fp_eeprom; + + if (!rte_eth_dev_is_valid_port(params->port)) { + printf("Error: Invalid port number %i\n", params->port); + return; + } + + stat = rte_ethtool_get_module_info(params->port, module_info); + if (stat != 0) { + printf("Module EEPROM information read error %i\n", stat); + return; + } + + info_eeprom.len = module_info[1]; + info_eeprom.offset = 0; + + stat = rte_ethtool_get_module_eeprom(params->port, + &info_eeprom, bytes_eeprom); + if (stat != 0) { + printf("Module EEPROM read error %i\n", stat); + return; + } + + fp_eeprom = fopen(params->opt, "wb"); + if (fp_eeprom == NULL) { + printf("Error opening '%s' for writing\n", params->opt); + return; + } + printf("Total plugin module EEPROM length: %i bytes\n", + info_eeprom.len); + if (fwrite(bytes_eeprom, 1, info_eeprom.len, + fp_eeprom) != info_eeprom.len) { + printf("Error writing '%s'\n", params->opt); + } + fclose(fp_eeprom); +} + + +static void pcmd_pause_callback(void *ptr_params, __rte_unused struct cmdline *ctx, void *ptr_data) @@ -664,6 +715,18 @@ static void pcmd_vlan_callback(__rte_unused void *ptr_params, NULL }, }; +cmdline_parse_inst_t pcmd_module_eeprom = { + .f = pcmd_module_eeprom_callback, + .data = NULL, + .help_str = "module-eeprom \n" + " Dump plugin module EEPROM to file", + .tokens = { + (void *)&pcmd_module_eeprom_token_cmd, + (void *)&pcmd_intstr_token_port, + (void *)&pcmd_intstr_token_opt, + NULL + }, +}; cmdline_parse_inst_t pcmd_pause_noopt = { .f = pcmd_pause_callback, .data = (void *)0x01, @@ -816,6 +879,7 @@ static void pcmd_vlan_callback(__rte_unused void *ptr_params, cmdline_parse_ctx_t list_prompt_commands[] = { (cmdline_parse_inst_t *)&pcmd_drvinfo, (cmdline_parse_inst_t *)&pcmd_eeprom, + (cmdline_parse_inst_t *)&pcmd_module_eeprom, (cmdline_parse_inst_t *)&pcmd_link, (cmdline_parse_inst_t *)&pcmd_macaddr_get, (cmdline_parse_inst_t *)&pcmd_macaddr, diff --git a/examples/ethtool/lib/Makefile b/examples/ethtool/lib/Makefile index fbafa6d..2576910 100644 --- a/examples/ethtool/lib/Makefile +++ b/examples/ethtool/lib/Makefile @@ -25,6 +25,7 @@ SRCS-y := rte_ethtool.c CFLAGS += -O3 CFLAGS += $(WERROR_FLAGS) +CFLAGS += -DALLOW_EXPERIMENTAL_API ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y) diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c index d519a50..cb3dfa5 100644 --- a/examples/ethtool/lib/rte_ethtool.c +++ b/examples/ethtool/lib/rte_ethtool.c @@ -178,6 +178,36 @@ } int +rte_ethtool_get_module_info(uint16_t port_id, uint32_t *modinfo) +{ + struct rte_dev_module_info *info; + + info = (struct rte_dev_module_info *)modinfo; + return rte_eth_dev_get_module_info(port_id, info); +} + +int +rte_ethtool_get_module_eeprom(uint16_t port_id, struct ethtool_eeprom *eeprom, + void *words) +{ + struct rte_dev_eeprom_info eeprom_info; + int status; + + if (eeprom == NULL || words == NULL) + return -EINVAL; + + eeprom_info.offset = eeprom->offset; + eeprom_info.length = eeprom->len; + eeprom_info.data = words; + + status = rte_eth_dev_get_module_eeprom(port_id, &eeprom_info); + if (status) + return status; + + return 0; +} + +int rte_ethtool_get_pauseparam(uint16_t port_id, struct ethtool_pauseparam *pause_param) { diff --git a/examples/ethtool/lib/rte_ethtool.h b/examples/ethtool/lib/rte_ethtool.h index c962396..43adc97 100644 --- a/examples/ethtool/lib/rte_ethtool.h +++ b/examples/ethtool/lib/rte_ethtool.h @@ -154,6 +154,40 @@ int rte_ethtool_set_eeprom(uint16_t port_id, struct ethtool_eeprom *eeprom, void *words); /** + * Retrieve the type and size of plugin module EEPROM + * + * @param port_id + * The port identifier of the Ethernet device. + * @param modinfo + * The pointer that provides the type and size of plugin module EEPROM. + * @return + * - (0) if successful. + * - (-ENOTSUP) if hardware doesn't support. + * - (-ENODEV) if *port_id* invalid. + * - others depends on the specific operations implementation. + */ +int rte_ethtool_get_module_info(uint16_t port_id, uint32_t *modinfo); + +/** + * Retrieve the data of plugin module EEPROM + * + * @param port_id + * The port identifier of the Ethernet device. + * @param eeprom + * The pointer of ethtool_eeprom that provides plugin module eeprom + * offset and length + * @param words + * A buffer that holds data read from plugin module eeprom + * @return + * - (0) if successful. + * - (-ENOTSUP) if hardware doesn't support. + * - (-ENODEV) if *port_id* invalid. + * - others depends on the specific operations implementation. + */ +int rte_ethtool_get_module_eeprom(uint16_t port_id, + struct ethtool_eeprom *eeprom, void *words); + +/** * Retrieve the Ethernet device pause frame configuration according to * parameter attributes desribed by ethtool data structure, * ethtool_pauseparam.