From patchwork Tue Apr 10 13:32:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matan Azrad X-Patchwork-Id: 37783 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 28BDB1BA36; Tue, 10 Apr 2018 15:32:34 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00047.outbound.protection.outlook.com [40.107.0.47]) by dpdk.org (Postfix) with ESMTP id 9FA351B977; Tue, 10 Apr 2018 15:32:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=H2COcrFaHTcb5Tu5oNLj/JkroQNXMlcAE7tEXhOkMJU=; b=ZD7yo9wGTO/eqnq8XrxVMzoFvXyud0fi+qVGfPwwO4Zaztz85Q+bk22OFDqCZzbJJYKOFdJ3NDnSta546tU7/F91yDetlQmNWuT50wFterKzqBeEBu+zMU6skgs1W/aEASH3PVDlrUedJraFXBu8viyPHL51zWyD34udSoSdymw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR0501MB2668.eurprd05.prod.outlook.com (2603:10a6:3:cb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.653.12; Tue, 10 Apr 2018 13:32:28 +0000 From: Matan Azrad To: dev@dpdk.org Cc: Ferruh Yigit , stable@dpdk.org Date: Tue, 10 Apr 2018 13:32:07 +0000 Message-Id: <1523367128-32317-3-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.9.5 In-Reply-To: <1523367128-32317-1-git-send-email-matan@mellanox.com> References: <1523367128-32317-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR02CA0072.eurprd02.prod.outlook.com (2603:10a6:802:14::43) To HE1PR0501MB2668.eurprd05.prod.outlook.com (2603:10a6:3:cb::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 592864ff-45d7-434c-c708-08d59ee781d9 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2668; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2668; 3:Ab1q9r0u8cOHd039IsH06Ixsovm7Xk4mMeeC0JjIoXo1DDKrsr/KmMynw6VqP68Pt+sD+I+J6vNnbYojvjc3Q0WQEMYqyxQLCrVHaVoACs0oFyO0EwzJHT+wdR/lKLdAUjhErD8uf9sbScOG64BvZfi0wt2qA1vjG4/wEt+Ujv75rcbsXQprFDFPdhFRGIwAuKqNklh6my78aUqhCD6y1Qk4uOccTPcxbvnYnbQ6IYBua8BqJtdJQzo4CZ8eNNQN; 25:aGX8edIpBD3fiZAg9HPBftpUfNHk1VpmtK8a6bhzNmYO0q58gOTUzNFAgvuzbXHN9Mwwi1miKx4DjxFN7W/8TjgZs6WvHyNve08k6wRfeMNHaCh6OGluUG70hHjxMfrdEE8u+8P3z7Utpho1FkhiUVca4qEs3U8+Kcv7mypXV0mt/GISxFrqnpm2YyRFy7bt4X8V6pjrWLCqdsSBS0byOKu50ptvtnsdYD0LXSGGZdCHdScvKM9TBcuD3/XouueC0A7l3VuvBlOFP3OvqHmGoM2v8Zk2ZNO0jztwiFK51pVYSZRfx6g36NIMmR5pu2aLKkompJpcdn7CfmaNGXz2gw==; 31:4EiD1zY+0vuEq17B+fgaAlYCOmemVEUBAGtG2o9PdTbgD3nYsYPv6ziffWl/goLJS6jYaJORQYCoh3brJZCm6+DfgZv2tooU/TRJIG8rT/ekE6HroB7BBOEQpz19+XHA6TyOQz0Lq44rosoIARnJJlu/qOsR0jGLB9qTGodq3UfizXeF8zh6cSt0YDQk2oWfMrvSxHtlfyFKwyVXgBYLl7Xt9YZLnGW7pbzaklkBmnw= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2668: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2668; 20:xvQkEv6LKmX1ZCMk8Alxj3bMP5eXJfSj+PJsOHZvAN0iy6fUbdWaSGV9Og2aUW0M1N0DB6AGGVRy8S2tCCOk5CtoJWZYY+oE4FwAZyA+n6pNHX0tgNtRsK/VPA5f8heh1FttkN8U5f+/ZcyoMeO7GDt0L8eHSbdatAAWmznfiqlH+c1OCxfrUE/7wco1f9pLNTxRN5k6OcGaowYzn6W3kSS4+FQJWnP4ZRUC8rlUhyo+zp/7YSZ6gDnIGXnKuhdVcCf07PrtQeReFJkL5csDOh2Ql4WYIi4WxGcKEG/YfpkRGw9Td/CKx4v14eBFpyJdQGB5YmOkO3e8b9ckEGPEh2KIaV2sdCe6tbnbSG0LYENUWc5siInPR5iZ+3T2IhIJq5z2nf/IhelA5rH9H50NCwXgM279oxJTBURULaqap+CzaOdwuIGnIiWyWOHyydmy9Oe6A/uVGSpGwtHptx6IeN+Ubrysj4frDZ6N8zzlY8CyavRt56DATdDIbeQk70bx; 4:to3SPGIAMIgiKXtb6k5FQGE+uIGNBYXI5/SLgtHJzbkRgpGJEWZZBKowMwZVKuvK0/IRESr9ig+o0aWOeAjSYE8ktOEBuXXMU5a0hLLlcHkBFzE7fTGY81smlpwBpseuYwmEakSHhWR/xRonFFNNafM9Hsboydi3heHurJQmDxt7gXUPFfX+8/z1jE1ze+XvpuibtuznuQR1UPoN3nIW9pY5QR+pqEFge5hRyzl8sSPaJz1kWwTM+Eb60Q8nhLzAVZB7pSek5iJaaLaY2/G9+w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231221)(944501327)(52105095)(3002001)(10201501046)(6055026)(6041310)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:HE1PR0501MB2668; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2668; X-Forefront-PRVS: 0638FD5066 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(396003)(39860400002)(39380400002)(189003)(199004)(33026002)(316002)(47776003)(3846002)(5660300001)(6116002)(4326008)(48376002)(16586007)(21086003)(50466002)(105586002)(2351001)(86362001)(486006)(476003)(25786009)(2361001)(106356001)(55016002)(7696005)(68736007)(11346002)(52116002)(6916009)(2616005)(446003)(956004)(50226002)(16526019)(186003)(7736002)(2906002)(76176011)(51416003)(97736004)(6666003)(36756003)(26005)(478600001)(53936002)(59450400001)(81166006)(305945005)(8676002)(81156014)(386003)(66066001)(8936002)(69596002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2668; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2668; 23:g7P6y9pkxSJ2CXhPePIJU6oYr1XbnO+lzzlu1jM?= 89FcKXIaYWn9wGxeXDhKl8Gb6qIav5L8K2NDexgCGzd0fgb4i8/dhKGDO/py1y8spz7vDoz/OcVFGl8YgAo06U82mlu9yEFJIzWlu3FFc4j/6MUgi46BvaUIWKdL6jL9W/awiz9urVk5ot3fIyA1yAZZLlKXv4wYxOAusAueDcF7ngVVjUL4/mF99g+8/IqJKFijVh4ju9dwEvI+GD0ovtgJDp3R5n7ZZpfkJAJvoHtD17JeJpAfBbFjV3lEF9Qu6N6QPJJVzA6PknpbQS8Off6saTn0ATAnVuUol7Y+tB6xgsAiz5YWCaLjEYM04FUFaRE4m86pDmguNH608SCWh3BsA/24rEy89tNJQitcxAAbwhg62qS7B5A1eBK9TlLaqEYVsuYWH/3hJcGz+iaVFC4rROnkqoF7zatLigiUaomehNaGruWNdGk/cyl+A2MJVPs9tbdRu1Lt+dVlxPxJTxUFBO1ARvr7cvU+TBlhDTjUSAgpl9lVRKDzDNupqsY3cJhkXnwJ/8YD0XgCJ7CoCbZ4/GqnKfsI+QYX4JFkmLrBGuyczummhcX4XqUinVvj8x+IvC4ut+kZuSCYMGUHdVPfWlHZiyy8MnZ+6JJsdSMKr6eO3Qpu/4wFyLW7H+gMwfpSkb36uVny5/MHWL/yyVYKSKICGf0PYjC7w98iXGJIV1Q0AhIt4/IQMhC2raGxjH/Dsx1YnIm5W90UsjOg8ibdnXbl42+zBdSzbpNDZTLpeKyg491zPidjhyDmBWFOqbHGgxFwg4d301tq9Zlk/wXei6I03KpfPhlv8N/+LepC1BZ38T8ANIef0cKUUgW1xjZ1ZXX8hxkoVXP1qpUQqzVQQkrPB+7mrewchayk0OSI4fkF9XOlx+T/8X3H4UnknUq+oQbWxTtXyezeFVTzLfWWrJxZe7JE3iJxAm6Z18i/5xpcxjfGL6y6kC/xMZHy6DTgV4n+VCHyTIz6fi6sHK87WJL7GDMZhUyFkEwtIOkALAK2p5rKrftAQR7QROqagwtjqCSsjI1Hsib7cj6GeXmXA92FOdcKmLPu3NYKWSR5WyYCWDr+7rV/W/afh0O1ojuqB6Jm8HkVnqDyQ0i/K6dHohBsmfdzZoAgQqAwJ/Q+lygoLSHShE5Oc2PmFKP0DXtJSU7BFyylHSNgFFuVyUmfygVk97hAsLkKUAvM9S7B0Z1MKSuq6/upF6EqfUBznufTd66PfaIEU/j+G9bSaV61gnPALflNayrVCGNReYva2YA== X-Microsoft-Antispam-Message-Info: CENNIPCkBfj1aXHrEwestiSyQM11XEYzJbZ4ySkhb6uP3sg3Du9DXVCe75j5lTDqBdVlaDwpmtPW9iAtvBhYJdP6GfgvCzB1G5wq3DqRFAWBf0bv0VEHgDMv7DEDWufOPNi6qhV2xU2jQJcicf5PgsvNTKBtYwo1By4O/s/n3kbpjZtNi9IE7XgwaP9q/607 X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2668; 6:nUDXdKIzDuSUyiDpnKdLnW55K4izomNCMIWQvVpdMSLq9w+mhFXppsELGafhcXej53xpo00PZMydJwKtkC6UynyaW7qmtdNxvY3BKt4qJjHe7IiFWLXiBWzuiamHo2++6iWEVjHJytB8JjZEUruiElFlD1hasgT/KU9pLQLBKtyY0Oz4BpoP8Zllzo62vVozwlLQDpQvZjmkrgBUYETOt2UfotkqgfB4kw1IQCGPRN2VLxtInezN+FxuBKd3XEXabXM3cay0UEJ59FwCw6EMlOdSapSeQwK/c9ztlTNp+Z/xlySVliewBI6E1vMROnA2ALI3JbxCqcAGsF2HT/j6nTk0jdOz3IwkMx8Jx7SnYE9M6BPWp+aKAU8B/ybufP1ZFAMLfAJizNc4XLYW6DR9h2E+Njqrz8cBY1LTE7s9YCCMTyUzWRk0wkZqQGeb64OCfFGfWTSxi/iKEdr3QqQl7w==; 5:4zZYvtMAMLDz2FYdT+0CZsOA0nC1PuUIWHI3IMwVYjKTwr6kuZJdOoLWhXYoCJQUcd/nXXiktaGmkk1IDE616/hoXzcUCaazUumW25e826OPFOwFUt5r90JoqnpkrzKZpCQXiRpTPvuoVg83OglI3pLA1JPshzSGTBid+igWf1w=; 24:FoTiF9X+NYC1nzquTUT2RlBWBDoWVb/9rAVRL8p7YBBDEgd/UaWQcjUm/sPk6Oc62V8o33c9vktPhkidGShjoZnipMhITjduMwD5Qz8wQPk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2668; 7:Nw73BglumIP/3kGPRZVFkxMuH0q/mw5IBCkx3fFPI5/eiG4a8lVLQfwRAYG5MlBGtxQVmb3nG8dFusOg2g7BmDO/zs41t7qei8o11+z69kurF0dQT26oUUdNTgLM1I3b+Hv/lqo8DNyCTk1o71V6+/X7WO7pSGYG6QwxTsCQ83cyqV4Bx8xp5oUjpVicNegOeocB0JhWN0zcCtyJ0e66OLuev06bJT486SEd9HpQ0bcrccwDFADpYsPTKAJt8kic X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2018 13:32:28.8460 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 592864ff-45d7-434c-c708-08d59ee781d9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2668 Subject: [dpdk-dev] [PATCH 2/3] net/vdev_netvsc: add check for specifying by 1 way X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There are now 2 ways to specify a netvsc device by the EAL command line - either by the interface name or by the MAC address. The user should not specify a netvsc device using more than 1 way, Thus, if a device is specified in more than 1 way, the driver stops to probe it. Validate it in the driver initialization. Cc: stable@dpdk.org Signed-off-by: Matan Azrad --- drivers/net/vdev_netvsc/vdev_netvsc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index d2c41a5..018ffae 100644 --- a/drivers/net/vdev_netvsc/vdev_netvsc.c +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c @@ -702,6 +702,11 @@ static LIST_HEAD(, vdev_netvsc_ctx) vdev_netvsc_ctx_list = rte_kvargs_free(kvargs); return 0; } + if (specified > 1) { + DRV_LOG(ERR, "More than one way used to specify the netvsc" + " device."); + goto error; + } rte_eal_alarm_cancel(vdev_netvsc_alarm, NULL); /* Gather interfaces. */ ret = vdev_netvsc_foreach_iface(vdev_netvsc_netvsc_probe, name, kvargs,