From patchwork Fri Mar 23 02:18:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tonghao Zhang X-Patchwork-Id: 36440 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 76ECE2BCD; Fri, 23 Mar 2018 03:19:07 +0100 (CET) Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) by dpdk.org (Postfix) with ESMTP id 65B6B2B9C for ; Fri, 23 Mar 2018 03:19:06 +0100 (CET) Received: by mail-pf0-f195.google.com with SMTP id y186so4171080pfb.2 for ; Thu, 22 Mar 2018 19:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=yFZD0dLF0m3b4swOeQf20wI4k08ohJVIUqUfL4bqDpg=; b=hMPiu4G4ruu9cTlkvC85jfL6J5NeaafJh04SG9Sz5ojjF7s98/AnQB70zQ+KtQ6OsZ El+vOy4NmCb5h2jFik60OqVpgAFNTgIvlhyyfyFaLCTA5Z8vBALIEM0eqG8mhchzYoT5 ICyryGvn331LYTh4Fw5My+8ZKaD42zREQSfiPJ6pCMbbcHPOE3o55HTOKApqf0NnBPNh Lffx2OHnB7m5azbTD3vx8VC7ojWole5liN5/uIiDxA+LZuC8mn9UL2eAc/J6GGkkWwbZ YGQPFvq5mVijJZUGGW36dI0uR2/MeuOki+Unyth7UTYwbl5atdL+DhvOmEg9PSjNLBOo X4KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yFZD0dLF0m3b4swOeQf20wI4k08ohJVIUqUfL4bqDpg=; b=WOsMY97ZvwHyv6wr/twEMoBMLBp+Xk0GXbW6BvRE4Kp9f/9wNDQEa+Gid4798O34vK zx2pjM3dg7oPsdarB/FTygZiKlghNajAmLazO5ILwH5HD9ENAjTybdsUQGm1QM2aM+pC W8Xp7JR+V4/ZHFt4lVEGrqt5zXU4WQ/8hD0vzD39XP7AFib8colkvy0q9/AGadFOkNX0 FFuzAIXvA2fNQNCnB+vJ4yPucUhsLbAxGlvh+b5hk9PLBS46qZraJz7/K6cdWIw6KyMI UqWDfS876rNS07kBMrMEICA0MFKP0vueGFkGRmJ1raW98Fuzki36T5B4Ozk2rExSxR7I fs0g== X-Gm-Message-State: AElRT7HyEbSPr7ZoerJb7raOBpI/pYydECEKoiz+Xj9y2qwcYhX7DRZj t6IFMd0bdEnBgi3Yftw9Lys= X-Google-Smtp-Source: AG47ELv+BHAW45eKcPvdfM0vzRC7VQHai9Y7nLDZgwkrJt/HiWpc7+20WjAOseNal4uyZThr8KkivQ== X-Received: by 10.98.107.138 with SMTP id g132mr4971807pfc.163.1521771545495; Thu, 22 Mar 2018 19:19:05 -0700 (PDT) Received: from local.opencloud.tech.localdomain ([13.94.31.177]) by smtp.gmail.com with ESMTPSA id u11sm218167pfh.14.2018.03.22.19.19.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Mar 2018 19:19:04 -0700 (PDT) From: xiangxia.m.yue@gmail.com To: jianfeng.tan@intel.com Cc: dev@dpdk.org, Tonghao Zhang Date: Thu, 22 Mar 2018 19:18:50 -0700 Message-Id: <1521771531-95836-1-git-send-email-xiangxia.m.yue@gmail.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-dev] [PATCH v2 1/2] vhost: make sure vhost fdset-thread created successfully X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Tonghao Zhang When first call the 'rte_vhost_driver_start', the fdset_event_dispatch thread should be created successfully. Because the vhost uses it to poll socket events for vhost server or clients. Without it, for example, vhost will not get the connection event. This patch returns err code directly when created not successful. Signed-off-by: Tonghao Zhang Reviewed-by: Jianfeng Tan --- v2: According to rte_vhost_driver_start doc, replace the err code of pthread_create with -1. --- lib/librte_vhost/socket.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c index 83befdc..8c98806 100644 --- a/lib/librte_vhost/socket.c +++ b/lib/librte_vhost/socket.c @@ -831,9 +831,11 @@ struct vhost_device_ops const * if (fdset_tid == 0) { int ret = pthread_create(&fdset_tid, NULL, fdset_event_dispatch, &vhost_user.fdset); - if (ret != 0) + if (ret != 0) { RTE_LOG(ERR, VHOST_CONFIG, "failed to create fdset handling thread"); + return -1; + } } if (vsocket->is_server)