From patchwork Tue Feb 13 15:03:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Klozik X-Patchwork-Id: 35148 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C93EC1B2D3; Tue, 13 Feb 2018 16:04:30 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6035C1B2C6 for ; Tue, 13 Feb 2018 16:04:29 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2018 07:04:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,507,1511856000"; d="scan'208";a="30415128" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga001.fm.intel.com with ESMTP; 13 Feb 2018 07:04:25 -0800 Received: from silpixa00389822.ir.intel.com (silpixa00389822.ir.intel.com [10.237.219.151]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id w1DF4PiO017278; Tue, 13 Feb 2018 15:04:25 GMT From: Martin Klozik To: Thomas Monjalon Cc: dev@dpdk.org, Martin Klozik Date: Tue, 13 Feb 2018 15:03:47 +0000 Message-Id: <1518534227-104477-1-git-send-email-martinx.klozik@intel.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH] ethdev: adjust error log level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" DPDK API does not propagate the reason of device allocation failure from rte_eth_dev_allocate() up to the DPDK application (e.g. Open vSwitch). Log level of associated log entries was changed to warning. So user can find additional details in log files also in production systems, where debug messages cannot be turned on. Signed-off-by: Martin Klozik Acked-by: Thomas Monjalon --- lib/librte_ether/rte_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index a6ce2a5..0590f0c 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -277,12 +277,12 @@ rte_eth_dev_allocate(const char *name) port_id = rte_eth_dev_find_free_port(); if (port_id == RTE_MAX_ETHPORTS) { - RTE_PMD_DEBUG_TRACE("Reached maximum number of Ethernet ports\n"); + RTE_LOG(ERR, EAL, "Reached maximum number of Ethernet ports\n"); goto unlock; } if (rte_eth_dev_allocated(name) != NULL) { - RTE_PMD_DEBUG_TRACE("Ethernet Device with name %s already allocated!\n", + RTE_LOG(ERR, EAL, "Ethernet Device with name %s already allocated!\n", name); goto unlock; }