From patchwork Tue Feb 13 08:14:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ophir Munk X-Patchwork-Id: 35144 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8E4201B2D3; Tue, 13 Feb 2018 09:14:38 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0055.outbound.protection.outlook.com [104.47.2.55]) by dpdk.org (Postfix) with ESMTP id 175461B2BB; Tue, 13 Feb 2018 09:14:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8/byhB7shuVn1Hzw2RRGwR6esW9Ak5R6kc4gqftlJFI=; b=Y7C9zhCfj7834rRWBK/x95V0aVZYV1Rp9NomA2w7aegkSNTlPl0PEI5+Qu3PjMf2TXGV6RnTqfqgrn+fFtQqQZ7j76th2Ubu/MYgEV68HJmdzKgzi2QwbGFHBdNU9nWz1eLWSq3TTCHLNA04kWBdi+4pw6+GvoMNmtWbuD9CV3k= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; Received: from mellanox.com (37.142.13.130) by VI1PR0502MB3885.eurprd05.prod.outlook.com (2603:10a6:803:c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10; Tue, 13 Feb 2018 08:14:33 +0000 From: Ophir Munk To: dev@dpdk.org, Pascal Mazon Cc: Thomas Monjalon , Olga Shern , Ophir Munk , stable@dpdk.org Date: Tue, 13 Feb 2018 08:14:25 +0000 Message-Id: <1518509665-12171-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR02CA0072.eurprd02.prod.outlook.com (2603:10a6:802:14::43) To VI1PR0502MB3885.eurprd05.prod.outlook.com (2603:10a6:803:c::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 9768471e-b772-4353-b51f-08d572b9d14f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:VI1PR0502MB3885; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0502MB3885; 3:eKx6JnjKhNcyljmmd7V6yQsbCiDXPINlFEX2uGeSOrq1Y2BMrg5yyqv/4dz6rD/cGIrkRY5tm7s/nrqlsg0HH90BtwDeLtPzCwkE5Ygaap+qKjZl43bSo2Zm7EdwLq9HqkcPNl5peovJomAq9YaIrCL3ZkH13fo9An0GTMFCW+zME9kZD9WL4/7oknkMi+0osczAzuvbJI1b0Ejcn3PKa3zrWQpn8ezs6fL0EhOIy77wkDJW7iLD2vdkVj+Wr1HL; 25:FwpOrCyGOun58k6Di7rUslsNLSvTtsm2OD3WmTGeKE0ZDNrSmtZFupgiEkT/uoK86JKUhfOQPQCEKCb0ShmJDeIheJpNy6gQ0n5Z4Z400AasFjJYjOlyLjlR2BHHP97UA/ov1qb6M21xcJ4NrkLgDhGcv3JAAIpJ6t7IOW7VAu9GnVZkSQ3/RSJRrrC+6vH1NwnHa90bNoeIJ4SFIPIQRs778dUoLMCo+5GCIblrmVLEBx8aHDrnyml4iwdPWZWt49Dhs5XXlQKHMj0JmlFLSdNh0Mb/h/8BgvbokDCtmMcin/AFYqjkc2AgbXve7Ocv1S0VuYKj6cwybNSxZ83r7w==; 31:GqQ1FUuXDjNXfqQN7872kFZXpgl8L1bZZkil85qLB6H80xYFIyDj3NyBDfSpXVBamBDsY3Bu1Fj7484cSvfmlyMh0TTkvi85FPa/QEcUFNIQz0n3s2MVxlyv5c4Lg8sO28aJMn+D2UPeSJdaZFZ1KTq2eKRtbnUYMHT4IoN4sb8ZhJi8EzjxjCPVylVcQ1CkUjAj5F6sJNHipGDIQy2V7vHUwYMX77pYjEs2tmcjMYU= X-MS-TrafficTypeDiagnostic: VI1PR0502MB3885: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0502MB3885; 20:k8X0wP6fYcTcm3SQDaJLCaXJ5enlLN/BhY5MnDuG7Nq1FdNgGby18pVytSleaNVRlvICpp6DCgr1/NDRj70AEzSeJup27wFDsdZHv1MdSnRQnPjWhrIhELpbjpv0opIYXE7j1cWyacYsle1NwuJ0tLHzjuR5MZPK9QjZGcQLw3Fl5+CSGxbhHIffi+EQT6uBPfUXKkwxMmD8lKUrfROUDAKTbqxzyhZKALDx+M5NohIsIShKrjlexodLuvXm+YvsN9fLF+HffFCGCl5uMfuwCmufOSEWTrN6pfanXJ0uJmGWC5Sz3ZjUqBR3vTm/CMDGm8Am15F02h8MnnnHTaFp66dvXzhckUaXp1luaswAYc2xHssR/Oj9ie81ZUBCWzuBdTPoQssWLFWoa2H8qxf4bCT8nJq/BhcL4y1epKLbl0C2ZLag1K8zXR0p6khIVcUQXzZ1QyH0zUhMbs9M4yh3N4GnEukNTL/AgrLs2ilYt2yB1Q2zObsS7uGiIewRp6qc; 4:9xMaa9lYgTuyFzlk4XeVR/lTRm8iWAF9ixtsFBEbhnn2QLHl1YQj0CwVOKZzJRUE6UWJi4ICiIQ47GmyOd1usxSHLDuXl3Vl+PVHAU6BudU6suobnrx8zpdH+I8vs6pnHgm/7vDzaYmmWeY4+nqedi2PeYfvwRg13mOzcxG7RV+sXywFbMGQBJGluBTlljWw+XAUNI4pw2Vh88sF+MDXf2zjbUDMiwruvz1d5tNGCmy9uLyJd1Suv92r8k1rGFjocMayxhoxTsOkF5Iquql33w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(3002001)(3231101)(2400082)(944501161)(93006095)(93001095)(10201501046)(6055026)(6041288)(20161123562045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011); SRVR:VI1PR0502MB3885; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0502MB3885; X-Forefront-PRVS: 0582641F53 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(346002)(366004)(39860400002)(396003)(376002)(199004)(189003)(16586007)(54906003)(316002)(26005)(386003)(16526019)(186003)(21086003)(36756003)(106356001)(68736007)(4326008)(25786009)(33026002)(50466002)(48376002)(7736002)(305945005)(575784001)(69596002)(86362001)(55016002)(8936002)(478600001)(97736004)(50226002)(4720700003)(6916009)(6666003)(6116002)(105586002)(3846002)(51416003)(52116002)(81166006)(81156014)(66066001)(47776003)(7696005)(53936002)(2906002)(5660300001)(8676002)(168613001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0502MB3885; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0502MB3885; 23:0dABycDpTW6WqiLPoTQwbPEWXi49MJMVuxpHh2o?= BALZMU6oYauqF308LXgR4ImhOj8hyyWwGpGwLc0We7NskUbpUE/3zMfarDHxDz/TECsTvoHnR0QtWrzNmi8bt47f70Kw53WWi4Bp6FFtmwN15gksoSCrS6rUbD8gzs1oLD7MaQgTtgQGvBuw0ImT/wJ3DuD9XzI+zkvpFpUwb8hVB5w5/lWHPyHdH5c55ftt7YDCWaQdQ010d9g89qINE2vCDsfgU5wJ/oD8ETjarAxe2J1OvtaLmGDNzxBtpnaicCCww0EjN6/VbnRamrLkDLraoHU3KcO67rXFwi2jihah+vLhO4i5qf/jVO7YaewPtgNo3WR1nhNnRtRUgLvxuN5hdyvgbadQs8BXkrjyhXIFj66dgbNpYQYIfFwYalCkCS1kwV22p3ORZr9iDbHoUgkzPwGjgg6Rfap9YFT+rHzBoX2AvmaJoVhtYZj95ElJkKb5aRJOxoO14gAv1hKy8341BKgzJSStHRPt+QaY1AYHb3/EMw7tOW7s5bnJvgZceHuzFVRVEZAAL7Hbepf6negiu/Yq2r2hU5DeXpTlhFF5702Ehox4KWQVgwNXAtiuOxQYfM7gb3VEv3jXqRKsqPI5S+IJK3LA7U1lceoF/rktmee3U8sFONWcPWWLJ2y6BadpTSHSd/ZyzXyCXtgMJaC7R9Q9OTFtS03127zEIXIc5lfRlF0Wr3UyaEeihfui4B3im8R6JHTZnUrfM4iM2q6ZD3vwpZUkGGkiW2jeMbNCZENc8UPu/n1c5ovqkfnrh9mmPZSDz+RBs8cdPlxd+FGU+iOpa1g64HUYgkuermHeYpfBp4MXiov1E9qaCXTSf7eiIja2G1D4cC3jLxVZbFcimGw/KZ0ZcaTPmqFVgPZUUQmNq7+Q0D7nvExj+FkE8erw8hDuCoprpefntSQQFyzUXUip3COKSgMHODInq9sGUcnXAg528GGC/pCUmdEnZHz55cqo7JP1cZwF5aTr4DhcMKFg8Ca3HTRhx0rQXaQTMlSndJ+lk8syIup9cSez246TTL7Txn3kRlvxNTMcBLiogcsGkcBRun0Z4MNPO6ScD9DPKg3SbS+Bv6jXIsGT8gIvvOSZfbBmPAkNhAE3oMtG0Ql58nhgiX+2NuwmyX+8tugpPGG9kBvQ3eWAoYmyszg1OmSzJYo7EuiTWETrxAP/1 X-Microsoft-Exchange-Diagnostics: 1; VI1PR0502MB3885; 6:c0F5XuAcS/pCCfdD/Egfslk4Xl48H0vHcJRlkQLepnXWYiRpuNiqvHuXrMuISB6zNmELYJo/PT0tcZPNmjEoDpqztI6kvq0OOgITg0Z0Ncx/JAUSn5SBVdgrTRde0r+hkm7FWNBOoYuUQX5ZlTHMxFEuJlJabYgD9rnVl+vW/n8Z/405q3DoJFe1fApHqsuSFAxNZjJQv6ebmDm5GBffWbq61hORCMu0Ddt7N4XquhBYFOf86kg7TumTFUh3cUkLJPomAN3zs6A33k272UamxFiswGC0/wZOW1dp6p8Zh9fltdoFXc4Idpos0SjiuiUTWTj4aAPnExw884G4R1dfsgf3sczLLvj9qUqAWMtHaao=; 5:om/Wh+7sl9Q17mluHdQfNpzqAnrATJ5il8lTNwf28NJ1OulZtAHO/yNyDJcz/xiocph2Fr8XeGvNjSQ5zV+19JvTr+Fmh+3jaLnSJmtp1rvjR/9Znki/+Hm8jQ1HOu4zcGDNW2yzZMRzcppqsZN094Ta+cX0Gy6Ex8Eb0nnmnS0=; 24:RuSShiWrbJb1mnk7k7duxZfIuhVksK7wDY8c3XbFeETHsvyypbrjzvMJfGTxPYImYiiahT6/X0ODJ04Zbrpr8V5EskO5WcvMQRMGrUrY5qE=; 7:rQt+IqjBz+axwefRQ0PqQwd0QjHfTvghqxQ/OiXM5ZxCI6MEbkglVmcHHrx65PTK/xdaqY1ckp6mKWDAr0gPs+YrubNgXP16kQ1BufX6MFSKsXKO1b6FJmpvLOTV+dxIJW3f8XyXWlKUmDrN3H6idKTpz/he/XhcnX0RQD3cCbbHeNLdVwPkXusgFvj5GLw9LfCtbrlpd6G4wNU1CdnAm3yO/u0FirhHbfSUFbVVXuXQ1BkvD+T7cfgQ1HFdekps SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2018 08:14:33.9752 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9768471e-b772-4353-b51f-08d572b9d14f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB3885 Subject: [dpdk-dev] [PATCH v2] net/tap: add CRC stripping capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" CRC stripping is executed in the kernel outside of TAP PMD scope. There is no prevention that the TAP PMD will report on Rx CRC stripping capability. In the corrupted code, TAP PMD did not report on this capability. The fix enables TAP PMD to report that Rx CRC stripping is supported. Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") Cc: stable@dpdk.org Signed-off-by: Ophir Munk --- v2: updated commit message drivers/net/tap/rte_eth_tap.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 9d39384..f09db0e 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -261,7 +261,8 @@ tap_rx_offload_get_port_capa(void) return DEV_RX_OFFLOAD_SCATTER | DEV_RX_OFFLOAD_IPV4_CKSUM | DEV_RX_OFFLOAD_UDP_CKSUM | - DEV_RX_OFFLOAD_TCP_CKSUM; + DEV_RX_OFFLOAD_TCP_CKSUM | + DEV_RX_OFFLOAD_CRC_STRIP; } static uint64_t @@ -270,7 +271,8 @@ tap_rx_offload_get_queue_capa(void) return DEV_RX_OFFLOAD_SCATTER | DEV_RX_OFFLOAD_IPV4_CKSUM | DEV_RX_OFFLOAD_UDP_CKSUM | - DEV_RX_OFFLOAD_TCP_CKSUM; + DEV_RX_OFFLOAD_TCP_CKSUM | + DEV_RX_OFFLOAD_CRC_STRIP; } static bool