From patchwork Wed Feb 7 08:24:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 35039 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E815D1B79E; Wed, 7 Feb 2018 09:24:10 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 965321B79C for ; Wed, 7 Feb 2018 09:24:08 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 4E3D98005E; Wed, 7 Feb 2018 08:24:06 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Wed, 7 Feb 2018 00:24:03 -0800 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1044.25 via Frontend Transport; Wed, 7 Feb 2018 00:24:03 -0800 Received: from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com [10.17.10.10]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id w178O2QZ024694; Wed, 7 Feb 2018 08:24:02 GMT Received: from uklogin.uk.solarflarecom.com (localhost.localdomain [127.0.0.1]) by uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id w178O2om003662; Wed, 7 Feb 2018 08:24:02 GMT From: Andrew Rybchenko To: CC: Thomas Monjalon , Neil Horman Date: Wed, 7 Feb 2018 08:24:00 +0000 Message-ID: <1517991840-3612-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.2.3 In-Reply-To: <1517492959-15104-1-git-send-email-arybchenko@solarflare.com> References: <1517492959-15104-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-MDID: 1517991848-YJajm0C09WJj Subject: [dpdk-dev] [PATCH v2] buildtools: output build failure reason to stderr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If build fails because of failed experimental check and stdout is redirected to /dev/null, it is absolutely unclear why build fails. Fixes: a4bcd61de82d ("buildtools: add script to check experimental API exports") Signed-off-by: Andrew Rybchenko Acked-by: Neil Horman --- v2: - use <<- to keep indentation of the message buildtools/check-experimental-syms.sh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-experimental-syms.sh index 7d21de3..5bc8cda 100755 --- a/buildtools/check-experimental-syms.sh +++ b/buildtools/check-experimental-syms.sh @@ -22,9 +22,11 @@ do IN_EXP=$? if [ $IN_TEXT -eq 0 -a $IN_EXP -ne 0 ] then - echo "$SYM is not flagged as experimental" - echo "but is listed in version map" - echo "Please add __rte_experimental to the definition of $SYM" + cat >&2 <<- END_OF_MESSAGE + $SYM is not flagged as experimental + but is listed in version map + Please add __rte_experimental to the definition of $SYM + END_OF_MESSAGE exit 1 fi done