From patchwork Mon Feb 5 12:48:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matan Azrad X-Patchwork-Id: 34973 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 946831B345; Mon, 5 Feb 2018 13:48:35 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0068.outbound.protection.outlook.com [104.47.1.68]) by dpdk.org (Postfix) with ESMTP id 7A1E01B2F4 for ; Mon, 5 Feb 2018 13:48:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=W6K+hdBRvFHy4lF24XkIQXmqJnDkcUx1QUNH9YatQjk=; b=erVV1OqkBEz74oTlMyFp3IphMeaXvYBoqVKxwXqSHYNAVo3v6JGUYWsLAh++vxlpL9u7HURIBanH2f+CLcrR7JggDltVotIx1tdo0au5teQRqk6ZdSr9m+PD1ZKA62uPVZyL8XS1KaIy8n/xMFBiYijb+j6ieVlQCx96LD3Z4iE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR0501MB2666.eurprd05.prod.outlook.com (2603:10a6:3:cb::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Mon, 5 Feb 2018 12:48:32 +0000 From: Matan Azrad To: Matan Azrad Cc: dev@dpdk.org Date: Mon, 5 Feb 2018 12:48:22 +0000 Message-Id: <1517834902-19874-1-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR0501CA0007.eurprd05.prod.outlook.com (2603:10a6:800:92::17) To HE1PR0501MB2666.eurprd05.prod.outlook.com (2603:10a6:3:cb::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: dd35043f-2ba2-43f1-b702-08d56c96c40b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:HE1PR0501MB2666; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2666; 3:HQoDfIF3oM4tWm+mk9YH5ZqU1ZZb4jzIG0xngdle+lgp3V5WBOzFq99gIPxA0aFq+xtfQ4ZGJe4SfHHF54jj5zPJf0VApt4URYapdp7i8Qkup8/T55O/L5kYFo8QxJwXDu17XlHF6hgQssLYi93p5rvrHFU3TMsJMuHMAhlmRLOItZIdop/RxCYHp07EBpgxrgI7628GLBYIREyXzTulpqgUIwePAzii/gYlMwSBP85dLkDsMMr8Pa8b+WvJtamO; 25:RGQ9rmt5d9IH+/XkBzkkyCQO1e4+wlNyhu5JWi0oqm8KIvjqygL+V/THa++qLQT7J7I+NFsf/X1m9Ij01eaidenFr1H52QSxTwAlW5Dv1c819leIochIrorFQ2NNyabPxaxQER4wk2jp4wwyHoQLAA77q3VCgX4qa1j+wYAVKybCD0iOTQq6vLZLOisvdtzsfGqdqgynhabgoDQECQcMEqhsakKKC9byaHyserHkVZ/abyA9LBGwin/tp6N8UgMxH/WG5yJ267YOKtxfoTQJWFRpRELOFxKNOqZ09JY7poa4My7ZRQRMnyQZn7A31wyZ9nRe6DnACmZmGLyT6u9GTQ==; 31:CHlEOWXCdtw+fHxTDNyERTsOlsdFZTFPS52QLzlanddUBp3ABOLKMSP1WHrM2KMPpI6jCMsRY/QYxgLMZsyh02OGeULMOC5pvN2SvS94UiC+E7DVa1WA9F3kMJHty96J5B5UTfG4+x3i0BZU2piiX0DCp3MVsOgEj7PdhmGo3iVDq2dRd1cMQjHdLjyygnggmzasCjI+fYlLksemEDaBoynI0LVrGt543teYwNPf0Og= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2666: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2666; 20:fdzJWtBiQKZ0KIefXPX1Z//MgkagJqVoQ10fRsN/tWN9N9Jb77/GR9r1b6cEjx1jHHZMTraEEpStpYcNuL+ssyjlNmpKGup5ZJn2JklzVt8PVh1bLK3JBEg8GJMQju2rs8MRT1OTG8WykSmjiIyuJTSdyDrezM7gwEqJKs1nXhHyqq/POATvyvC63QWgPEQ1aPeJgPA6Gkal14XCJkc2OxYycio1V3BvQh756hDmcWPqqW3zr0jtbWTSgu+8RX3NEqqrj2NUroHVFIvhrPZhyQyzWuKx9lDtgKp9Vc/HL8Dx1BgvZEv6noHxq9g3LwIRiSjSWQhA+FgSMgLzi9odxkiKHI789Hvply6Sfo0sActy6uszgZLQVJ3KSCvPZHbx8rMXo0vbcQRcTTS4kqYovE0vN14lCTT2kV/hEzC5tYSYrZSahkW3pN9INvn7vrpYTwE+tsZhdlM/ddiStyNUSgc6BhopYW4QWV9NmZ9hOPkFWuTV1FGstXYeiKvPDrtN; 4:hsWwmDwW9ES/TOY1sZ5p/JUGOtn5WnRxP6BTS5hujtbQzD3aHbBwKHsb4IBN58ZPubaLdUVbtQiIZpOTe8wlV6BjvAU48WDsOIYLBtjz9hvHW3IB6Tduuvl+OsNFWMxg5TxWWmGDU/NrhPwWV7nwFSnSeeQdbR9GO1pWNiQF54Q3EV7AOBIKQOa6ssNHoK75koEdl2XW6mwQvUXwgvYV5cMAL9XwVK2ETZqBo4MxENc70wcNKkEiElgUmA7AIRcFUmjoKf4u+hAYw55SJnjwNQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231101)(2400082)(944501161)(6055026)(6041288)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011); SRVR:HE1PR0501MB2666; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2666; X-Forefront-PRVS: 0574D4712B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(39380400002)(366004)(39860400002)(376002)(396003)(199004)(189003)(81156014)(6862004)(66066001)(21086003)(4326008)(478600001)(47776003)(6200100001)(25786009)(105586002)(37006003)(16586007)(1857600001)(97736004)(16526019)(86362001)(69596002)(386003)(7696005)(52116002)(51416003)(2906002)(7736002)(316002)(59450400001)(3846002)(6116002)(7049001)(305945005)(26005)(106356001)(55016002)(5660300001)(50466002)(4720700003)(6666003)(8676002)(81166006)(36756003)(68736007)(50226002)(33026002)(48376002)(53936002)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2666; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2666; 23:zutb4siLJGNOkIuAh19VQn5KrKa7Ta88Vj9v46A?= 5A6i2kpHq0OaBjb+y6/p3KoPJn8vz9OMzpulCTggDTCe5jqw7+KrgnqdsUKmP5Z8Qwr7ca33XasMmDmUSjGFl6RzssLOqVO+Tm2U05NKvC3Xn+qD8Bn1Y3F9d85nz/ewQi1le9XpxE/BsSTkz3Nlu1r1+PzoWWmIjG2D2WgO1gDuihdzTkDms5LosrYSfSHy0zqt9/2Of8DZ4R95TN7jc18T+N64c3yj9moLM30kopvw9vV8XyxNpFkN497txc/gbvwf06cMDB3ci51eydeVpqpxd+bqHeJMfLu805mW1dkejw6bofAjoBHenYGk3vrjUeJKYhRuNwDKzO5cuyC9NtEXFkmt2D6nuv8sf+AmgijtUGKWa1LwBH4HAbywIP3U5+yMX9LXrQYipo/eMrf9w5DegbfLYCe5jIrhRw9d6DZyRJ7+LY44Sn/zCGqKLotY8rdi6SGYGwo4nmW9FW1QydH7kdGhPoVt/VIPoH7G8H6DpFsop/HvysQtuqFhLwsY6PmGcPo08kRUTyAYnJy2WklZyZwbNqwErxsepSa4By1O1O4jdXPrpudKcpzHUVCu2oy1H4ySRBBqSz0KN2mfaWpURFdofQ89G25t7lxIR/I4Efa/BmGJkK6ZdKmmZEV/BzMIh7ApwAFutRSFDUwnowS0l1ryVm1zYR/SSkSQJwKsE3jrQblqoX3VbTprSNIQJrTeZQCrJLfVMNjm30oqALzaPmlgCOoQhxG0zLDHbT4AeJ+IcIeJd15Vm72UDBx8oVgj9i+x3TUufr4EW/iMIiTLO1SGOqlmKlRGIxwx0JCPazRPbZIRyC4cOE7o0gjWoNEQora6+LICr2r5i4PcNgxM+p2NNFofmAK7te6k2o8zxtZ46XmNIlRfJyFs2pMeWcVhHEav8Xp2mHXEM+jbIMfSkGgUE8P0hGpQEYqCnChYC7V+tQ/615hYpvTXikLCh/B3hexATLdtFRVmDrxMi2r5J+OrNs8+lyziK6Lg/mjFTfVjBchPJP4K5EckseSN+14Zfk97b0hoV5FahRW0J9q6+BZ2VaG+o8fd0jNlZYXX10B51QD+mqdTrirx5P9cwlPvibFPamSJlWTxzNpYM6zVfI/gUHu82NImW9qOILlTkmLFdpqkT81fn1cS96nq0eAFFttmebbUkANMUVVCc8pE8z/0dkVqYG8pSP2pqGO+KQw== X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2666; 6:UCiL4BhpTz+ibnE4oTBmE5s12kh9cgU5iynck6HCXXOHH8xPtHiMHwgGcBMbDshKNY0HPPFXIIiujlH2sO2o4f1WyVLZE58S38x99RyPvIK+rfvBNyZ/G/m8VY+A52j37cKmhKHzuKshwvXSnmrSnR09h2NPNtmArrs8CL+vJv98xRuNi8fO4CVLAHG1b+H9xbQ4LSAnVcG+Lvt7/MXWMQ9DHr2WP4whD0rsmioDFiZtf6nP94+rsZ/xbbvNFN69DilXxYJd889jewHmPAjHdVrErKCBLrNr1iNL2J21it3tSuXUqBHY6HnhmsBaqpZu+Ey72wX1Y2aerao8wuVWs17fFkqXXdIAKTXlpSRrG38=; 5:rnsCf6t06Ikicc11lLAJiC0jmF7uezpKwF3bJWvZTc/R7Nq4ae4Ku9IGPNWvKIOcquX1VE4UINEK7o82QLOW5IURn1C18FmCCv1n9ratyjM700H5GdSelKLx6QvGQXDOysnnrccrCqyR0UpaN2qEaY14f7DyxM3Af/Pgx0oJhGE=; 24:mVLYovuxeZRuTX8VH1vHfX/qbVp2GR8DtpfpmAxSi7qmfdFtZHmf3ImKujNXy/6KNZ0uD1Ffdzw6EhV44roSMQsH4Kz7hu88kdKcRVghcBc=; 7:hgZCH9Py0ZCbEYR4sqKlFtiXtLXFmU6aqEf+wrP9pVAlNhVZdzbGO5Ch290GFz2Uev03+bZS3uIy+COBnQDhqjC/bItsuIomIIvWEi0JIfL/JGmcep350eeUo15pgq6ik3Y8CMmiRb74yNzSyWRn2o33x4GiCOqUMQVu3I7MVUkHq6+ugTpMX54AI3BcXsmv5KoBG/vQ0ztPtRjpl315JKEbjBFKITBeA8PDw3aY93QLN8cRHS3p32s2mm6w3Lzz SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2018 12:48:32.6852 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dd35043f-2ba2-43f1-b702-08d56c96c40b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2666 Subject: [dpdk-dev] [PATCH] net/vdev_netvsc: fix device detection error check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The vdev_netvsc driver does periodic detection of PCI devices matched to the netvsc existed interfaces. When it finds a match, the PCI address is written to the pipe of the associated fail-safe PMD instance and a positive value is returned to the periodic check which is wrongly considered as error. Change the check to consider only a negative value as error. Fixes: e7dc5d7becc5 ("net/vdev_netvsc: implement core functionality") Signed-off-by: Matan Azrad --- drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index a8a1a7f..cbf4d59 100644 --- a/drivers/net/vdev_netvsc/vdev_netvsc.c +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c @@ -388,7 +388,7 @@ static LIST_HEAD(, vdev_netvsc_ctx) vdev_netvsc_ctx_list = LIST_FOREACH(ctx, &vdev_netvsc_ctx_list, entry) { ret = vdev_netvsc_foreach_iface(vdev_netvsc_device_probe, ctx); - if (ret) + if (ret < 0) break; } if (!vdev_netvsc_ctx_count)