From patchwork Mon Feb 5 12:01:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuanhan Liu X-Patchwork-Id: 34961 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F23E21B340; Mon, 5 Feb 2018 13:03:52 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 686B11B2FF; Mon, 5 Feb 2018 13:03:52 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D70BB20B2E; Mon, 5 Feb 2018 07:03:51 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 05 Feb 2018 07:03:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:message-id:subject:to:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=8wCxCA18dAQzrirQtAOIi+LD69yOv7fVGZUVZY28c nY=; b=p/6dJoQlAktk/RzMJKxgV8UmoLFlJWQOGn7U9d0SBZjoWHsGSYWkOxZm8 hib78XPlyOYv23I3z7KD1sVodQGV0tCm0/ZQ8tvgx250KmY6xXb0ZR3n6ZVDQsj5 e9yIoEIEIt0N24n0DSqke5Lmgbe70LY5sWS4anrRZu9XKGwRbb8zC+jsPR171XWj sCt8xEvHhnkaKwV/BU1c3MOaqKS1JrnJg4fDA0zfZvK+2diO0hpwnZ0jDf7KrCtn 5EymYmZX2fuJe5mCVgve5i3DAuWamvz81wZVzHUdbGzHn9DFjrz22gf0/vDcEJT3 UtYdWCn8CkLBdYdl3g3ZZJUCSGwNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=8wCxCA18dAQzrirQt AOIi+LD69yOv7fVGZUVZY28cnY=; b=ZXtq1VJ0UHblrxbvBOB5gkqYqcbkMPyV5 yt8Prk5he+ICKLPBJy1hl/knf65uXQW8A0jOP0y5TKb+IjZGucEPVVGa9oHuItu/ zBnPfCZ6k9BzfHO7hSTS5HeciwzPCw0WypOOsdlV8F8RFY2jvUk7jehstmeTqAEk IDTKj7j/zcUxkXNeZSYfMhY1A4alxihQbuw8Dr8eloHNLsc1H11afv2Yo2cfiePL 2tjjSEjBGuxGqJjL6z8IZFqU44h5PK2x5zGpB34hCZZfxmdxnSnuGxuHki9gxFUX CGHuE3pY5B3qVi4hec7qHv/bwQLf1ka7y9J7Z2fFOjolkMVpDtBxg== X-ME-Sender: Received: from localhost.localdomain (unknown [218.64.213.73]) by mail.messagingengine.com (Postfix) with ESMTPA id 74BB77E3DF; Mon, 5 Feb 2018 07:03:48 -0500 (EST) From: Yuanhan Liu To: dev@dpdk.org Cc: Adrien Mazarguil , Nelio Laranjeiro , Yongseok Koh , Shahaf Shuler , Yuanhan Liu , stable@dpdk.org Date: Mon, 5 Feb 2018 20:01:44 +0800 Message-Id: <1517832104-2800-1-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH] net/mlx5: fix link speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When the link is down, mlx5 kernel driver reports the link speed as -1 (UNKNOWN_SPEED). We need turn it to 0 for such case, otherwise, it will be re-queried again due to the link_speed is not 0, due to following code: 1201 if (((link->link_speed == 0) && link->link_status) || 1202 ((link->link_speed != 0) && !link->link_status)) { 1203 /* 1204 * Inconsistent status. Event likely occurred before the 1205 * kernel netdevice exposes the new status. 1206 */ Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds") Cc: stable@dpdk.org Signed-off-by: Yuanhan Liu Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 6665076..492ca07 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -808,6 +808,10 @@ mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev, int wait_to_complete) return -1; } dev_link.link_speed = ecmd->speed; + if (link_speed == -1) + dev_link.link_speed = 0; + else + dev_link.link_speed = link_speed; sc = ecmd->link_mode_masks[0] | ((uint64_t)ecmd->link_mode_masks[1] << 32); priv->link_speed_capa = 0;