From patchwork Tue Jan 30 05:56:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingjing Wu X-Patchwork-Id: 34680 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0B62F1B349; Tue, 30 Jan 2018 07:05:18 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C5F9C1B342 for ; Tue, 30 Jan 2018 07:05:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2018 22:05:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,433,1511856000"; d="scan'208";a="23499611" Received: from dpdk2.sh.intel.com ([10.67.118.195]) by FMSMGA003.fm.intel.com with ESMTP; 29 Jan 2018 22:05:14 -0800 From: Jingjing Wu To: wenzhuo.lu@intel.com Cc: jingjing.wu@intel.com, dev@dpdk.org Date: Tue, 30 Jan 2018 13:56:24 +0800 Message-Id: <1517291784-56273-1-git-send-email-jingjing.wu@intel.com> X-Mailer: git-send-email 2.4.11 Subject: [dpdk-dev] [PATCH] net/avf: fix unchecked return value issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes the coverity CHECKED_RETURN issue. Coverity issue: 257045 Fixes: 48de41ca11f0 ("net/avf: enable link status update") Reported-by: John McNamara Signed-off-by: Jingjing Wu --- drivers/net/avf/avf_ethdev.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c index cf7bbb2..511715f 100644 --- a/drivers/net/avf/avf_ethdev.c +++ b/drivers/net/avf/avf_ethdev.c @@ -609,9 +609,10 @@ avf_dev_link_update(struct rte_eth_dev *dev, new_link.link_autoneg = !!(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED); - rte_atomic64_cmpset((uint64_t *)&dev->data->dev_link, - *(uint64_t *)&dev->data->dev_link, - *(uint64_t *)&new_link); + if(rte_atomic64_cmpset((uint64_t *)&dev->data->dev_link, + *(uint64_t *)&dev->data->dev_link, + *(uint64_t *)&new_link) == 0) + return -1; return 0; }