From patchwork Thu Jan 11 16:39:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tonghao Zhang X-Patchwork-Id: 33601 X-Patchwork-Delegate: helin.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C27417288; Thu, 11 Jan 2018 17:39:59 +0100 (CET) Received: from mail-pg0-f68.google.com (mail-pg0-f68.google.com [74.125.83.68]) by dpdk.org (Postfix) with ESMTP id C7D7A2C57 for ; Thu, 11 Jan 2018 17:39:57 +0100 (CET) Received: by mail-pg0-f68.google.com with SMTP id q67so2513680pga.9 for ; Thu, 11 Jan 2018 08:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=nZYgQCl5iwNzZ+h1WguK54MJQvi3siRU99tpsqcJHFk=; b=rdUt61tWjVNHO1GhDiedKKmvlt8JOfB8e95+1MwKl1F73AyFY4t8iQer5HgRhkUiXU yz8Iy1VbyHn21CS4Oj2mrRdssKHHm5wia8jVAbmU9U4t7vRBwdD3vG3f/DkEupC1j2Gc 1UYg7GzLe1QJTyhHKRgs1/yNuVRmgP2HG2+/2QvelYdMeiOfgTbg8p6NGMprtFjg+QCT xJkkc14kp7GPeiUYqSOOpH8yMMd8xX8pWEHChSJExDfmhsb0piPxVHIQaJ7wI76nbXCc KaPJqsrF8NXoqbBm9eObpKbgimr0GgFwKYqrXbn5BI8PYPRTMKFz6JDn7cSpUHwr2AGN lJeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nZYgQCl5iwNzZ+h1WguK54MJQvi3siRU99tpsqcJHFk=; b=hKjjAd38S23u4ZoACZfLegusNV+nqBsHgm75UkGvQk++Lw0oRSosgvsNjU+Fa6WAyG xPOgKLvHbCLKeICe6fe7tr6Hkz5W2JUFGjFVxxwbEbyNPWMCXju+bTZktbOLQ6lv7oSC KuH3T5KAWdIak51BrrThBwHf4iL8jyrqc+H7SKj1kAe8QhF/Ty7aocBWSlBWMYycnB4o zaNQvC828yoW13zEDpC2ZECBgAmTP3YVdb/ydwl32hI2LAgIjTvmRbLC13SOb617PXnY h1zd41+mqryA6l39VDexBSoEfQy5qV2EzC5lW6679C6qjTd095TRyjTKinb9BlHDeSL5 NOaQ== X-Gm-Message-State: AKGB3mJD2hWTOOI2xd0H+e/WPta66rdg4sVTl5MWx6CDDoxY5MzFtCfo esy9okMnVWK2ureqOK6DVCIsCdrw X-Google-Smtp-Source: ACJfBovc1rq4TTscpHvHDYOeA/CwFybQC/vPA0ALjIfzM6MeDlnL0lBkt6qEUsfqlMaYY7AxlgU0/A== X-Received: by 10.159.242.193 with SMTP id x1mr17715875plw.85.1515688796913; Thu, 11 Jan 2018 08:39:56 -0800 (PST) Received: from local.opencloud.tech.localdomain ([183.240.196.57]) by smtp.gmail.com with ESMTPSA id w21sm40940126pfl.50.2018.01.11.08.39.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jan 2018 08:39:56 -0800 (PST) From: xiangxia.m.yue@gmail.com To: beilei.xing@intel.com, dev@dpdk.org Cc: Tonghao Zhang Date: Thu, 11 Jan 2018 08:39:48 -0800 Message-Id: <1515688791-2794-1-git-send-email-xiangxia.m.yue@gmail.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-dev] [PATCH v2 1/4] net/ixgbevf: unregister irq handler when other interrupts not allowed. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Tonghao Zhang When bind the ixgbe VF (e.g 82599 card) to igb_uio and enable the rx-interrupt, there will be more than one epoll_wait on intr_handle.fd. One is in "eal-intr-thread" thread, and the others are in the thread which call the "rte_epoll_wait". The problem is that sometimes "eal-intr-thread" thread will process the rx interrupt, and then rte_epoll_wait can't get the event anymore, and the packets may be lost. The patch unregister the status interrupt handler in "eal-intr-thread" thread and the ixgbe pf is in the same case. Signed-off-by: Tonghao Zhang Acked-by: Beilei Xing --- drivers/net/ixgbe/ixgbe_ethdev.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index ff19a56..0e056a2 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -5078,6 +5078,15 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, } ixgbevf_configure_msix(dev); + if (!rte_intr_allow_others(intr_handle)) { + rte_intr_callback_unregister(intr_handle, + ixgbevf_dev_interrupt_handler, + dev); + if (dev->data->dev_conf.intr_conf.lsc != 0) + PMD_INIT_LOG(INFO, "lsc won't enable because of" + " no intr multiplex"); + } + /* When a VF port is bound to VFIO-PCI, only miscellaneous interrupt * is mapped to VFIO vector 0 in eth_ixgbevf_dev_init( ). * If previous VFIO interrupt mapping setting in eth_ixgbevf_dev_init( ) @@ -5120,6 +5129,12 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, ixgbe_dev_clear_queues(dev); + if (!rte_intr_allow_others(intr_handle)) + /* resume to the default handler */ + rte_intr_callback_register(intr_handle, + ixgbevf_dev_interrupt_handler, + (void *)dev); + /* Clean datapath event and queue/vec mapping */ rte_intr_efd_disable(intr_handle); if (intr_handle->intr_vec != NULL) {