From patchwork Sat Dec 9 01:55:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiao Wang X-Patchwork-Id: 32047 X-Patchwork-Delegate: helin.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1CE577CFD; Sat, 9 Dec 2017 02:53:13 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 43C0037B1; Sat, 9 Dec 2017 02:53:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Dec 2017 17:53:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,380,1508828400"; d="scan'208";a="185059064" Received: from dpdk-xiao-1.sh.intel.com ([10.67.110.203]) by fmsmga005.fm.intel.com with ESMTP; 08 Dec 2017 17:53:08 -0800 From: Xiao Wang To: qi.z.zhang@intel.com Cc: dev@dpdk.org, stable@dpdk.org, Xiao Wang Date: Fri, 8 Dec 2017 17:55:41 -0800 Message-Id: <1512784541-128860-1-git-send-email-xiao.w.wang@intel.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-dev] [PATCH] net/fm10k: fix logical port delete X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When closing port, we need to send mailbox messages to switch manager to reset multicast mode and delete logical port. In the latest IES_SDK, e.g. v4.3.3, switch takes longer time to handle these mailbox messages. So this patch adds longer delay to accommodate this change. Otherwise, the mailbox will be closed before all the messages are handled, as a result, the logical port remains in switch manager after port is closed. Fixes: b961fe9344dd ("net/fm10k: fix MAC address removal from switch") Cc: stable@dpdk.org Signed-off-by: Xiao Wang Acked-by: Helin Zhang --- drivers/net/fm10k/fm10k_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index 2d05a46..58dac38 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c @@ -54,7 +54,7 @@ /* Wait interval to get switch status */ #define WAIT_SWITCH_MSG_US 100000 /* A period of quiescence for switch */ -#define FM10K_SWITCH_QUIESCE_US 10000 +#define FM10K_SWITCH_QUIESCE_US 100000 /* Number of chars per uint32 type */ #define CHARS_PER_UINT32 (sizeof(uint32_t)) #define BIT_MASK_PER_UINT32 ((1 << CHARS_PER_UINT32) - 1) @@ -1242,7 +1242,7 @@ static inline int fm10k_glort_valid(struct fm10k_hw *hw) MAX_LPORT_NUM, false); fm10k_mbx_unlock(hw); - /* allow 10ms for device to quiesce */ + /* allow 100ms for device to quiesce */ rte_delay_us(FM10K_SWITCH_QUIESCE_US); /* Stop mailbox service first */