diff mbox

[dpdk-dev,2/2] Change root makefile license to SPDX tag

Message ID 1511768764-14595-2-git-send-email-hemant.agrawal@nxp.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Hemant Agrawal Nov. 27, 2017, 7:46 a.m. UTC 
  Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 GNUmakefile | 27 +--------------------------
 Makefile    | 27 +--------------------------
 2 files changed, 2 insertions(+), 52 deletions(-)

Comments

Bruce Richardson Nov. 27, 2017, 12:01 p.m. UTC | #1 
On Mon, Nov 27, 2017 at 01:16:04PM +0530, Hemant Agrawal wrote:
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  GNUmakefile | 27 +--------------------------
>  Makefile    | 27 +--------------------------
>  2 files changed, 2 insertions(+), 52 deletions(-)
> 
> diff --git a/GNUmakefile b/GNUmakefile
> index 45b7fbb..2602531 100644
> --- a/GNUmakefile
> +++ b/GNUmakefile
> @@ -1,33 +1,8 @@
> -#   BSD LICENSE
>  #
>  #   Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
>  #   All rights reserved.
>  #

As part of this cleanup, I think it might be also useful to remove the
duplicate "All rights reserved" on the files. There is surely no need to
have the statement duplicated.

/Bruce
Hemant Agrawal Dec. 1, 2017, 8:41 a.m. UTC | #2 
On 11/27/2017 5:31 PM, Bruce Richardson wrote:
> On Mon, Nov 27, 2017 at 01:16:04PM +0530, Hemant Agrawal wrote:
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>>  GNUmakefile | 27 +--------------------------
>>  Makefile    | 27 +--------------------------
>>  2 files changed, 2 insertions(+), 52 deletions(-)
>>
>> diff --git a/GNUmakefile b/GNUmakefile
>> index 45b7fbb..2602531 100644
>> --- a/GNUmakefile
>> +++ b/GNUmakefile
>> @@ -1,33 +1,8 @@
>> -#   BSD LICENSE
>>  #
>>  #   Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
>>  #   All rights reserved.
>>  #
>
> As part of this cleanup, I think it might be also useful to remove the
> duplicate "All rights reserved" on the files. There is surely no need to
> have the statement duplicated.
>
Done.
BTW, this patch will need an ACK from Intel :)

> /Bruce
>
diff mbox

Patch

diff --git a/GNUmakefile b/GNUmakefile
index 45b7fbb..2602531 100644
--- a/GNUmakefile
+++ b/GNUmakefile
@@ -1,33 +1,8 @@ 
-#   BSD LICENSE
 #
 #   Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
 #   All rights reserved.
 #
-#   Redistribution and use in source and binary forms, with or without
-#   modification, are permitted provided that the following conditions
-#   are met:
-#
-#     * Redistributions of source code must retain the above copyright
-#       notice, this list of conditions and the following disclaimer.
-#     * Redistributions in binary form must reproduce the above copyright
-#       notice, this list of conditions and the following disclaimer in
-#       the documentation and/or other materials provided with the
-#       distribution.
-#     * Neither the name of Intel Corporation nor the names of its
-#       contributors may be used to endorse or promote products derived
-#       from this software without specific prior written permission.
-#
-#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#   SPDX-License-Identifier:        BSD-3-Clause
 
 #
 # Head Makefile for compiling rte SDK
diff --git a/Makefile b/Makefile
index f4b807e..afe8b05 100644
--- a/Makefile
+++ b/Makefile
@@ -1,33 +1,8 @@ 
-#   BSD LICENSE
 #
 #   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
 #   All rights reserved.
 #
-#   Redistribution and use in source and binary forms, with or without
-#   modification, are permitted provided that the following conditions
-#   are met:
-#
-#     * Redistributions of source code must retain the above copyright
-#       notice, this list of conditions and the following disclaimer.
-#     * Redistributions in binary form must reproduce the above copyright
-#       notice, this list of conditions and the following disclaimer in
-#       the documentation and/or other materials provided with the
-#       distribution.
-#     * Neither the name of Intel Corporation nor the names of its
-#       contributors may be used to endorse or promote products derived
-#       from this software without specific prior written permission.
-#
-#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#   SPDX-License-Identifier:        BSD-3-Clause
 
 .error Error please compile using GNU Make (gmake)