From patchwork Wed Nov 8 06:17:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia He X-Patchwork-Id: 31258 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D02FA1B383; Wed, 8 Nov 2017 07:18:43 +0100 (CET) Received: from mail-pl0-f66.google.com (mail-pl0-f66.google.com [209.85.160.66]) by dpdk.org (Postfix) with ESMTP id 021BE1B34F for ; Wed, 8 Nov 2017 07:18:42 +0100 (CET) Received: by mail-pl0-f66.google.com with SMTP id t7so665578plm.0 for ; Tue, 07 Nov 2017 22:18:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=foW7Oq+e2VBMP0b/Zne+PWYXWk5XhRsyuKLcTEun4Vk=; b=ceoes0jPJkincDdq2Gul5luSgKhLFW2rrmjOp6RgaLoi/MsuhO8MD8C2rb9vHxFJ2x hk8tNemErWVkO3YVe6rQ6b7uVXJoL6SKyp4Q1UpZwJ9PVvraCbN6obHcYMf7PlzLmoZD CRyCgBIFyH6oJDatJMBmDWlY6s60CU3hXs/9C3Fe+SeKwx6xUt9GQwSQmtDUrrGG1fFU xYFCN4R4ss+iBG/xKmgUGQ0y2+XpZVt38E+CJOtBf+WygnpnICOLb+8nQ+s+XyjgmGLx sLTTbHpxh3WLW8ET3relmKVENzvvvOBgPykRi/1SClJx9Qq0n1EEeO5PEIT8GqmMz0IF w75w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=foW7Oq+e2VBMP0b/Zne+PWYXWk5XhRsyuKLcTEun4Vk=; b=eCpKoxnePkzELdEWHPnbzQKNln7kZSxwzBIdeaqJPvJL5arVWxsbzP8WCKGIpSwW+x 2nFT8uMtMlN8xi4apsCW829qec+j0u5ZGvlv693fky95ZREIs7QTSxGf00971SdAA3wc vvgK38UmWFPulnDU7aiitkZqmm5y6o3BopwOtYSbzQkky1RcD/NXJgTyooiQBS9AhenO p51nlCArjyObdjgPxrN4xnqooy7eNMllaKPaKQinSrQ1KIHN4+mtwRI4SqA6VYg5Wbmh J83cyjUwt7oeQj7R5z6oDpbGtCQM4cTwGNMLE827+VFMojdsC/QO0+CW9F1y6wYCNjIv vvPA== X-Gm-Message-State: AJaThX6aOgNinuv4AHEar6bXbQTDMuHB7lRgE5hf514M/Lo3cX54kZwW KpquZJs++sY/c0KT1//nTbk= X-Google-Smtp-Source: ABhQp+R+lD+lPyViafc9N6n07R6Zn7EvcjOfXMH6iDsffBQLl25vOq3yTwvPcUEQUZqMYocFKBlq2Q== X-Received: by 10.84.149.168 with SMTP id m37mr1251267pla.36.1510121922137; Tue, 07 Nov 2017 22:18:42 -0800 (PST) Received: from nfv-demo01.hxtcorp.net ([38.106.11.25]) by smtp.gmail.com with ESMTPSA id t63sm6281020pgc.19.2017.11.07.22.18.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 07 Nov 2017 22:18:41 -0800 (PST) From: Jia He To: jerin.jacob@caviumnetworks.com, dev@dpdk.org, olivier.matz@6wind.com Cc: konstantin.ananyev@intel.com, bruce.richardson@intel.com, jianbo.liu@arm.com, hemant.agrawal@nxp.com, Jia He , jia.he@hxt-semitech.com Date: Wed, 8 Nov 2017 06:17:10 +0000 Message-Id: <1510121832-16439-1-git-send-email-hejianet@gmail.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" for the code as follows: if (condition) rte_smp_rmb(); else rte_smp_wmb(); Without this patch, compiler will report this error: error: 'else' without a previous 'if' Signed-off-by: Jia He Signed-off-by: jia.he@hxt-semitech.com --- lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h index 0b70d62..38c3393 100644 --- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h +++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h @@ -43,8 +43,8 @@ extern "C" { #include "generic/rte_atomic.h" -#define dsb(opt) { asm volatile("dsb " #opt : : : "memory"); } -#define dmb(opt) { asm volatile("dmb " #opt : : : "memory"); } +#define dsb(opt) asm volatile("dsb " #opt : : : "memory"); +#define dmb(opt) asm volatile("dmb " #opt : : : "memory"); #define rte_mb() dsb(sy)