From patchwork Fri Nov 3 09:40:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Hunt, David" X-Patchwork-Id: 31156 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4ADD01B613; Fri, 3 Nov 2017 10:40:33 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id BB1131B610 for ; Fri, 3 Nov 2017 10:40:31 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP; 03 Nov 2017 02:40:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,338,1505804400"; d="scan'208";a="171032384" Received: from silpixa00397898.ir.intel.com (HELO silpixa00397898.ger.corp.intel.com) ([10.237.223.116]) by fmsmga005.fm.intel.com with ESMTP; 03 Nov 2017 02:40:29 -0700 From: David Hunt To: dev@dpdk.org Cc: bruce.richardson@intel.com, Vipin Varghese , David Hunt Date: Fri, 3 Nov 2017 09:40:03 +0000 Message-Id: <1509702003-70630-1-git-send-email-david.hunt@intel.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH v1] mk: allow use of toolchain cflags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Vipin Varghese with 'export TOOLCHAIN_CFLAGS' the values are not inherited throuhout make system. The change appends the user defined cflags. Signed-off-by: Vipin Varghese Signed-off-by: David Hunt --- mk/toolchain/clang/rte.vars.mk | 6 +++--- mk/toolchain/gcc/rte.vars.mk | 6 +++--- mk/toolchain/icc/rte.vars.mk | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/mk/toolchain/clang/rte.vars.mk b/mk/toolchain/clang/rte.vars.mk index dde922d..1b017db 100644 --- a/mk/toolchain/clang/rte.vars.mk +++ b/mk/toolchain/clang/rte.vars.mk @@ -59,9 +59,9 @@ HOSTCC = clang endif HOSTAS = as -TOOLCHAIN_ASFLAGS = -TOOLCHAIN_CFLAGS = -TOOLCHAIN_LDFLAGS = +TOOLCHAIN_ASFLAGS += +TOOLCHAIN_CFLAGS += +TOOLCHAIN_LDFLAGS += WERROR_FLAGS := -W -Wall -Wstrict-prototypes -Wmissing-prototypes WERROR_FLAGS += -Wmissing-declarations -Wold-style-definition -Wpointer-arith diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk index 3b907e2..e52da4d 100644 --- a/mk/toolchain/gcc/rte.vars.mk +++ b/mk/toolchain/gcc/rte.vars.mk @@ -59,9 +59,9 @@ HOSTCC = gcc endif HOSTAS = as -TOOLCHAIN_ASFLAGS = -TOOLCHAIN_CFLAGS = -TOOLCHAIN_LDFLAGS = +TOOLCHAIN_ASFLAGS += +TOOLCHAIN_CFLAGS += +TOOLCHAIN_LDFLAGS += ifeq ($(CONFIG_RTE_LIBRTE_GCOV),y) TOOLCHAIN_CFLAGS += --coverage diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk index 33a8ba7..70984b7 100644 --- a/mk/toolchain/icc/rte.vars.mk +++ b/mk/toolchain/icc/rte.vars.mk @@ -59,9 +59,9 @@ HOSTCC = gcc endif HOSTAS = as -TOOLCHAIN_CFLAGS = -TOOLCHAIN_LDFLAGS = -TOOLCHAIN_ASFLAGS = +TOOLCHAIN_CFLAGS += +TOOLCHAIN_LDFLAGS += +TOOLCHAIN_ASFLAGS += # Turn off some ICC warnings - # Remark #271 : trailing comma is nonstandard