From patchwork Fri Nov 3 08:47:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Dai X-Patchwork-Id: 31155 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7ED5B1B64F; Fri, 3 Nov 2017 09:58:52 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C98501B607; Fri, 3 Nov 2017 09:58:49 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Nov 2017 01:58:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,337,1505804400"; d="scan'208";a="171009258" Received: from dpdk4.bj.intel.com ([172.16.182.85]) by fmsmga005.fm.intel.com with ESMTP; 03 Nov 2017 01:58:48 -0700 From: Wei Dai To: jingjing.wu@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org, Wei Dai , stable@dpdk.org Date: Fri, 3 Nov 2017 16:47:30 +0800 Message-Id: <1509698850-13301-3-git-send-email-wei.dai@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1509698850-13301-1-git-send-email-wei.dai@intel.com> References: <1509693243-43101-1-git-send-email-wei.dai@intel.com> <1509698850-13301-1-git-send-email-wei.dai@intel.com> Subject: [dpdk-dev] [PATCH v3 2/2] net/i40e: fix Rx queue interrupt mapping in VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When a VF port is bound to VFIO-PCI, miscellaneous interrupt is mapped to MSI-X vector 0 and Rx queues interrupt are mapped to other vectors in vfio_enable_msix( ). To simplify implementation, all VFIO-PCI bound i40e VF Rx queue interrupts can be mapped in vector 1. And as current igb_uio only support only one vector, i40e VF PMD should use vector 0 for igb_uio and vector 1 for VFIO-PCI. Without this patch, VF Rx queue interrupt is mapped to vector 0 in register settings and mapped to VFIO vector 1 in vfio_enable_msix( ), and then all Rx queue interrupts will be missed. Also remove 2 unsed macro definitions. Fixes: 4b90a3ff26c5 ("i40evf: support Rx interrupt") Fixes: 975ffea6f671 ("net/i40e: remove DPDK PF version specific code") Cc: stable@dpdk.org Signed-off-by: Wei Dai Acked-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev_vf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index f2af022..1118c74 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -68,8 +68,6 @@ #include "i40e_rxtx.h" #include "i40e_ethdev.h" #include "i40e_pf.h" -#define I40EVF_VSI_DEFAULT_MSIX_INTR 1 -#define I40EVF_VSI_DEFAULT_MSIX_INTR_LNX 0 /* busy wait delay in msec */ #define I40EVF_BUSY_WAIT_DELAY 10 @@ -654,7 +652,7 @@ i40evf_config_irq_map(struct rte_eth_dev *dev) int i, err; if (rte_intr_allow_others(intr_handle)) - vector_id = I40EVF_VSI_DEFAULT_MSIX_INTR_LNX; + vector_id = I40E_RX_VEC_START; else vector_id = I40E_MISC_VEC_ID;