From patchwork Thu Oct 26 13:44:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tonghao Zhang X-Patchwork-Id: 30970 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 34FA81BAF6; Thu, 26 Oct 2017 15:44:54 +0200 (CEST) Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) by dpdk.org (Postfix) with ESMTP id A4A621BAF0 for ; Thu, 26 Oct 2017 15:44:53 +0200 (CEST) Received: by mail-pf0-f194.google.com with SMTP id p87so2554143pfj.3 for ; Thu, 26 Oct 2017 06:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HzVsyj7kvC/yJgg1jVpPN90SDAv224a/48G5f0ejSJA=; b=IzaLc+ozIhF/okF9I+OCmXstyW4EEsd2YM2cOW45931a8uCNmpHy1LZFl84TihgApS fQ4R7w26yLcD8oBCuDjZDLanlMnSkXURfL0chLESyXjFaLpI2ePpYe4N2/nVf3tmN8ox NZJVVarAaH2+QaqZfqpwvz6yJRSR2gOIYmddKNUookX6u/xLHlm+ed27PqglsjjYkwms bspCkm6+0y3m09nNPEAWlQN4/eisth6sOFkCZT6rV8LOw+eCOo+fiSCMXcLlwGfPYiFv hnYcvjw7aQnH44mbTj8lyg/XfXrcVJ5EdbjNXkdXM0B6OerkuNSNQOtg2jvnBDOom74x uZWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HzVsyj7kvC/yJgg1jVpPN90SDAv224a/48G5f0ejSJA=; b=LEGVr54ZtQtVNEaplCffhnR8OMGZBvMdsc89q3Z9YXkqGcUvhzYUcQJqj/ZUkMPwD3 4hKwa0r5strMOjPbE7u1VNh7GrduLQXWB+8k2BoK18Qz9C7ZquTGngAWU601ovgOtS5/ vloaTB0/MRv6dq22Z1PX3CLU1Vrt0f3X9KqMGRfeQeksSTcOeWYGcg2IOz6qj+v7zewy 3HUyHOcBUnVX+4jxx5U9Oju8PDnGrj/wICbLFJe+OJZmTCTHiH/E+MCo4sVxO52lTLPX hVZbwv/fiBcAiZboreYSHy7Qw+MFflp2lTSee4H8CQyJtsVjLNR6Be5xDZs6LSSe6TSN FkJQ== X-Gm-Message-State: AMCzsaUrCzPgY39jo/5OGUaeSEHY+19B3NiMoBLloy3FURV9MbDHFoFt kVO1Gf8Q6msIL0Hhg435lDJdRQ== X-Google-Smtp-Source: ABhQp+SB5TiIO2olp0BppIgMrs+KKUdjXfqhnFxEUDSUlDbJlDXgIxkOXGtcbHCkKd5pF93+XtISfw== X-Received: by 10.99.126.25 with SMTP id z25mr5017110pgc.415.1509025492757; Thu, 26 Oct 2017 06:44:52 -0700 (PDT) Received: from local.opencloud.tech.localdomain ([13.94.31.177]) by smtp.gmail.com with ESMTPSA id w9sm10921172pfk.16.2017.10.26.06.44.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Oct 2017 06:44:52 -0700 (PDT) From: xiangxia.m.yue@gmail.com To: dev@dpdk.org Cc: Tonghao Zhang Date: Thu, 26 Oct 2017 06:44:41 -0700 Message-Id: <1509025484-15771-1-git-send-email-xiangxia.m.yue@gmail.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/4] net/ixgbevf: unregister irq handler when other interrupts not allowed. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Tonghao Zhang When we bind the ixgbe VF (e.g 82599 card) to igb_uio and enable the rx-interrupt, there will be more than one epoll_wait on intr_handle.fd. One is in "eal-intr-thread" thread, and the others are in the thread which call the "rte_epoll_wait". The problem is that sometiems "eal-intr-thread" thread will process the rx interrupt, and rte_epoll_wait can’t get the event any more, and the packets may be lost. We should unregister the status interrupt handler in "eal-intr-thread" thread and the ixgbe is in the same case. Signed-off-by: Tonghao Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 4339347..5994e55 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -5070,6 +5070,15 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, } ixgbevf_configure_msix(dev); + if (!rte_intr_allow_others(intr_handle)) { + rte_intr_callback_unregister(intr_handle, + ixgbevf_dev_interrupt_handler, + dev); + if (dev->data->dev_conf.intr_conf.lsc != 0) + PMD_INIT_LOG(INFO, "lsc won't enable because of" + " no intr multiplex"); + } + /* When a VF port is bound to VFIO-PCI, only miscellaneous interrupt * is mapped to VFIO vector 0 in eth_ixgbevf_dev_init( ). * If previous VFIO interrupt mapping setting in eth_ixgbevf_dev_init( ) @@ -5111,6 +5120,12 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, dev->data->scattered_rx = 0; ixgbe_dev_clear_queues(dev); + + if (!rte_intr_allow_others(intr_handle)) + /* resume to the default handler */ + rte_intr_callback_register(intr_handle, + ixgbevf_dev_interrupt_handler, + (void *)dev); /* Clean datapath event and queue/vec mapping */ rte_intr_efd_disable(intr_handle);