From patchwork Tue Oct 10 11:24:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yong Wang X-Patchwork-Id: 30040 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BDA311B270; Tue, 10 Oct 2017 13:34:16 +0200 (CEST) Received: from mxct.zte.com.cn (out1.zte.com.cn [202.103.147.172]) by dpdk.org (Postfix) with ESMTP id E0C301B22D; Tue, 10 Oct 2017 13:34:14 +0200 (CEST) Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id A917450BD8E9B1848FE6; Tue, 10 Oct 2017 19:34:12 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id v9ABY3k8039059; Tue, 10 Oct 2017 19:34:03 +0800 (GMT-8) (envelope-from wang.yong19@zte.com.cn) Received: from localhost.localdomain.localdomain ([10.43.166.165]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2017101019340731-304279 ; Tue, 10 Oct 2017 19:34:07 +0800 From: Yong Wang To: jingjing.wu@intel.com Cc: dev@dpdk.org, Yong Wang , stable@dpdk.org Date: Tue, 10 Oct 2017 07:24:20 -0400 Message-Id: <1507634660-19880-1-git-send-email-wang.yong19@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2017-10-10 19:34:07, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2017-10-10 19:34:00, Serialize complete at 2017-10-10 19:34:00 X-MAIL: mse01.zte.com.cn v9ABY3k8039059 Subject: [dpdk-dev] [PATCH v2] net/i40e: fix uninitialized variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In func i40evf_dev_link_update(), "new_link.link_autoneg" is used in func call i40evf_dev_atomic_write_link_status(), but is uninitialized. Fixes: 2a73125b7041 ("i40evf: fix link info update") Cc: stable@dpdk.org Signed-off-by: Yong Wang Acked-by: Jingjing Wu --- v2 change: set it by checking link_speeds of dev. --- drivers/net/i40e/i40e_ethdev_vf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 111ac39..46a566f 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -2100,6 +2100,7 @@ static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev) new_link.link_duplex = ETH_LINK_FULL_DUPLEX; new_link.link_status = vf->link_up ? ETH_LINK_UP : ETH_LINK_DOWN; + new_link.link_autoneg = dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED; i40evf_dev_atomic_write_link_status(dev, &new_link);