diff mbox

[dpdk-dev,v2] net/i40e: fix uninitialized variable

Message ID 1507634660-19880-1-git-send-email-wang.yong19@zte.com.cn (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Yong Wang Oct. 10, 2017, 11:24 a.m. UTC 
  In func i40evf_dev_link_update(), "new_link.link_autoneg" is used in
func call i40evf_dev_atomic_write_link_status(), but is uninitialized.

Fixes: 2a73125b7041 ("i40evf: fix link info update")

Cc: stable@dpdk.org

Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
---
v2 change:
	set it by checking link_speeds of dev.
---
 drivers/net/i40e/i40e_ethdev_vf.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jingjing Wu Oct. 10, 2017, 1:24 p.m. UTC | #1 
> -----Original Message-----
> From: Yong Wang [mailto:wang.yong19@zte.com.cn]
> Sent: Tuesday, October 10, 2017 7:24 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Yong Wang <wang.yong19@zte.com.cn>; stable@dpdk.org
> Subject: [PATCH v2] net/i40e: fix uninitialized variable
> 
> In func i40evf_dev_link_update(), "new_link.link_autoneg" is used in
> func call i40evf_dev_atomic_write_link_status(), but is uninitialized.
> 
> Fixes: 2a73125b7041 ("i40evf: fix link info update")
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>

Acked-by: Jingjing Wu <jingjing.wu@intel.com>

Thanks
Jingjing
Ferruh Yigit Oct. 10, 2017, 11:17 p.m. UTC | #2 
On 10/10/2017 2:24 PM, Wu, Jingjing wrote:
> 
> 
>> -----Original Message-----
>> From: Yong Wang [mailto:wang.yong19@zte.com.cn]
>> Sent: Tuesday, October 10, 2017 7:24 PM
>> To: Wu, Jingjing <jingjing.wu@intel.com>
>> Cc: dev@dpdk.org; Yong Wang <wang.yong19@zte.com.cn>; stable@dpdk.org
>> Subject: [PATCH v2] net/i40e: fix uninitialized variable
>>
>> In func i40evf_dev_link_update(), "new_link.link_autoneg" is used in
>> func call i40evf_dev_atomic_write_link_status(), but is uninitialized.
>>
>> Fixes: 2a73125b7041 ("i40evf: fix link info update")
>>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> 
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 111ac39..46a566f 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2100,6 +2100,7 @@  static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)
 	new_link.link_duplex = ETH_LINK_FULL_DUPLEX;
 	new_link.link_status = vf->link_up ? ETH_LINK_UP :
 					     ETH_LINK_DOWN;
+	new_link.link_autoneg = dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED;
 
 	i40evf_dev_atomic_write_link_status(dev, &new_link);