From patchwork Fri Sep 15 11:48:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yong Wang X-Patchwork-Id: 28759 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5753F2BBE; Fri, 15 Sep 2017 14:01:48 +0200 (CEST) Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.217.80.70]) by dpdk.org (Postfix) with ESMTP id 59A0C1396 for ; Fri, 15 Sep 2017 14:01:45 +0200 (CEST) Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id 10F4F46E4FBF9BAB14AC; Fri, 15 Sep 2017 20:01:45 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id v8FC1SF4011136; Fri, 15 Sep 2017 20:01:28 +0800 (GMT-8) (envelope-from wang.yong19@zte.com.cn) Received: from localhost.localdomain.localdomain ([10.43.166.165]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2017091520013448-2644124 ; Fri, 15 Sep 2017 20:01:34 +0800 From: Yong Wang To: shijith.thotton@cavium.com Cc: dev@dpdk.org, Yong Wang Date: Fri, 15 Sep 2017 07:48:28 -0400 Message-Id: <1505476108-11005-1-git-send-email-wang.yong19@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2017-09-15 20:01:34, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2017-09-15 20:01:12, Serialize complete at 2017-09-15 20:01:12 X-MAIL: mse01.zte.com.cn v8FC1SF4011136 Subject: [dpdk-dev] [PATCH v2] net/liquidio: fix uninitialized variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In func lio_dev_link_update(), "link.link_autoneg" is used in func call lio_dev_atomic_write_link_status(), but is uninitialized. v2: * Modify the initial value of 'link.link_autoneg' from 'ETH_LINK_FIXED' to 'ETH_LINK_AUTONEG'. Signed-off-by: Yong Wang Acked-by: Shijith Thotton --- drivers/net/liquidio/lio_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c index 479936a..30119d2 100644 --- a/drivers/net/liquidio/lio_ethdev.c +++ b/drivers/net/liquidio/lio_ethdev.c @@ -939,6 +939,7 @@ struct rte_lio_xstats_name_off { link.link_status = ETH_LINK_DOWN; link.link_speed = ETH_SPEED_NUM_NONE; link.link_duplex = ETH_LINK_HALF_DUPLEX; + link.link_autoneg = ETH_LINK_AUTONEG; memset(&old, 0, sizeof(old)); /* Return what we found */