diff mbox

[dpdk-dev,v2] net/liquidio: fix uninitialized variable

Message ID 1505476108-11005-1-git-send-email-wang.yong19@zte.com.cn (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Yong Wang Sept. 15, 2017, 11:48 a.m. UTC 
  In func lio_dev_link_update(), "link.link_autoneg" is used in func call
lio_dev_atomic_write_link_status(), but is uninitialized.

v2:
* Modify the initial value of 'link.link_autoneg' from 'ETH_LINK_FIXED'
  to 'ETH_LINK_AUTONEG'.

Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
---
 drivers/net/liquidio/lio_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Shijith Thotton Sept. 18, 2017, 6:27 a.m. UTC | #1 
On Fri, Sep 15, 2017 at 07:48:28AM -0400, Yong Wang wrote:
> In func lio_dev_link_update(), "link.link_autoneg" is used in func call
> lio_dev_atomic_write_link_status(), but is uninitialized.
> 
> v2:
> * Modify the initial value of 'link.link_autoneg' from 'ETH_LINK_FIXED'
>   to 'ETH_LINK_AUTONEG'.

Please remove change log from commit message[1] and use --in-reply-to option
while sending new versions of a patch.

1. http://dpdk.org/ml/archives/dev/2017-September/075426.html

> 
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> ---

You can move change log here.

>  drivers/net/liquidio/lio_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
> index 479936a..30119d2 100644
> --- a/drivers/net/liquidio/lio_ethdev.c
> +++ b/drivers/net/liquidio/lio_ethdev.c
> @@ -939,6 +939,7 @@ struct rte_lio_xstats_name_off {
>  	link.link_status = ETH_LINK_DOWN;
>  	link.link_speed = ETH_SPEED_NUM_NONE;
>  	link.link_duplex = ETH_LINK_HALF_DUPLEX;
> +	link.link_autoneg = ETH_LINK_AUTONEG;
>  	memset(&old, 0, sizeof(old));
>  
>  	/* Return what we found */
> -- 
> 1.8.3.1
>
Shijith Thotton Sept. 19, 2017, 6:45 a.m. UTC | #2 
On Fri, Sep 15, 2017 at 07:48:28AM -0400, Yong Wang wrote:
> In func lio_dev_link_update(), "link.link_autoneg" is used in func call
> lio_dev_atomic_write_link_status(), but is uninitialized.
> 
> v2:
> * Modify the initial value of 'link.link_autoneg' from 'ETH_LINK_FIXED'
>   to 'ETH_LINK_AUTONEG'.
> 
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>

Acked-by: Shijith Thotton <shijith.thotton@caviumnetworks.com>

> ---
>  drivers/net/liquidio/lio_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
> index 479936a..30119d2 100644
> --- a/drivers/net/liquidio/lio_ethdev.c
> +++ b/drivers/net/liquidio/lio_ethdev.c
> @@ -939,6 +939,7 @@ struct rte_lio_xstats_name_off {
>  	link.link_status = ETH_LINK_DOWN;
>  	link.link_speed = ETH_SPEED_NUM_NONE;
>  	link.link_duplex = ETH_LINK_HALF_DUPLEX;
> +	link.link_autoneg = ETH_LINK_AUTONEG;
>  	memset(&old, 0, sizeof(old));
>  
>  	/* Return what we found */
> -- 
> 1.8.3.1
>
Ferruh Yigit Sept. 19, 2017, 7:27 a.m. UTC | #3 
On 9/19/2017 7:45 AM, Shijith Thotton wrote:
> On Fri, Sep 15, 2017 at 07:48:28AM -0400, Yong Wang wrote:
>> In func lio_dev_link_update(), "link.link_autoneg" is used in func call
>> lio_dev_atomic_write_link_status(), but is uninitialized.
>>
>> v2:
>> * Modify the initial value of 'link.link_autoneg' from 'ETH_LINK_FIXED'
>>   to 'ETH_LINK_AUTONEG'.
>>
>> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> 
> Acked-by: Shijith Thotton <shijith.thotton@caviumnetworks.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
index 479936a..30119d2 100644
--- a/drivers/net/liquidio/lio_ethdev.c
+++ b/drivers/net/liquidio/lio_ethdev.c
@@ -939,6 +939,7 @@  struct rte_lio_xstats_name_off {
 	link.link_status = ETH_LINK_DOWN;
 	link.link_speed = ETH_SPEED_NUM_NONE;
 	link.link_duplex = ETH_LINK_HALF_DUPLEX;
+	link.link_autoneg = ETH_LINK_AUTONEG;
 	memset(&old, 0, sizeof(old));
 
 	/* Return what we found */